Re: [netmod] review of draft-acee-netmod-rfc8022bis-05

2017-11-03 Thread Vladimir Vassilev
On 11/03/2017 05:49 PM, Acee Lindem (acee) wrote: Hi Vladimir, Thanks for comments - see inline. On 10/29/17, 8:43 PM, "netmod on behalf of Vladimir Vassilev" wrote: Hello, I have reviewed draft-acee-netmod-rfc8022bis-05. My

Re: [netmod] draft-clacla-netmod-yang-model-update-00.txt : Re: [RTG-DIR] handling module incompatibility => handling module transition

2017-11-03 Thread Juergen Schoenwaelder
My take here is that structured version numbers do only partially solve the problem. Andy's work years ago on packages offers in my view a superior foundation for a solution. Once we can bundle modules that are designed and known to work together into meaningful packages, then it may be possible

Re: [netmod] ietf-access-control-l...@2017-10-03.yang : Can access-lists use a grouping?

2017-11-03 Thread M. Ranganathan
Hello Mahesh, On Thu, Nov 2, 2017 at 11:36 PM, Mahesh Jethanandani < mjethanand...@gmail.com> wrote: > > On Nov 2, 2017, at 11:34 PM, M. Ranganathan wrote: > > Hi Rob, Mahesh, > > Thanks for reading. > > On Thu, Nov 2, 2017 at 11:00 AM, Robert Wilton wrote:

Re: [netmod] review of draft-acee-netmod-rfc8022bis-05

2017-11-03 Thread Acee Lindem (acee)
Hi Vladimir, Thanks for comments - see inline. On 10/29/17, 8:43 PM, "netmod on behalf of Vladimir Vassilev" wrote: >Hello, > >I have reviewed draft-acee-netmod-rfc8022bis-05. My conclusion is that >the YANG modules part of the

Re: [netmod] review of draft-ietf-netmod-schema-mount-08

2017-11-03 Thread Ladislav Lhotka
Hi Kent, thanks for the thorough review, see my responses inline. Kent Watsen writes: > Hi, > > I have read this document and think that is almost ready for > publication. I have five discuss items and a bunch of nits. > > Kent // contributor > > > 1. From Section 4: > >

Re: [netmod] WG Last Call: draft-ietf-netmod-schema-mount-07

2017-11-03 Thread Ladislav Lhotka
Hi Andy, thanks for the comments, see inline. Andy Bierman writes: > Hi, > > I have read this draft a few times. > I have not implemented the draft but it seems reasonably constrained. > > here are some comments. > > Sec 1: seems like a lot of background on YANG and then

Re: [netmod] WG Last Call: draft-ietf-netmod-acl-model-14

2017-11-03 Thread Mahesh Jethanandani
Please do, and we can discuss the changes on the mailing list. Thanks. Mahesh Jethanandani mjethanand...@gmail.com > On Nov 3, 2017, at 2:22 PM, Kristian Larsson wrote: > >> On Thu, Nov 02, 2017 at 07:10:30PM +0630, Mahesh Jethanandani wrote: >> Ok. Will update the

Re: [netmod] WG Last Call: draft-ietf-netmod-acl-model-14

2017-11-03 Thread Robert Wilton
On 03/11/2017 10:12, Kristian Larsson wrote: On Fri, Nov 03, 2017 at 09:30:01AM +, Robert Wilton wrote: On 03/11/2017 08:42, Kristian Larsson wrote: On Thu, Nov 02, 2017 at 05:38:02PM +, Robert Wilton wrote: On 02/11/2017 16:41, Kristian Larsson wrote: Are we seeking to have a

Re: [netmod] revised-datastores and commonality of schemas

2017-11-03 Thread Robert Wilton
I agree. I think that a configuration template is just another form of configuration, and hence would expect that the template itself appear in candidate, startup, running, intended, operational. There could also be "system templates" that are not directly configurable, and do not appear in

Re: [netmod] WG Last Call: draft-ietf-netmod-acl-model-14

2017-11-03 Thread Robert Wilton
On 03/11/2017 08:42, Kristian Larsson wrote: On Thu, Nov 02, 2017 at 05:38:02PM +, Robert Wilton wrote: On 02/11/2017 16:41, Kristian Larsson wrote: On Thu, Nov 02, 2017 at 12:53:29PM +, Robert Wilton wrote: feature mixed-ipv4-acl { if-feature "match-on-l2-eth-hdr and

Re: [netmod] WG Last Call: draft-ietf-netmod-acl-model-14 - acl-type in list key?

2017-11-03 Thread Kristian Larsson
Another question somewhat related to attachment point. Why is acl-type part of the list key? I think compound keys are really quite clunky and should be avoided if possible. In this case I really don't see why acl-type needs to be part of the list key. For the list of ACLs it means that the

Re: [netmod] WG Last Call: draft-ietf-netmod-acl-model-14

2017-11-03 Thread Kristian Larsson
On Thu, Nov 02, 2017 at 07:10:30PM +0630, Mahesh Jethanandani wrote: > Ok. Will update the model to reflect the discussion on this thread. Mahesh, would it be helpful if I prepared changes in the form of pull requests on the github repo? I can write code, we can discuss it here and merge once

Re: [netmod] WG Last Call: draft-ietf-netmod-acl-model-14

2017-11-03 Thread Kristian Larsson
On Thu, Nov 02, 2017 at 03:20:34PM +0630, Mahesh Jethanandani wrote: > Kristian, > > I hear you. What I am providing is the rational for the current design. Ok, thank you! That is valuable to me so please don't stop :) > I would like to hear from others in the WG. We have been > reviewing

Re: [netmod] WG Last Call: draft-ietf-netmod-acl-model-14

2017-11-03 Thread Kristian Larsson
On Thu, Nov 02, 2017 at 05:38:02PM +, Robert Wilton wrote: > > > On 02/11/2017 16:41, Kristian Larsson wrote: > >On Thu, Nov 02, 2017 at 12:53:29PM +, Robert Wilton wrote: > >> feature mixed-ipv4-acl { > >> if-feature "match-on-l2-eth-hdr and "match-on-ipv4-hdr"; > >>