Re: [netmod] [yang-doctors] Yangdoctors last call review of draft-ietf-netmod-nmda-diff-04

2020-09-25 Thread Alexander Clemm
Thanks, Reshad and Yingzhen! --- Alex From: netmod On Behalf Of Reshad Rahman (rrahman) Sent: Friday, September 25, 2020 9:42 AM To: Yingzhen Qu ; Alexander L Clemm ; yang-doct...@ietf.org Cc: last-c...@ietf.org; draft-ietf-netmod-nmda-diff@ietf.org; netmod@ietf.org Subject: Re: [netmod]

Re: [netmod] ?= ?==?utf-8?q? Augment with a when and an actio

2020-09-25 Thread Kent Watsen
Hi Michal, > Now, I believe there is some reason why "when" is forbidden for an "action" > although I do not know what it is. Note that Martin supports, and a room full of YANG-next-ers agreed to put it in the "Definitely Dos (MUST Solve)" category.

Re: [netmod] [yang-doctors] Yangdoctors last call review of draft-ietf-netmod-nmda-diff-04

2020-09-25 Thread Reshad Rahman (rrahman)
Looks good, no new issues. Regards, Reshad. From: Yingzhen Qu Date: Friday, September 25, 2020 at 11:49 AM To: "Reshad Rahman (rrahman)" , Alexander L Clemm , "yang-doct...@ietf.org" Cc: "last-c...@ietf.org" , "netmod@ietf.org" , "draft-ietf-netmod-nmda-diff@ietf.org" Subject: Re:

Re: [netmod] [yang-doctors] Yangdoctors last call review of draft-ietf-netmod-nmda-diff-04

2020-09-25 Thread Yingzhen Qu
Hi Reshad, Thanks for the link to verify JSON, it’s very helpful. I’ve uploaded version -07. Please let me know if you have any comments. Thanks, Yingzhen From: "Reshad Rahman (rrahman)" Date: Friday, September 25, 2020 at 8:34 AM To: Yingzhen Qu , Alexander L Clemm , "yang-doct...@ietf.org"

[netmod] I-D Action: draft-ietf-netmod-nmda-diff-07.txt

2020-09-25 Thread internet-drafts
A New Internet-Draft is available from the on-line Internet-Drafts directories. This draft is a work item of the Network Modeling WG of the IETF. Title : Comparison of NMDA datastores Authors : Alexander Clemm Yingzhen Qu

Re: [netmod] [yang-doctors] Yangdoctors last call review of draft-ietf-netmod-nmda-diff-04

2020-09-25 Thread Reshad Rahman (rrahman)
Hi Yingzhen, The JSON example doesn’t seem ok because it only contains 1 edit entry. To confirm I went to https://jsonlint.com/ and it 1st complained about missing comma after the } for source-value and when I fixed that it complained about Duplicate key ‘edit-id’. FYI, the JSON block below

Re: [netmod] [yang-doctors] Yangdoctors last call review of draft-ietf-netmod-nmda-diff-04

2020-09-25 Thread Yingzhen Qu
Hi Reshad, Thank you for the example. I modified the XML example as you suggested. The JSON example looks ok to me. Also fixed the nit to reference RFC 6991. New generated txt file attached, please let me know if you see more issues. Thanks, Yingzhen From: "Reshad Rahman (rrahman)" Date:

Re: [netmod] [yang-doctors] Yangdoctors last call review of draft-ietf-netmod-nmda-diff-04

2020-09-25 Thread Reshad Rahman (rrahman)
Hi Yingzhen, Yes I believe this part is broken, since you have multiple edit-id elements for 1 edit element, below is the YANG snippet from RFC8072. list edit { key edit-id; ordered-by user; leaf edit-id { type string;

Re: [netmod] ?= Augment with a when and an actio

2020-09-25 Thread tom petch
From: Michal Vaško Sent: 25 September 2020 12:18 On Friday, September 25, 2020 12:57 CEST, tom petch wrote: > From: netmod on behalf of Michal Vaško > > Sent: 25 September 2020 11:18 > > Hi, > since no one replied am I to understand this is an unforeseen use-case? In > that case there

Re: [netmod] ?==?utf-8?q? ?==?utf-8?q? ?= Augment with a when and an actio

2020-09-25 Thread Michal Vaško
On Friday, September 25, 2020 12:57 CEST, tom petch wrote: > From: netmod on behalf of Michal Vaško > > Sent: 25 September 2020 11:18 > > Hi, > since no one replied am I to understand this is an unforeseen use-case? In > that case there could at least be an agreement on what the behavior

Re: [netmod] ?==?utf-8?q? Augment with a when and an action

2020-09-25 Thread tom petch
From: netmod on behalf of Michal Vaško Sent: 25 September 2020 11:18 Hi, since no one replied am I to understand this is an unforeseen use-case? In that case there could at least be an agreement on what the behavior should be because I want to know what to implement in our tools. As it

Re: [netmod] ?==?utf-8?q? Augment with a when and an action

2020-09-25 Thread Michal Vaško
Hi, since no one replied am I to understand this is an unforeseen use-case? In that case there could at least be an agreement on what the behavior should be because I want to know what to implement in our tools. Maybe at least warn about an unsupported use-case and ignore the "when" with