On Wed, Nov 27, 2019 at 06:35:24AM -0800, Carl Moberg via Datatracker wrote:
> Reviewer: Carl Moberg
> Review result: Ready with Nits
> 
> This is my YANG doctors review of the ietf-factory-default.yang module as
> part of draft-ietf-netmod-factory-default-07.
> 
> The module cleanly passes validation using the YANG validator site and
> I have successfully loaded it into one NETCONF server implementation.
> 
> This module is ready with a cosmetic nit and a suggestion.
> 
> I suggest fixing the following textual nit:
> 
> OLD
>        configuration datastores (i.e.,<running> , <startup><candidate>) to
>        their factory default content.";
> 
> NEW:
>        configuration datastores (i.e. <running>, <startup>, and
>        <candidate>) to their factory default content.";

FWIW, the RFC style guide wants both comma and space after "i.e." (and
comma before it, as well, when not enclosed in a parenthetical).

-Ben

_______________________________________________
netmod mailing list
netmod@ietf.org
https://www.ietf.org/mailman/listinfo/netmod

Reply via email to