Hi, I've reviewed the draft and found the following issues. * YANG enumeration values are conventionally lowercase, but the delay-mechanism-enumeration and port-state-enumeration types in the draft have uppercase values. * Similarly, hyphens should be used rather than underscores (pre-master instead of PRE_MASTER) * number-ports doesn't read naturally in English; I suggest renaming it to number-of-ports. * The description of port-ds-list contains a typo - "memer" instead of "member". * There's no need to have groupings that are only used once (such as parent-ds-entry, current-ds-entry, default-ds-entry, transparent-clock-default-ds-entry, port-ds-entry, transparent-clock-default-ds-entry, and so on) unless this is for futureproofing or some other reason I'm not aware of. * Is it necessary to include -ds in the name of every leaf, container and grouping?
Note I'm not familiar with IEEE 1588, apart from a brief look through it just now. Alex ________________________________________ From: netmod <netmod-boun...@ietf.org> on behalf of Jiangyuanlong <jiangyuanl...@huawei.com> Sent: Friday, 15 September 2017 1:42 p.m. To: netmod@ietf.org Cc: tic...@ietf.org Subject: [netmod] FW: WGLC for draft-ietf-tictoc-1588v2-yang Hi netmoders, This draft does not tackle the general YANG problem, but provide a generic time synchronization module of 1588. Some of you may have interests in time synchronization, some definitely not. But as experts in YANG, could you please have a review of this YANG module and give an expert opinion? Thanks, Yuanlong -----Original Message----- From: TICTOC [mailto:tictoc-boun...@ietf.org] On Behalf Of Karen O'Donoghue Sent: Thursday, September 14, 2017 3:16 AM To: tic...@ietf.org Cc: n...@ietf.org Subject: [TICTOC] WGLC for draft-ietf-tictoc-1588v2-yang Folks, This message begins a 2 week working group last call (WGLC) for the following document: YANG Data Model for IEEE 1588v2 https://datatracker.ietf.org/doc/draft-ietf-tictoc-1588v2-yang/ Please review the referenced document and send any comments to the mailing list including your assessment of whether this document is mature enough to proceed to the IESG. Please note that these messages of support for progression to the mailing list are important and will be used to determine WG consensus to proceed. Please send all comments in by Thursday 28 September 2017. Thank you! Karen _______________________________________________ TICTOC mailing list tic...@ietf.org https://www.ietf.org/mailman/listinfo/tictoc _______________________________________________ netmod mailing list netmod@ietf.org https://www.ietf.org/mailman/listinfo/netmod _______________________________________________ netmod mailing list netmod@ietf.org https://www.ietf.org/mailman/listinfo/netmod
