Re: [netmod] ACL draft issues found during shepherd writeup

2018-02-27 Thread Mahesh Jethanandani
Guys, Before we start proposing whole set of changes, please verify that the model is not doing what it was supposed to. The only difference between the changes below and what is in the model is that instead of it being a repeat for source and destination ports, the code below exists as a

Re: [netmod] ACL draft issues found during shepherd writeup

2018-02-27 Thread Einar Nilsen-Nygaard (einarnn)
What Kristian and I discussed, what Sonal and I had discussed, and what I thought we had accepted as a proposed change was something like: choice source-port-range-or-operator { case range { leaf source-port-lower { type inet:port-number; must ". <=

Re: [netmod] ACL draft issues found during shepherd writeup

2018-02-27 Thread Eliot Lear
This edit doesn't seem correct to me because now we have a choice with a single case, with range having been removed.  Can we please revert and proceed? On 26.02.18 20:24, Mahesh Jethanandani wrote: > A pull request to address LC, shepherd, this and the other comments, > including

Re: [netmod] ACL draft issues found during shepherd writeup

2018-02-26 Thread Joe Clarke
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2/26/18 03:15, Eliot Lear wrote: > > > On 26.02.18 06:55, Mahesh Jethanandani wrote: >>> PS: And this is not a shepherd directive, but I found the whole "source-port-range-or-operator" syntax clumsy. I'm surprised it

Re: [netmod] ACL draft issues found during shepherd writeup

2018-02-26 Thread Mahesh Jethanandani
A pull request to address LC, shepherd, this and the other comments, including derived-from(), can be reviewed here: https://github.com/netmod-wg/acl-model/pull/24 Thanks. > On Feb 26, 2018, at 12:15 AM, Eliot Lear wrote: > >

Re: [netmod] ACL draft issues found during shepherd writeup

2018-02-26 Thread Eliot Lear
On 26.02.18 06:55, Mahesh Jethanandani wrote: >> >>> >>> >>>  PS: And this is not a shepherd directive, but I found the whole  >>>  "source-port-range-or-operator" syntax clumsy.  I'm surprised >>>  it didn't look something like: >>> >>>  OLD >>>     >>>   

Re: [netmod] ACL draft issues found during shepherd writeup

2018-02-25 Thread Mahesh Jethanandani
> On Feb 23, 2018, at 12:12 PM, Kent Watsen wrote: > > Hi Mahesh, > > Please search for below (6 instances) > > Thanks, > Kent // shepherd > > > On 2/17/18, 8:26 PM, "Mahesh Jethanandani" > wrote: > >

Re: [netmod] ACL draft issues found during shepherd writeup

2018-02-23 Thread Kent Watsen
Hi Mahesh, Please search for below (6 instances) Thanks, Kent // shepherd On 2/17/18, 8:26 PM, "Mahesh Jethanandani" > wrote: Kent, Thanks for a detailed review. See inline. On Feb 13, 2018, at 2:30 PM, Kent Watsen

Re: [netmod] ACL draft issues found during shepherd writeup

2018-02-19 Thread Eliot Lear
On 18.02.18 02:26, Mahesh Jethanandani wrote: > Kent, > > Thanks for a detailed review. See inline. > >> On Feb 13, 2018, at 2:30 PM, Kent Watsen > > wrote: >> >> [sorry, wrong WG, moving netconf to BCC!] >> >> >> ACL Authors, >> >> Below are

Re: [netmod] ACL draft issues found during shepherd writeup

2018-02-17 Thread Mahesh Jethanandani
Kent, Thanks for a detailed review. See inline. > On Feb 13, 2018, at 2:30 PM, Kent Watsen wrote: > > [sorry, wrong WG, moving netconf to BCC!] > > > ACL Authors, > > Below are some issues I found while looking at doing the Shepherd > write-up today. Please take a

[netmod] ACL draft issues found during shepherd writeup

2018-02-13 Thread Kent Watsen
[sorry, wrong WG, moving netconf to BCC!] ACL Authors, Below are some issues I found while looking at doing the Shepherd write-up today. Please take a look. Also, with regards to the request for those having Last Call comments to please verify that their comments were addressed, I only saw