[netsniff-ng] [PATCH] netsniff-ng: Seems typo in getting current group id

From: Vadim Kochan vadi...@gmail.com Changed to use ctx-gid when call getgid() on init_ctx. Signed-off-by: Vadim Kochan vadi...@gmail.com --- netsniff-ng.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/netsniff-ng.c b/netsniff-ng.c index c0d70c8..4ad8b19 100644 ---

[netsniff-ng] [PATCH] iosched: Print error cause if setting io prio failed

From: Vadim Kochan vadi...@gmail.com Add error cause message when ioprio_setpid fails. Signed-off-by: Vadim Kochan vadi...@gmail.com --- iosched.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/iosched.c b/iosched.c index 7417973..ff82126 100644 --- a/iosched.c +++

Re: [netsniff-ng] [PATCH] iosched: Print error cause if setting io prio failed

On 2015-04-22 at 16:07:29 +0200, Vadim Kochan vadi...@gmail.com wrote: From: Vadim Kochan vadi...@gmail.com Add error cause message when ioprio_setpid fails. Signed-off-by: Vadim Kochan vadi...@gmail.com Applied, thanks! -- You received this message because you are subscribed to the

Re: [netsniff-ng] netsniff-ng: Do we need to set IO prio when do only read from pcap ?

On Wed, Apr 22, 2015 at 05:02:52PM +0200, Daniel Borkmann wrote: On 04/22/2015 05:00 PM, Vadim Kochan wrote: Hi, It is not possible to just read pcap by netsniff-ng if user permissions does not allow to set processes IO prio, so it is really needed to do it just for print pcap file ?

Re: [netsniff-ng] netsniff-ng: Do we need to set IO prio when do only read from pcap ?

On 04/22/2015 05:09 PM, Vadim Kochan wrote: ... Sure, I will try to fix it, really I dont have a fix yet. The issue goes from pcap ops in init one function, where IO prio is set, the first think which came up in my mind is to have separate pcap ops for read only where set IO prio will be not

[netsniff-ng] netsniff-ng: Do we need to set IO prio when do only read from pcap ?

Hi, It is not possible to just read pcap by netsniff-ng if user permissions does not allow to set processes IO prio, so it is really needed to do it just for print pcap file ? Thanks, Vadim Kochan -- You received this message because you are subscribed to the Google Groups netsniff-ng group.

Re: [netsniff-ng] netsniff-ng: Do we need to set IO prio when do only read from pcap ?

On Wed, Apr 22, 2015 at 05:37:42PM +0200, Daniel Borkmann wrote: On 04/22/2015 05:09 PM, Vadim Kochan wrote: ... Sure, I will try to fix it, really I dont have a fix yet. The issue goes from pcap ops in init one function, where IO prio is set, the first think which came up in my mind is to

Re: [netsniff-ng] [PATCH] netsniff-ng: Dont set IO prio when reading pcap file

On 04/22/2015 06:26 PM, Vadim Kochan wrote: From: Vadim Kochan vadi...@gmail.com It allows to read pcap file for users who have no permissions to set process IO prio. Signed-off-by: Vadim Kochan vadi...@gmail.com I'm okay with that, read_pcap() is slow-path anyway. Thanks -- You received

Re: [netsniff-ng] [PATCH] netsniff-ng: Dont set IO prio when reading pcap file

On 2015-04-22 at 18:26:11 +0200, Vadim Kochan vadi...@gmail.com wrote: From: Vadim Kochan vadi...@gmail.com It allows to read pcap file for users who have no permissions to set process IO prio. Signed-off-by: Vadim Kochan vadi...@gmail.com Applied with Daniel's Acked-by. Thanks a lot

[netsniff-ng] netsniff-ng: mac80211: Better print layout for HT Capabilities element ?

Hi, I think that HT Capabilities element info should be showed in more structured view so it will be more readable what do you think ? Does someone have a better option ? Current --- [ Radiotap Version (0), Length (26), Flags (0x482f) ] [ 802.11 Frame Control (0x0040)] [ Proto

Re: [netsniff-ng] netsniff-ng: mac80211: Better print layout for HT Capabilities element ?

On 04/22/2015 11:50 PM, Vadim Kochan wrote: ... I think that HT Capabilities element info should be showed in more structured view so it will be more readable what do you think ? Does someone have a better option ? Yes, I'm fine with that. -- You received this message because you are