Re: [netsniff-ng] [PATCH 01/15] trafgen: Move applying dynamic elements to function

On 2016-07-26 at 21:35:06 +0200, Vadim Kochan wrote: > Same code for applying dynamic elements is used in both places > for slow & fast path modes, lets move them into one inlined function. > > Signed-off-by: Vadim Kochan Applied, thanks. -- You received

Re: [netsniff-ng] Re: [PATCH 00/15] trafgen: Support dinc & drnd for proto fields

Nice work Vadim! This looks good from a bird's-eye view, but due to the size of the changes it will probably take me some time to review it completely and give you feedback (with the exception of patch 1/15 which is a no-brainer and I already applied it). On 2016-07-27 at 13:04:45 +0200, Vadim

[netsniff-ng] Re: [PATCH 00/15] trafgen: Support dinc & drnd for proto fields

I really missed one thing related to csum - so if I have proto field with dynamic function then csum will be calculated minimum twice - after packet is build and after all dynamic fields are applied, well I have no particular solution for this, but let me know if you want to have it fixed in this