[netsniff-ng] Re: [PATCH] flowtop: Fix use-after-free on filter reload

2018-01-02 Thread Tobias Klauser
On 2017-12-29 at 10:17:09 +0100, Vadim Kochan wrote: > On Tue, Dec 19, 2017 at 12:30 PM, Tobias Klauser > wrote: > > > On 2017-12-19 at 11:24:40 +0100, Vadim Kochan wrote: > > > May it possible that you tried flowtop compiled without

[netsniff-ng] Re: [PATCH] flowtop: Fix use-after-free on filter reload

2017-12-29 Thread Vadim Kochan
On Tue, Dec 19, 2017 at 12:30 PM, Tobias Klauser wrote: > On 2017-12-19 at 11:24:40 +0100, Vadim Kochan wrote: > > May it possible that you tried flowtop compiled without the fix ? > > No, I made sure to have the patch applied and recompiled flowtop. I

[netsniff-ng] Re: [PATCH] flowtop: Fix use-after-free on filter reload

2017-12-19 Thread Tobias Klauser
On 2017-12-19 at 11:24:40 +0100, Vadim Kochan wrote: > May it possible that you tried flowtop compiled without the fix ? No, I made sure to have the patch applied and recompiled flowtop. I can still quite reliably reproduce the issue and flowtop sometimes even segfaults on

[netsniff-ng] Re: [PATCH] flowtop: Fix use-after-free on filter reload

2017-12-19 Thread Vadim Kochan
May it possible that you tried flowtop compiled without the fix ? On Tue, Dec 19, 2017 at 12:18 PM, Vadim Kochan wrote: > Thats really strange, because before this patch I really easy triggered > the issue, but > now I cant. > > On Tue, Dec 19, 2017 at 11:12 AM, Tobias

[netsniff-ng] Re: [PATCH] flowtop: Fix use-after-free on filter reload

2017-12-19 Thread Vadim Kochan
Thats really strange, because before this patch I really easy triggered the issue, but now I cant. On Tue, Dec 19, 2017 at 11:12 AM, Tobias Klauser wrote: > On 2017-12-18 at 23:38:18 +0100, Vadim Kochan wrote: > > There is missing logic which removes

[netsniff-ng] Re: [PATCH] flowtop: Fix use-after-free on filter reload

2017-12-19 Thread Tobias Klauser
On 2017-12-18 at 23:38:18 +0100, Vadim Kochan wrote: > There is missing logic which removes flown entry from > related proc's entry while destroying global flows list on > filter reloading, hence add common __flow_list_del_entry which > handles this logic for both cases - when