[netsniff-ng] Re: [PATCH] flowtop: Fix use-after-free on filter reload

2018-01-02 Thread Tobias Klauser
On 2017-12-29 at 10:17:09 +0100, Vadim Kochan  wrote:
> On Tue, Dec 19, 2017 at 12:30 PM, Tobias Klauser 
> wrote:
> 
> > On 2017-12-19 at 11:24:40 +0100, Vadim Kochan  wrote:
> > > May it possible that you tried flowtop compiled without the fix ?
> >
> > No, I made sure to have the patch applied and recompiled flowtop. I can
> > still quite reliably reproduce the issue and flowtop sometimes even
> > segfaults on startup before displaying anything.
> >
> > > On Tue, Dec 19, 2017 at 12:18 PM, Vadim Kochan 
> > wrote:
> > >
> > > > Thats really strange, because before this patch I really easy triggered
> > > > the issue, but
> > > > now I cant.
> > > >
> > > > On Tue, Dec 19, 2017 at 11:12 AM, Tobias Klauser 
> > > > wrote:
> > > >
> > > >> On 2017-12-18 at 23:38:18 +0100, Vadim Kochan 
> > wrote:
> > > >> > There is missing logic which removes flown entry from
> > > >> > related proc's entry while destroying global flows list on
> > > >> > filter reloading, hence add common __flow_list_del_entry which
> > > >> > handles this logic for both cases - when ct destroyed or filter
> > > >> > changed.
> > > >> >
> > > >> > This is a 2nd fix for issue #183.
> > > >>
> > > >> Thanks for the patch. While it is certainly correct, it unfortunately
> > > >> still doesn't fix #183 properly. I can still trigger a segfault by
> > > >> repeatedly enabling/disabling TCP, UDP and ICMP flows ('T', 'U' or 'I'
> > > >> key).
> > > >>
> > > >
> > > >
> >
> 
> Hi Tobias,
> 
> Looks like https://github.com/netsniff-ng/netsniff-ng/issues/183
> is not reproducible, do you still see issues with flowtop ?

The issue is still reproducible for me on latest master. Unfortunately
not in gdb though.

But since the bug does appear to occur less often (at least you and the
original reporter can no longer reproduce), I think we should still go
ahead with the release.

Thanks
Tobias

-- 
You received this message because you are subscribed to the Google Groups 
"netsniff-ng" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to netsniff-ng+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[netsniff-ng] Re: [PATCH] flowtop: Fix use-after-free on filter reload

2017-12-29 Thread Vadim Kochan
On Tue, Dec 19, 2017 at 12:30 PM, Tobias Klauser 
wrote:

> On 2017-12-19 at 11:24:40 +0100, Vadim Kochan  wrote:
> > May it possible that you tried flowtop compiled without the fix ?
>
> No, I made sure to have the patch applied and recompiled flowtop. I can
> still quite reliably reproduce the issue and flowtop sometimes even
> segfaults on startup before displaying anything.
>
> > On Tue, Dec 19, 2017 at 12:18 PM, Vadim Kochan 
> wrote:
> >
> > > Thats really strange, because before this patch I really easy triggered
> > > the issue, but
> > > now I cant.
> > >
> > > On Tue, Dec 19, 2017 at 11:12 AM, Tobias Klauser 
> > > wrote:
> > >
> > >> On 2017-12-18 at 23:38:18 +0100, Vadim Kochan 
> wrote:
> > >> > There is missing logic which removes flown entry from
> > >> > related proc's entry while destroying global flows list on
> > >> > filter reloading, hence add common __flow_list_del_entry which
> > >> > handles this logic for both cases - when ct destroyed or filter
> > >> > changed.
> > >> >
> > >> > This is a 2nd fix for issue #183.
> > >>
> > >> Thanks for the patch. While it is certainly correct, it unfortunately
> > >> still doesn't fix #183 properly. I can still trigger a segfault by
> > >> repeatedly enabling/disabling TCP, UDP and ICMP flows ('T', 'U' or 'I'
> > >> key).
> > >>
> > >
> > >
>

Hi Tobias,

Looks like https://github.com/netsniff-ng/netsniff-ng/issues/183
is not reproducible, do you still see issues with flowtop ?

Regards,
Vadim Kochan

-- 
You received this message because you are subscribed to the Google Groups 
"netsniff-ng" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to netsniff-ng+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[netsniff-ng] Re: [PATCH] flowtop: Fix use-after-free on filter reload

2017-12-19 Thread Tobias Klauser
On 2017-12-19 at 11:24:40 +0100, Vadim Kochan  wrote:
> May it possible that you tried flowtop compiled without the fix ?

No, I made sure to have the patch applied and recompiled flowtop. I can
still quite reliably reproduce the issue and flowtop sometimes even
segfaults on startup before displaying anything.

> On Tue, Dec 19, 2017 at 12:18 PM, Vadim Kochan  wrote:
> 
> > Thats really strange, because before this patch I really easy triggered
> > the issue, but
> > now I cant.
> >
> > On Tue, Dec 19, 2017 at 11:12 AM, Tobias Klauser 
> > wrote:
> >
> >> On 2017-12-18 at 23:38:18 +0100, Vadim Kochan  wrote:
> >> > There is missing logic which removes flown entry from
> >> > related proc's entry while destroying global flows list on
> >> > filter reloading, hence add common __flow_list_del_entry which
> >> > handles this logic for both cases - when ct destroyed or filter
> >> > changed.
> >> >
> >> > This is a 2nd fix for issue #183.
> >>
> >> Thanks for the patch. While it is certainly correct, it unfortunately
> >> still doesn't fix #183 properly. I can still trigger a segfault by
> >> repeatedly enabling/disabling TCP, UDP and ICMP flows ('T', 'U' or 'I'
> >> key).
> >>
> >
> >

-- 
You received this message because you are subscribed to the Google Groups 
"netsniff-ng" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to netsniff-ng+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[netsniff-ng] Re: [PATCH] flowtop: Fix use-after-free on filter reload

2017-12-19 Thread Vadim Kochan
May it possible that you tried flowtop compiled without the fix ?

On Tue, Dec 19, 2017 at 12:18 PM, Vadim Kochan  wrote:

> Thats really strange, because before this patch I really easy triggered
> the issue, but
> now I cant.
>
> On Tue, Dec 19, 2017 at 11:12 AM, Tobias Klauser 
> wrote:
>
>> On 2017-12-18 at 23:38:18 +0100, Vadim Kochan  wrote:
>> > There is missing logic which removes flown entry from
>> > related proc's entry while destroying global flows list on
>> > filter reloading, hence add common __flow_list_del_entry which
>> > handles this logic for both cases - when ct destroyed or filter
>> > changed.
>> >
>> > This is a 2nd fix for issue #183.
>>
>> Thanks for the patch. While it is certainly correct, it unfortunately
>> still doesn't fix #183 properly. I can still trigger a segfault by
>> repeatedly enabling/disabling TCP, UDP and ICMP flows ('T', 'U' or 'I'
>> key).
>>
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"netsniff-ng" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to netsniff-ng+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[netsniff-ng] Re: [PATCH] flowtop: Fix use-after-free on filter reload

2017-12-19 Thread Vadim Kochan
Thats really strange, because before this patch I really easy triggered the
issue, but
now I cant.

On Tue, Dec 19, 2017 at 11:12 AM, Tobias Klauser 
wrote:

> On 2017-12-18 at 23:38:18 +0100, Vadim Kochan  wrote:
> > There is missing logic which removes flown entry from
> > related proc's entry while destroying global flows list on
> > filter reloading, hence add common __flow_list_del_entry which
> > handles this logic for both cases - when ct destroyed or filter
> > changed.
> >
> > This is a 2nd fix for issue #183.
>
> Thanks for the patch. While it is certainly correct, it unfortunately
> still doesn't fix #183 properly. I can still trigger a segfault by
> repeatedly enabling/disabling TCP, UDP and ICMP flows ('T', 'U' or 'I'
> key).
>

-- 
You received this message because you are subscribed to the Google Groups 
"netsniff-ng" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to netsniff-ng+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[netsniff-ng] Re: [PATCH] flowtop: Fix use-after-free on filter reload

2017-12-19 Thread Tobias Klauser
On 2017-12-18 at 23:38:18 +0100, Vadim Kochan  wrote:
> There is missing logic which removes flown entry from
> related proc's entry while destroying global flows list on
> filter reloading, hence add common __flow_list_del_entry which
> handles this logic for both cases - when ct destroyed or filter
> changed.
> 
> This is a 2nd fix for issue #183.

Thanks for the patch. While it is certainly correct, it unfortunately
still doesn't fix #183 properly. I can still trigger a segfault by
repeatedly enabling/disabling TCP, UDP and ICMP flows ('T', 'U' or 'I'
key).

-- 
You received this message because you are subscribed to the Google Groups 
"netsniff-ng" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to netsniff-ng+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.