[netsniff-ng] Re: [PATCH] flowtop: Replace single linked list by list_head from list.h

2017-01-13 Thread Vadim Kochan
On Thu, Jan 12, 2017 at 5:20 PM, Tobias Klauser wrote: > On 2017-01-12 at 15:54:31 +0100, Vadim Kochan wrote: >> On Thu, Jan 12, 2017 at 4:28 PM, Tobias Klauser wrote: > [...] >> >> enum flow_direction { >> >> @@ -355,15 +357,15 @@

[netsniff-ng] Re: [PATCH] flowtop: Replace single linked list by list_head from list.h

2017-01-12 Thread Tobias Klauser
On 2017-01-12 at 15:54:31 +0100, Vadim Kochan wrote: > On Thu, Jan 12, 2017 at 4:28 PM, Tobias Klauser wrote: [...] > >> enum flow_direction { > >> @@ -355,15 +357,15 @@ static inline struct flow_entry > >> *flow_entry_xalloc(void) > >> static inline

[netsniff-ng] Re: [PATCH] flowtop: Replace single linked list by list_head from list.h

2017-01-12 Thread Vadim Kochan
On Thu, Jan 12, 2017 at 4:28 PM, Tobias Klauser wrote: > Thanks for the patch and sorry for the delay in reply. > > I'm not too familiar with the RCU list interface, but from a quick > glance this looks OK in general. A few remarks below. > > Daniel, if you have time could

[netsniff-ng] Re: [PATCH] flowtop: Replace single linked list by list_head from list.h

2017-01-12 Thread Tobias Klauser
Thanks for the patch and sorry for the delay in reply. I'm not too familiar with the RCU list interface, but from a quick glance this looks OK in general. A few remarks below. Daniel, if you have time could you maybe have a quick look? On 2017-01-09 at 07:26:07 +0100, Vadim Kochan