[netsniff-ng] Re: [RFC 4/7] trafgen: parser: Use proto_field_set_xxx where it is possible
On 2017-01-30 at 09:33:27 +0100, Vadim Kochan wrote: > Use proto_field_set_xxx(field, ...) instead of > proto_hdr_field_set_xxx(hdr, fid, ...) to be more generic and do not > depent on 'hdr' variable. > > Signed-off-by: Vadim Kochan This does not strictly need to be part of this series but the patch in itself makes sense. Care to resend it separately based on master? -- You received this message because you are subscribed to the Google Groups "netsniff-ng" group. To unsubscribe from this group and stop receiving emails from it, send an email to netsniff-ng+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[netsniff-ng] Re: [RFC 4/7] trafgen: parser: Use proto_field_set_xxx where it is possible
On Mon, Feb 13, 2017 at 11:18 AM, Tobias Klauser wrote: > On 2017-01-30 at 09:33:27 +0100, Vadim Kochan wrote: >> Use proto_field_set_xxx(field, ...) instead of >> proto_hdr_field_set_xxx(hdr, fid, ...) to be more generic and do not >> depent on 'hdr' variable. >> >> Signed-off-by: Vadim Kochan > > This does not strictly need to be part of this series but the patch in > itself makes sense. Care to resend it separately based on master? Hm, it has some dependencies from previous patches in this series so, may be I will send it after the series will be appliead, at least the parser's part. -- You received this message because you are subscribed to the Google Groups "netsniff-ng" group. To unsubscribe from this group and stop receiving emails from it, send an email to netsniff-ng+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[netsniff-ng] Re: [RFC 4/7] trafgen: parser: Use proto_field_set_xxx where it is possible
On 2017-02-13 at 12:27:14 +0100, Vadim Kochan wrote: > On Mon, Feb 13, 2017 at 11:18 AM, Tobias Klauser wrote: > > On 2017-01-30 at 09:33:27 +0100, Vadim Kochan wrote: > >> Use proto_field_set_xxx(field, ...) instead of > >> proto_hdr_field_set_xxx(hdr, fid, ...) to be more generic and do not > >> depent on 'hdr' variable. > >> > >> Signed-off-by: Vadim Kochan > > > > This does not strictly need to be part of this series but the patch in > > itself makes sense. Care to resend it separately based on master? > > Hm, it has some dependencies from previous patches in this series so, > may be I will send it after > the series will be appliead, at least the parser's part. Ok, whatever you prefer. I'd just like to see it split out of the series as it is not strictly related to it. -- You received this message because you are subscribed to the Google Groups "netsniff-ng" group. To unsubscribe from this group and stop receiving emails from it, send an email to netsniff-ng+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
