Re: [PATCH v2 0/6] Add meta interface for MAC algorithms

2019-07-22 Thread Dmitry Eremin-Solenikov
пн, 22 июл. 2019 г. в 11:54, Daiki Ueno : > > From: Daiki Ueno > > The changes from the previous series are: > - remove the global hmac_*_set_key_expanded functions > - leave out set_nonce member if the operation is not supported > > For the latter, I was wondering whether it is better to define

[PATCH v2 4/6] nettle-meta: Add meta interface for UMAC functions

2019-07-22 Thread Daiki Ueno
From: Daiki Ueno Signed-off-by: Daiki Ueno --- Makefile.in| 1 + nettle-meta.h | 17 + umac128-meta.c | 47 +++ umac32-meta.c | 47 +++ umac64-meta.c | 47

[PATCH v2 1/6] nettle-meta: Move struct nettle_mac to nettle-meta.h

2019-07-22 Thread Daiki Ueno
From: Daiki Ueno The struct was defined in testutils.h as the interface was not stable. This generalizes the interface to cover all defined MAC algorithms in nettle. Signed-off-by: Daiki Ueno --- nettle-meta.h | 22 ++ testsuite/testutils.h | 29

[PATCH v2 3/6] nettle-meta: Add meta interface for HMAC functions

2019-07-22 Thread Daiki Ueno
From: Daiki Ueno Signed-off-by: Daiki Ueno --- Makefile.in | 3 +++ hmac-md5-meta.c | 47 +++ hmac-ripemd160-meta.c | 47 +++ hmac-sha1-meta.c | 47 +++

[PATCH v2 2/6] nettle-meta: Add meta interface for CMAC functions

2019-07-22 Thread Daiki Ueno
From: Daiki Ueno Signed-off-by: Daiki Ueno --- Makefile.in | 1 + cmac-aes128-meta.c| 43 +++ cmac-aes256-meta.c| 43 +++ nettle-meta.h | 15 +++ testsuite/cmac-test.c | 24

[PATCH v2 5/6] nettle-meta: Expose all defined MACs through nettle_macs

2019-07-22 Thread Daiki Ueno
From: Daiki Ueno Signed-off-by: Daiki Ueno --- Makefile.in| 2 +- nettle-meta-macs.c | 61 ++ nettle-meta.h | 7 ++ 3 files changed, 69 insertions(+), 1 deletion(-) create mode 100644 nettle-meta-macs.c diff --git a/Makefile.in

[PATCH v2 6/6] tests: Add test for meta interface for MAC algorithms

2019-07-22 Thread Daiki Ueno
From: Daiki Ueno Signed-off-by: Daiki Ueno --- testsuite/.gitignore | 1 + testsuite/.test-rules.make | 3 +++ testsuite/Makefile.in | 2 +- testsuite/meta-mac-test.c | 43 ++ 4 files changed, 48 insertions(+), 1 deletion(-) create mode

[PATCH v2 0/6] Add meta interface for MAC algorithms

2019-07-22 Thread Daiki Ueno
From: Daiki Ueno The changes from the previous series are: - remove the global hmac_*_set_key_expanded functions - leave out set_nonce member if the operation is not supported For the latter, I was wondering whether it is better to define a no-op set_nonce, but given the fact that that the

Re: [PATCH] cmac: add 64-bit mode CMAC

2019-07-22 Thread Niels Möller
ni...@lysator.liu.se (Niels Möller) writes: > I've now merged this and the cmac_des3 patch onto a branch "cmac64". And now pushed to master, together with the documentation update. Thanks, /Niels -- Niels Möller. PGP-encrypted email is preferred. Keyid 368C6677. Internet email is subject to