Re: Fwd: [PowerPC] GCM optimization

2020-11-30 Thread George Wilson
On Thu, Nov 12, 2020 at 07:45:14PM +0200, Maamoun TK wrote: > -- Forwarded message - > From: Maamoun TK > Date: Thu, Nov 12, 2020 at 7:42 PM > Subject: Re: [PowerPC] GCM optimization > To: Niels Möller > > > On Thu, Nov 12, 2020 at 6:40 PM Niels Möller wrote: > > > I gave it

Re: PPC chacha

2020-11-30 Thread Niels Möller
Maamoun TK writes: > On Mon, Nov 30, 2020 at 11:18 PM Maamoun TK > wrote: > >> on POWER9 I get the following benchmark with ". /configure >> --enable-power-altivec": >> >> chacha encrypt 763.57 >> chacha decrypt 780.64 >> >> regards, >> Mamone >> > > I got this result using

Re: PPC chacha

2020-11-30 Thread Maamoun TK
On Mon, Nov 30, 2020 at 11:18 PM Maamoun TK wrote: > on POWER9 I get the following benchmark with ". /configure > --enable-power-altivec": > > chacha encrypt 763.57 > chacha decrypt 780.64 > > regards, > Mamone > I got this result using ppc-chacha-2core branch on same machine:

Re: PPC chacha

2020-11-30 Thread Maamoun TK
on POWER9 I get the following benchmark with ". /configure --enable-power-altivec": chacha encrypt 763.57 chacha decrypt 780.64 regards, Mamone On Mon, Nov 30, 2020 at 11:08 PM Niels Möller wrote: > Niels Möller writes: > > > Below code seems to work (but is not yet a drop-in

Re: PPC chacha

2020-11-30 Thread Niels Möller
Niels Möller writes: > Below code seems to work (but is not yet a drop-in replacement, since it > needs some wireup in chacha.crypt.c, and 32-bit counter variant and BE > swapping not yet implemented). I fixed these issues, as well as fat build support. Pushed to the branch ppc-chacha-4core.

Re: PPC chacha

2020-11-30 Thread Maamoun TK
On Mon, Nov 30, 2020 at 10:56 PM Niels Möller wrote: > Hmm. I agree just lowering the stack pointer sounds a bit questionable. > But if we use some other register to point into the protected zone, we > should be fine? E.g., > > addir10, r1, -0x40 C Save callee-save registers >

Re: PPC chacha

2020-11-30 Thread Niels Möller
Maamoun TK writes: > I'm thinking what could happen if an exception raised while the stack frame > is modified incorrectly, the exception handler will try to look at the > calling function but it can't get the previous state of stack pointer > because the stack pointer doesn't point to it and

Re: PPC chacha

2020-11-30 Thread Maamoun TK
On Mon, Nov 30, 2020 at 10:07 PM Maamoun TK wrote: > BTW since there is no function called while the register of the stack > frame is modified, I think it's fine to not follow the rules and keep the > store and restore sequences as are without any modification. > I'm thinking what could happen

Re: PPC chacha

2020-11-30 Thread Maamoun TK
On Mon, Nov 30, 2020 at 12:37 PM Niels Möller wrote: > Niels Möller writes: > 1. Does the save and restore of registers look correct? I checked the >abi spec, and the intention is to use the part of the 288 byte >"Protected zone" below the stack pointer. There are requirements should

Re: PPC chacha

2020-11-30 Thread Niels Möller
Niels Möller writes: > 3. Try out if 4-way gives additional speedup. Below code seems to work (but is not yet a drop-in replacement, since it needs some wireup in chacha.crypt.c, and 32-bit counter variant and BE swapping not yet implemented). Seems to give almost a factor of 2 speedup over