Re: [PATCH] cfb8: don't truncate output IV if input is shorter than block size

2019-10-01 Thread Niels Möller
Daiki Ueno writes: >> For testing, I think it would be good to take the testvectors for cfb8, >> and split into multiple calls to cfb8_*crypt, in several ways. And check >> they all give the same result. A bit like it's done in arcfour-test.c, >> or the test_cipher_stream (#if:ed out, not sure

Re: [PATCH] cfb8: don't truncate output IV if input is shorter than block size

2019-10-01 Thread Daiki Ueno
ni...@lysator.liu.se (Niels Möller) writes: > Daiki Ueno writes: > >> We realized that cfb8_decrypt doesn't update the IV correctly when the >> input is shorter than AES block size. The attached patches should fix >> it. > > For testing, I think it would be good to take the testvectors for

Re: [PATCH] cfb8: don't truncate output IV if input is shorter than block size

2019-09-30 Thread Niels Möller
Daiki Ueno writes: > We realized that cfb8_decrypt doesn't update the IV correctly when the > input is shorter than AES block size. The attached patches should fix > it. For testing, I think it would be good to take the testvectors for cfb8, and split into multiple calls to cfb8_*crypt, in

[PATCH] cfb8: don't truncate output IV if input is shorter than block size

2019-09-30 Thread Daiki Ueno
Hello, We realized that cfb8_decrypt doesn't update the IV correctly when the input is shorter than AES block size. The attached patches should fix it. Samba is also affected by this and there are similar fixes: