Re: [RFC] ecc: switch away from affine points representation

2019-12-05 Thread Niels Möller
Dmitry Eremin-Solenikov writes: > Would it be ok to change ecc_point size to become a per curve option? If needed, yes. (I've also been considering switching to using extended X,Y,Z,T coordinates as internal representation for twisted edwards curves, but unclear if it's worth the effort. See th

Re: [RFC] ecc: switch away from affine points representation

2019-12-04 Thread Dmitry Eremin-Solenikov
Hello, чт, 5 дек. 2019 г., 8:15 Niels Möller : > Dmitry Eremin-Solenikov writes: > > > Well, I've had two particular GOST curves in mind. They are defined in > > Weierstrass form, but have birationally equal Edwards curves that can > > be used for point addition. > > And to do that conversion wi

Re: [RFC] ecc: switch away from affine points representation

2019-12-04 Thread Niels Möller
Dmitry Eremin-Solenikov writes: > Well, I've had two particular GOST curves in mind. They are defined in > Weierstrass form, but have birationally equal Edwards curves that can > be used for point addition. And to do that conversion without an expensive modular inversion, you get a Z != 1? It m

Re: [RFC] ecc: switch away from affine points representation

2019-12-04 Thread Dmitry Eremin-Solenikov
Hello, чт, 5 дек. 2019 г. в 00:18, Niels Möller : > > dbarysh...@gmail.com writes: > > > From: Dmitry Eremin-Solenikov > > > > Use jacobian/harmonized representation in ecc_point structure. > > Can you explain what benefit you see from this? Well, I've had two particular GOST curves in mind. The

Re: [RFC] ecc: switch away from affine points representation

2019-12-04 Thread Niels Möller
ni...@lysator.liu.se (Niels Möller) writes: > E.g., ecc_point_mul takes a const struct ecc_point as input, and calls > ecc->mul, which for the standard weierstrass curves is ecc_mul_a. This > one is a loop including a call to ecc_add_jja, which assumes that the z > coordinate is one. Sorry, look

Re: [RFC] ecc: switch away from affine points representation

2019-12-04 Thread Niels Möller
dbarysh...@gmail.com writes: > From: Dmitry Eremin-Solenikov > > Use jacobian/harmonized representation in ecc_point structure. Can you explain what benefit you see from this? E.g., ecc_point_mul takes a const struct ecc_point as input, and calls ecc->mul, which for the standard weierstrass cur

[RFC] ecc: switch away from affine points representation

2019-11-24 Thread dbaryshkov
From: Dmitry Eremin-Solenikov Use jacobian/harmonized representation in ecc_point structure. This is an RFC patch for now, j_to_a/eh_to_a are not modified to produce y coordinate only, more tests are necessary most probably. Signed-off-by: Dmitry Eremin-Solenikov --- ecc-a-to-j.c