Re: [PATCH v3 2/3] ecc: prefix optimized ECC function names with underscore

2020-01-10 Thread Dmitry Eremin-Solenikov
пт, 10 янв. 2020 г. в 23:01, Niels Möller : > > Dmitry Eremin-Solenikov writes: > > > So did I at the time of writing a patch, finding no actual users of > > these functions. I think it is fine to drop them without bumping > > soname. > > It seems none disagrees with that. I've merged all three

Re: [PATCH v3 2/3] ecc: prefix optimized ECC function names with underscore

2020-01-10 Thread Niels Möller
Dmitry Eremin-Solenikov writes: > So did I at the time of writing a patch, finding no actual users of > these functions. I think it is fine to drop them without bumping > soname. It seems none disagrees with that. I've merged all three patches to the master-updates branch for testing. Thanks,

Re: [PATCH v3 2/3] ecc: prefix optimized ECC function names with underscore

2020-01-09 Thread Dmitry Eremin-Solenikov
Hello, вт, 7 янв. 2020 г. в 23:20, Niels Möller : > > dbarysh...@gmail.com writes: > > From: Dmitry Eremin-Solenikov > > > > There is no need to keep optimized ECC functions in public namespace > > (nettle_*), move them to internal namespace (_nettle_*). > > I agree this rename makes sense. > >

Re: [PATCH v3 2/3] ecc: prefix optimized ECC function names with underscore

2020-01-07 Thread Niels Möller
dbarysh...@gmail.com writes: > From: Dmitry Eremin-Solenikov > > There is no need to keep optimized ECC functions in public namespace > (nettle_*), move them to internal namespace (_nettle_*). I agree this rename makes sense. But it could be considered an ABI break, since we remove symbols