Huawei fixes in '06-huawei' branch

2012-10-26 Thread Aleksander Morgado
Hey Dan, Your Huawei fixes in the 06-huawei branch seem to work properly with the E173, so I would merge them. Will hack those changes in git master in the following days. Ubuntu bug: https://bugs.launchpad.net/ubuntu/+source/modemmanager/+bug/1057186 Latest log:

Re: Huawei fixes in '06-huawei' branch

2012-10-26 Thread Aleksander Morgado
Hey Dan, Your Huawei fixes in the 06-huawei branch seem to work properly with the E173, so I would merge them. Will hack those changes in git master in the following days. Ubuntu bug: https://bugs.launchpad.net/ubuntu/+source/modemmanager/+bug/1057186 Latest log:

Re: __attribute__ ((cleanup) patch

2012-10-26 Thread Pavel Simerda
From: Colin Walters walt...@verbum.org So the patch ended up getting reverted, which I'm OK with, Thank you for understanding. I'll also try to reply so that we have a clean technical discussion, separate from my ranting :). but what I still want to know is - what are the hurdles I need to

[PATCH v2 0/7] nm-openconnect: backport gnome-keyring support for NM_0_8 branch

2012-10-26 Thread Murilo Opsfelder Araujo
The following patches are cherry-picks from master branch that I backported and adapted in order to add gnome-keyring support for NM_0_8 branch (will be useful for EPEL 6). Murilo Opsfelder Araujo (7): Use gnome-keyring for password fields (cherry picked from commit

[PATCH v2 3/7] Only store passwords in keyring upon success (cherry picked from commit d9f4b023fd4211affdd5a1b69305a4de78ac60f3)

2012-10-26 Thread Murilo Opsfelder Araujo
Signed-off-by: Murilo Opsfelder Araujo muri...@linux.vnet.ibm.com Conflicts: auth-dialog/main.c --- auth-dialog/main.c | 72 +++--- 1 file changed, 58 insertions(+), 14 deletions(-) diff --git a/auth-dialog/main.c b/auth-dialog/main.c

[PATCH v2 1/7] Use gnome-keyring for password fields (cherry picked from commit 72f391a24487ab442290c47e2e670f52c41b0608)

2012-10-26 Thread Murilo Opsfelder Araujo
Signed-off-by: Murilo Opsfelder Araujo muri...@linux.vnet.ibm.com Conflicts: auth-dialog/Makefile.am auth-dialog/main.c --- auth-dialog/Makefile.am | 6 +++-- auth-dialog/main.c | 68 + configure.ac| 4 +++ 3

[PATCH v2 7/7] When entry with focus gets password from gnome-keyring, select the full region (cherry picked from commit eee2f4fd0f1aa3e2439c9ca337b00f5a382d9b8e)

2012-10-26 Thread Murilo Opsfelder Araujo
Signed-off-by: Murilo Opsfelder Araujo muri...@linux.vnet.ibm.com --- auth-dialog/main.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/auth-dialog/main.c b/auth-dialog/main.c index d688b27..cef3504 100644 --- a/auth-dialog/main.c +++ b/auth-dialog/main.c @@ -674,8

[PATCH v2 2/7] gnome-keyring: use the vpn_uuid instead of the host (cherry picked from commit db47228f8e73b41549f89d941d52ae8e3acafb62)

2012-10-26 Thread Murilo Opsfelder Araujo
Signed-off-by: Murilo Opsfelder Araujo muri...@linux.vnet.ibm.com Conflicts: auth-dialog/main.c --- auth-dialog/main.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/auth-dialog/main.c b/auth-dialog/main.c index af797e7..fe1620b 100644 ---

[PATCH v2 4/7] Handle string == NULL in gnome-keyring callback (cherry picked from commit 31a0e8b8cf78206cda34ab593ba90c3d28ebbc29)

2012-10-26 Thread Murilo Opsfelder Araujo
Signed-off-by: Murilo Opsfelder Araujo muri...@linux.vnet.ibm.com Conflicts: auth-dialog/main.c --- auth-dialog/main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/auth-dialog/main.c b/auth-dialog/main.c index e69b618..a256bda 100644 --- a/auth-dialog/main.c +++

[PATCH v2 5/7] Remove passwords from gnome-keyring when user disables 'save passwords' (cherry picked from commit a37b1f725c460b5237ed6ab36a961c2e3f1c8145)

2012-10-26 Thread Murilo Opsfelder Araujo
Also mark 'save passwords' toggle button if a password is found in keyring. Signed-off-by: Murilo Opsfelder Araujo muri...@linux.vnet.ibm.com Conflicts: auth-dialog/main.c --- v2: Also mark 'save passwords' toggle button if a password is found in keyring auth-dialog/main.c | 69

[PATCH v2 6/7] Fix nm_process_auth_form() to clear 'form_grabbed' and cancel keyring ops (cherry picked from commit 96a0741b154dbb3a629038b34c89469b9bd11adb)

2012-10-26 Thread Murilo Opsfelder Araujo
These were being done in the obsolete ui_flush() function which handled OpenSSL UI callbacks (that libopenconnect.so.2 now catches and translates into auth_forms). But not in nm_process_auth_form(). (cherry picked from commit 96a0741b154dbb3a629038b34c89469b9bd11adb) Signed-off-by: Murilo

Re: __attribute__ ((cleanup) patch

2012-10-26 Thread Colin Walters
On Fri, 2012-10-26 at 09:54 -0400, Pavel Simerda wrote: One thing I would like to give it some reasonable time. I'd still like to consult some people. Please do forward any feedback. A couple of programmers questions, though, that will help me to assess the actual value of gsystem: I'll