Re: [MM][PATCH] remove comparison of unsigned expression = 0

2013-04-30 Thread Aleksander Morgado
On 29/04/13 18:23, Ben Chan wrote: How about the cid case? cid == 0 seems to be an invalid value? Ah, true, cid == 0 wouldn't make sense there. -- Aleksander ___ networkmanager-list mailing list networkmanager-list@gnome.org

Does Network Manager Support Machine Authentication?

2013-04-30 Thread Deepak Das
Hi, I have windows client environment and machine authentication with AD has been enabled and it is working fine.  I am now planning to use linux clients and want to implement machine authentication. Is there a way to implement it using network manager? If yes then please share doc/link for the

Re: [MM] [PATCH] iface-modem-3gpp: handle non-deferrable registration state updates

2013-04-30 Thread Aleksander Morgado
Hey Ben, Resurrecting old patch... On 05/03/13 03:37, Ben Chan wrote: This patch changes MMIfaceModem3gpp to differentiate between deferrable and non-deferrable 3GPP registration state updates. Periodic or unsolicited registration state updates are deferrable, while internal updates, e.g.

Re: Does Network Manager Support Machine Authentication?

2013-04-30 Thread Dan Winship
On 04/30/2013 06:12 AM, Deepak Das wrote: Hi, I have windows client environment and machine authentication with AD has been enabled and it is working fine. I am now planning to use linux clients and want to implement machine authentication. Is there a way to implement it using network

Re: [MM][PATCH] mm-glib: use correct enum type

2013-04-30 Thread Yunlian Jiang
Hi Dan, I did not see it in the tree. Here is the updated patch without line wrapp. Thanks, --- libmm-glib/mm-manager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libmm-glib/mm-manager.c b/libmm-glib/mm-manager.c index 46dd8ce..efea9b0 100644 ---

[MM] [PATCH] broadband-bearer: fix cid check in disconnect_3gpp

2013-04-30 Thread Ben Chan
A value 0 is used to denote an invalid/uninitialized CID. This patch fixes a CID check in disconnect_3gpp() of MMBroadbandBearer such that it disables all PDP contexts via AT+CGACT=0 when no specific CID is used (i.e. cid == 0). --- src/mm-broadband-bearer.c | 2 +- 1 file changed, 1

Re: [MM] [PATCH] iface-modem-3gpp: handle non-deferrable registration state updates

2013-04-30 Thread Ben Chan
Hi Aleksander / Dan, Would a transition from 'registered' to 'idle'/'searching' considered a 'service' loss from the connection manager's perspective (e.g. the service disappears and then reappears in connection manager)? In practice, a +CEREG change may not necessarily mean that the service

Re: [MM] [PATCH] iface-modem-3gpp: handle non-deferrable registration state updates

2013-04-30 Thread Ben Chan
+Dan On Tue, Apr 30, 2013 at 1:03 PM, Ben Chan benc...@chromium.org wrote: Hi Aleksander / Dan, Would a transition from 'registered' to 'idle'/'searching' considered a 'service' loss from the connection manager's perspective (e.g. the service disappears and then reappears in connection

Re: [PATCH] Add libgsystem as a git submodule

2013-04-30 Thread Colin Walters
On Fri, 2013-04-26 at 16:42 -0400, Colin Walters wrote: And change src/main.c to use the local allocation macros. This results in much cleaner code, as one can see from the diff. Because libgsystem is designed for nonrecursive make, it fits best in the current recursive setup if we build .

[MM] [PATCH] broadband-modem: update signal quality normalization

2013-04-30 Thread Ben Chan
This patch updates normalize_ciev_cind_signal_quality() in MMBroadbandModem to remove an unnecessary check on 'quality = 0' and also makes sure the normalized signal quality is capped at 100 when no maximum is specified. This is revised from a patch originally authored by Yunlian Jiang

Re: [MM][PATCH] remove comparison of unsigned expression = 0

2013-04-30 Thread Ben Chan
I fixed the cid check in a different way: https://mail.gnome.org/archives/networkmanager-list/2013-April/msg00223.html Also revise the quality normalization: https://mail.gnome.org/archives/networkmanager-list/2013-April/msg00227.html On Tue, Apr 30, 2013 at 12:09 AM, Aleksander Morgado

Re: [MM][PATCH] mm-glib: use correct enum type

2013-04-30 Thread Dan Williams
On Tue, 2013-04-30 at 11:33 -0700, Yunlian Jiang wrote: Hi Dan, I did not see it in the tree. Here is the updated patch without line wrapp. It's git commit 9dcbf33c88615b6b3baeec0d79a320b6df0bd403. And unfortunately the patch here is still linewrapped... usually the mail client has

Re: [MM] [PATCH] iface-modem-3gpp: handle non-deferrable registration state updates

2013-04-30 Thread Dan Williams
On Tue, 2013-04-30 at 13:03 -0700, Ben Chan wrote: Hi Aleksander / Dan, Would a transition from 'registered' to 'idle'/'searching' considered a 'service' loss from the connection manager's perspective (e.g. the service disappears and then reappears in connection manager)? In practice, a

Re: [MM] [PATCH] broadband-modem: update signal quality normalization

2013-04-30 Thread Dan Williams
On Tue, 2013-04-30 at 13:32 -0700, Ben Chan wrote: This patch updates normalize_ciev_cind_signal_quality() in MMBroadbandModem to remove an unnecessary check on 'quality = 0' and also makes sure the normalized signal quality is capped at 100 when no maximum is specified. This is revised