On Thu, 2016-02-11 at 14:39 -0600, Dan Williams wrote:
> On Thu, 2016-02-11 at 13:21 +0100, Thomas Haller wrote:
> >
> > Patch lgtm, but it doesn't apply anywhere.
>
> Sorry, patch was against 1.0.
I actually tried it on 1.0. But somehow I messed up, because now the
patch cleanly applies
Using strcmp() to test for string equality is a well known pattern.
However the inverse logic still hurts my brain every single time,
especially in more complex expressions.
nm_streq() should be preferred over strcmp(). And there is a counterpart
nm_streq0() which uses g_strcmp0().
Kernel and
We should not have defines/macros in header files without a nm/NM prefix.
STRLEN() was one of the few offendors.
---
clients/cli/settings.c| 8 ++---
libnm-core/nm-keyfile-reader.c| 12
libnm-core/nm-setting-8021x.c |
Hi,
i was able to establish a connection via qmicli, but still not with
NetworkManager/ModemManager, maybe this information can help to solve
the problem:
ThinClient,initial:root:/sys/devices/pci:00/:00:14.0/usb3/3-11 $
qmicli -d /dev/cdc-wdm0 --wds-start-network=web.vodafone.de
On Fri, 2016-02-12 at 13:10 +0100, Harald Jung wrote:
> Hi,
>
> i was able to establish a connection via qmicli, but still not with
> NetworkManager/ModemManager, maybe this information can help to
> solve
> the problem:
Good info actually; perhaps it's the IPv6 requests. If you set IPv6
On Fri, 2016-02-12 at 12:34 +0100, Thomas Haller wrote:
> We should not have defines/macros in header files without a nm/NM
> prefix.
> STRLEN() was one of the few offendors.
> ---
LGTM.
Dan
> clients/cli/settings.c| 8 ++---
> libnm-core/nm-keyfile-reader.c
On Fri, 2016-02-12 at 12:34 +0100, Thomas Haller wrote:
> Using strcmp() to test for string equality is a well known pattern.
> However the inverse logic still hurts my brain every single time,
> especially in more complex expressions.
>
> nm_streq() should be preferred over strcmp(). And there
