On Tue, 2016-02-23 at 14:35 -0600, Dan Williams wrote:
> If a monitor interface is created, NM will grab that interface
> and change it to station mode. That's not very nice.
>
> diff --git a/src/devices/wifi/nm-wifi-factory.c
> b/src/devices/wifi/nm-wifi-factory.c
lgtm too
Thomas
The value written to sysctl is usually a short string. It makes sense
to optimize for this case and avoid allocating a temporary string
on the heap.
An alternative would be to use writev(), which effectively does the same
and also creates a temporary buffer (preferably stack allocated).
---
On Tue, Feb 23, 2016 at 02:35:53PM -0600, Dan Williams wrote:
> If a monitor interface is created, NM will grab that interface
> and change it to station mode. That's not very nice.
LGTM.
Beniamino
signature.asc
Description: PGP signature
___
If a monitor interface is created, NM will grab that interface
and change it to station mode. That's not very nice.
diff --git a/src/devices/wifi/nm-wifi-factory.c
b/src/devices/wifi/nm-wifi-factory.c
index 1c8ca47..2d5f8fa 100644
--- a/src/devices/wifi/nm-wifi-factory.c
+++
