Re: [PATCH] vpn-connection: lack of ipv4 config in remote VPN is not fatal

2015-11-24 Thread Rafaël Carré
On 16/11/2015 18:12, Lubomir Rintel wrote: > On Thu, 2015-11-05 at 12:44 +0100, Rafaël Carré wrote: >> Hello, >> >> On 05/11/2015 12:31, Lubomir Rintel wrote: >>> Thanks for the patch, Rafaël. >>> >>> I'm not sure it's correct, though. The VPN plugi

Re: [PATCH] vpn-connection: lack of ipv4 config in remote VPN is not fatal

2015-11-17 Thread Rafaël Carré
On 16/11/2015 18:12, Lubomir Rintel wrote: > On Thu, 2015-11-05 at 12:44 +0100, Rafaël Carré wrote: >> Hello, >> >> On 05/11/2015 12:31, Lubomir Rintel wrote: >>> Thanks for the patch, Rafaël. >>> >>> I'm not sure it's correct, though. The VPN plugi

Re: [PATCH] openvpn: lack of ipv4 config on tap interface is not fatal

2015-11-05 Thread Rafaël Carré
= NM_IP_CONFIG_SOURCE_VPN; nm_ip4_config_add_address (config, ); - } else { + } else if (0) { nm_log_err (LOGD_VPN, "invalid IP4 config received!"); g_object_unref (config); nm_vpn_connection_config_maybe_complete (connection, FALSE); > On Tue, 2015-1

Re: [PATCH] vpn-connection: lack of ipv4 config in remote VPN is not fatal

2015-11-05 Thread Rafaël Carré
export ifconfig_local=192.168.123.11 fi exec /usr/lib/networkmanager/nm-openvpn-service-openvpn-helper.real $* Do you want to give me a patch that I could test? > On Tue, 2015-11-03 at 19:31 +0100, Rafaël Carré wrote: >> IPv4 config can be set manually >> --- >> src/vpn-manager/n

Re: [PATCH] openvpn: lack of ipv4 config on tap interface is not fatal

2015-11-05 Thread Rafaël Carré
On 05/11/2015 12:38, Rafaël Carré wrote: > Hello, > > On 05/11/2015 12:34, Lubomir Rintel wrote: >> Hello Rafaël, >> >> I'm not sure I understand this one either. What do you mean it's fatal >> now? There's just a g_warning(). Is it that without your other pa

[PATCH] vpn-connection: lack of ipv4 config in remote VPN is not fatal

2015-11-03 Thread Rafaël Carré
IPv4 config can be set manually --- src/vpn-manager/nm-vpn-connection.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/vpn-manager/nm-vpn-connection.c b/src/vpn-manager/nm-vpn-connection.c index 0c0ac1c..fc49304 100644 --- a/src/vpn-manager/nm-vpn-connection.c +++

[PATCH] openvpn: lack of ipv4 config on tap interface is not fatal

2015-11-03 Thread Rafaël Carré
IPv4 config can be set manually --- src/nm-openvpn-service-openvpn-helper.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/src/nm-openvpn-service-openvpn-helper.c b/src/nm-openvpn-service-openvpn-helper.c index 512d6ce..4f93193 100644 ---