Re: [PATCH] Improve WPAD proxy handling

2013-06-13 Thread Dan Williams
On Wed, 2013-06-12 at 15:26 +0100, David Woodhouse wrote: We already request WPAD information from the DHCP server (bug 368423) but we don't do anything useful with it at all. Well, except provide it to dispatcher clients. This was sort of waiting on more coherent proxy support including

Re: [PATCH] Improve WPAD proxy handling

2013-06-13 Thread Dan Williams
On Thu, 2013-06-13 at 20:42 +0100, David Woodhouse wrote: On Thu, 2013-06-13 at 13:30 -0500, Dan Williams wrote: On Wed, 2013-06-12 at 15:26 +0100, David Woodhouse wrote: We already request WPAD information from the DHCP server (bug 368423) but we don't do anything useful with it at all.

Re: [PATCH] Improve WPAD proxy handling

2013-06-13 Thread David Woodhouse
On Thu, 2013-06-13 at 15:27 -0500, Dan Williams wrote: Because the parent device config is passed to the dispatcher here, which pulls out the DHCP options. Given that VPN connections don't currently have DHCP capability, I'd expect clients to ignore that information. For proxy

Re: [PATCH] Improve WPAD proxy handling

2013-06-13 Thread David Woodhouse
On Thu, 2013-06-13 at 13:30 -0500, Dan Williams wrote: On Wed, 2013-06-12 at 15:26 +0100, David Woodhouse wrote: We already request WPAD information from the DHCP server (bug 368423) but we don't do anything useful with it at all. Well, except provide it to dispatcher clients. Yeah, but

[PATCH] Improve WPAD proxy handling

2013-06-12 Thread David Woodhouse
We already request WPAD information from the DHCP server (bug 368423) but we don't do anything useful with it at all. The same information can also come from a VPN server, but we don't even *collect* that. This patch fixes the latter, and exposes the information in a coherent fashion. There's no