Re: [PATCH] wifi: allow autoconnect on AP/AdHoc mode connections with manual IP configuration

2016-02-12 Thread Thomas Haller
On Thu, 2016-02-11 at 14:39 -0600, Dan Williams wrote: > On Thu, 2016-02-11 at 13:21 +0100, Thomas Haller wrote: > >  > > Patch lgtm, but it doesn't apply anywhere. > > Sorry, patch was against 1.0. I actually tried it on 1.0. But somehow I messed up, because now the patch cleanly applies

Re: [PATCH] wifi: allow autoconnect on AP/AdHoc mode connections with manual IP configuration

2016-02-11 Thread Thomas Haller
On Mon, 2016-02-08 at 17:03 -0600, Dan Williams wrote: > The existing checks assumed that all AP/AdHoc connections would use > the > shared IP method.  But what we really want to check for here is > whether the > connection is AP/AdHoc.  Leave the existing 'shared' check for > backwards >

Re: [PATCH] wifi: allow autoconnect on AP/AdHoc mode connections with manual IP configuration

2016-02-11 Thread Dan Williams
On Thu, 2016-02-11 at 13:21 +0100, Thomas Haller wrote: > On Mon, 2016-02-08 at 17:03 -0600, Dan Williams wrote: > > The existing checks assumed that all AP/AdHoc connections would use > > the > > shared IP method.  But what we really want to check for here is > > whether the > > connection is

[PATCH] wifi: allow autoconnect on AP/AdHoc mode connections with manual IP configuration

2016-02-08 Thread Dan Williams
The existing checks assumed that all AP/AdHoc connections would use the shared IP method. But what we really want to check for here is whether the connection is AP/AdHoc. Leave the existing 'shared' check for backwards compatibility. Also move the check above the timestamp check, since the user