Re: [PATCH 1/1] applet: fix tracking of active access-point

2016-03-08 Thread Thomas Haller
On Tue, 2016-03-08 at 14:07 +0100, Beniamino Galvani wrote: > On Tue, Mar 08, 2016 at 10:00:51AM +0100, Thomas Haller wrote: > > > > Fix that, by registering a weak-ref to the access-point, so that we > > notice when the access-point gets destroyed. Note that we don't > > want > > to take strong

Re: [PATCH 1/1] applet: fix tracking of active access-point

2016-03-08 Thread Beniamino Galvani
On Tue, Mar 08, 2016 at 10:00:51AM +0100, Thomas Haller wrote: > Fix that, by registering a weak-ref to the access-point, so that we > notice when the access-point gets destroyed. Note that we don't want > to take strong references, because neither device, access-point nor > applet should keep

[PATCH 1/1] applet: fix tracking of active access-point

2016-03-08 Thread Thomas Haller
Caught the following valgrind error on network-manager-applet-1.2.0-0.3.beta1.fc24: == Invalid read of size 8 ==at 0x822471D: g_type_check_instance (gtype.c:4137) ==by 0x8218B63: g_signal_handlers_disconnect_matched (gsignal.c:2925) ==by 0x129B3D: update_active_ap