Re: [review] dcbw/vpn-routes-cleanup: fix disappearing VPN routes on address renewals

2013-08-01 Thread Dan Williams
On Wed, 2013-07-31 at 14:59 -0500, Dan Williams wrote: > Review appreciated, especially from Pavel. I don't really like the > added parameter to nm_ipX_config_commit() but it's actually simpler code > than the alternatives, and we don't really want these routes in the main > IPXConfig objects beca

[review] dcbw/vpn-routes-cleanup: fix disappearing VPN routes on address renewals

2013-07-31 Thread Dan Williams
Review appreciated, especially from Pavel. I don't really like the added parameter to nm_ipX_config_commit() but it's actually simpler code than the alternatives, and we don't really want these routes in the main IPXConfig objects because (a) they are transient and not really part of the connectio