ModemManager USSD resonse patch

2013-04-11 Thread Golikov Pavel
This patch fixes USSD respose handling. Some operators sends answer to USSD message with connection termination code. When the connection termination state recieved, we should check if we can decode the answer string. If we can, we should return this string as answer instead of error. diff

Re: ModemManager USSD resonse patch

2013-04-11 Thread Dan Williams
On Thu, 2013-04-11 at 18:30 +0400, Golikov Pavel wrote: This patch fixes USSD respose handling. Some operators sends answer to USSD message with connection termination code. When the connection termination state recieved, we should check if we can decode the answer string. If we can,

Re: ModemManager USSD resonse patch

2013-04-11 Thread Aleksander Morgado
Hey! On 11/04/13 16:30, Golikov Pavel wrote: This patch fixes USSD respose handling. Some operators sends answer to USSD message with connection termination code. When the connection termination state recieved, we should check if we can decode the answer string. If we can, we should

Re: ModemManager USSD resonse patch

2013-04-11 Thread Golikov Pavel
11.04.2013, 19:49, Aleksander Morgado aleksan...@lanedo.com: I would move the /* Some operators... */ comment to here, not in between the case: and the brace. Ок. Should we really process this case? Will it ever happen a network-initiated USSD notification with a connection termination code?

Re: ModemManager USSD resonse patch

2013-04-11 Thread Aleksander Morgado
On 11/04/13 17:58, Golikov Pavel wrote: 11.04.2013, 19:49, Aleksander Morgado aleksan...@lanedo.com: I would move the /* Some operators... */ comment to here, not in between the case: and the brace. Ок. Should we really process this case? Will it ever happen a network-initiated USSD