Re: 1.286 nm_deactivate_device bug
On Sun, 20 Feb 2005, Bill Moss wrote: g_source_remove removes a source from the default Main context but what the nm_deactivate_device function is trying to do is remove a source from the Main context of the device. I found this reference that seems to be talking about a similar issue. http://lists.imendio.com/pipermail/loudmouth/2004-September/000167.html Bill, Thanks for tracking that one down, I'll fix it ASAP. It seems that you can't ever remove a GSource from a non-main context and _reuse_ it. Blatant API oversight :) The fix is to use g_source_destroy() like they say in the email, but then of course you cannot reuse the GSource. We actually don't want to reuse it in NetworkManager, but the facility to reuse a non-default-context GSource simply isn't there. Dan ___ NetworkManager-list mailing list NetworkManager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: more refined panel icons
how about these: www.cgtp.duke.edu/~rinke/misc/NM-icons.tar.bz2 - just a more refined subdivision of the current icon with more colors ;-) addresses all your issues except for Bluecurve... Sven On Mon, 2005-02-21 at 09:58 -0500, Sven wrote: thanks for your consideration, your points are well taken. mind you, i'm not suggesting changing the current icon, i am very well aware of its appeal. still, i personally don't like it, and just experimented a little. as for the shortcomings of my set of icons, i'm sure they will become more refined over time. (eg, a recognition factor is easy enough to implement, and the signal strength division is rather arbitrary and will most likely also change.) thanks, Sven On Mon, 2005-02-21 at 11:56 +0100, Rene Rask wrote: On Sat, 2005-02-19 at 23:11 -0500, Sven wrote: hi, i don't really like the WinXP look and feel of NM's signal strength icon :-| in addition, it only indicates strengths in the regions 100% 75% 50% 25% 0% (for what it's worth anyway). i quite like gwlan's icon, nevertheless i decided to come up with my own design (which probably already exists out there). i'm as bold as to suggest to change NM's icons, but if somebody out there wants a more refined set of panel icons for the signal strength, here's a patch and a link to a set of icons (that need to be copied to NM's panel-applet/icons/ directory before compiling). the strength range is 100 85 65 45 25 5 0, and the color changes according to the signal strength range. it's certainly not perfect and not meant for everybody, but i thought i'd share it with the NM world - maybe somebody finds it useful (i.e., likes it or feels inspired to do her/his own icons). I must admit that I like the current icon. - It clearly show that you are connected. - It shows the strength of the signal and if you need more detail, you can hover the pointer above it. - It resembles the signal strength icon on many mobile phones which is a big plus. Your icon on the other hand has no recognition factor _at all_. The icon disappears with low signal strength. The clue as to how strong the signal is is gone. You don't have a visual reference for maximum strength when your strength is low. I mean, its like saying strength is 5 without also making clear that it is 5 out of 10 with 10 being the strongest. If you really want a new icon I would suggest it be made a theme option. The current one is a perfect match for bluecurve and more importantly it is obviously a strength indicator. That is just my opinion of course. Cheers Rene ___ NetworkManager-list mailing list NetworkManager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list ___ NetworkManager-list mailing list NetworkManager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list ___ NetworkManager-list mailing list NetworkManager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list
Possible nmwa_dbus_update_device_wireless_networks bug
About a week ago, I noticed in my office that hovering over the NMN icon would show a signal strength of 80% put the progress bar would show below 50%. The command 'iwlist eth1 scan' showed two AP's, one weak and one strong. The hover was showing the strong AP and the progress bar was showing the weak one because it apparently was first in the AP list. I produced a patch to the function nmwa_dbus_update_device_wireless_networks that would display the AP with the max strength in case there were multiple AP's with the same essid. Since CVS-2-22, I have noticed that this patch is not needed. To understand this better I applied yet another patch (below). This deletes the code that eliminates duplicates and it prints out the AP list to syslog everytime the function nmwa_dbus_update_device_wireless_networks is called. Here is what I have observed. 1. When there are duplicate AP's in the list (same essid), they always have the same (max) strength. This is a new feature. Did you do it intentionally? 2. The function nmwa_dbus_update_device_wireless_networks gets called once before wireless device activation, twice during wireless device activation, and once immediately after wireless device activation, and then it is only called when the wireless ip address is renewed. I assumed that nmwa_dbus_update_device_wireless_networks would be called everytime a scan is done but that does not seem to be the case because I believe scans are done repeatedly after activation with an increasing time interval between scans. It would be useful to call nmwa_dbus_update_device_wireless_networks every time a scan is done because, as it is now, the information in the progress bar can get rather stall before it is updated when the ip address is renewed. __ --- NMWirelessAppletDbus.c_orig 2005-02-19 14:43:46.0 -0500 +++ NMWirelessAppletDbus.c 2005-02-22 00:08:51.989911560 -0500 @@ -29,6 +29,7 @@ #include dbus/dbus-glib-lowlevel.h #include NMWirelessAppletDbus.h #include NMWirelessApplet.h +#include syslog.h #defineDBUS_NO_SERVICE_ERROR org.freedesktop.DBus.Error.ServiceDoesNotExist @@ -1007,12 +1008,6 @@ * of access points, and there may be more than one that have the same ESSID. Filter * them here. */ - for (j = 0; j i; j++) - if ((found = (networks[j] (strcmp (networks[i], networks[j]) == 0 - break; - if (found) - continue; - net = wireless_network_new (); /* FIXME: what if net == NULL? */ net-nm_name = g_strdup (networks[i]); @@ -1022,6 +1017,7 @@ net-strength = nmwa_dbus_get_object_strength (applet, net-nm_name); dev-networks = g_slist_append (dev-networks, net); +syslog (LOG_INFO, num_items is %d item %d essid is %s strength is %d\n, num_items, i, net-essid, net-strength); } dbus_free (name); } -- Bill Moss Professor, Mathematical Sciences Clemson University ___ NetworkManager-list mailing list NetworkManager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list
