Re: [PATCH 1/1] platform: optimize sysctl_set() to use stack allocated buffer

2016-02-24 Thread Colin Walters
On Tue, Feb 23, 2016, at 05:54 PM, Thomas Haller wrote: > The value written to sysctl is usually a short string. It makes sense > to optimize for this case and avoid allocating a temporary string > on the heap. Hey, so a while ago I was pushing for NetworkManager to use libgsystem, which then got

Re: [PATCH] wifi: ignore monitor interfaces

2016-02-24 Thread Thomas Haller
On Tue, 2016-02-23 at 14:35 -0600, Dan Williams wrote: > If a monitor interface is created, NM will grab that interface > and change it to station mode.  That's not very nice. > > diff --git a/src/devices/wifi/nm-wifi-factory.c > b/src/devices/wifi/nm-wifi-factory.c merged:

Re: [PATCH 1/1] platform: optimize sysctl_set() to use stack allocated buffer

2016-02-24 Thread Thomas Haller
On Tue, 2016-02-23 at 23:54 +0100, Thomas Haller wrote: > The value written to sysctl is usually a short string. It makes sense > to optimize for this case and avoid allocating a temporary string > on the heap. > > An alternative would be to use writev(), which effectively does the > same > and

Re: [PATCH 1/1] platform: optimize sysctl_set() to use stack allocated buffer

2016-02-24 Thread Beniamino Galvani
On Tue, Feb 23, 2016 at 11:54:43PM +0100, Thomas Haller wrote: > The value written to sysctl is usually a short string. It makes sense > to optimize for this case and avoid allocating a temporary string > on the heap. LGTM. Beniamino signature.asc Description: PGP signature