Re: [RFC PATCH 2/2] platform: add support for WireGuard links

2018-03-14 Thread Javier Arteaga
Hi Thomas, Thanks a lot for your feedback! Comments inline. On Wed, Mar 14, 2018 at 3:15 PM, Thomas Haller wrote: [...] >> + NMP_OBJECT_TYPE_LNK_WIREGUARD, >> + >> + NMP_OBJECT_TYPE_WIREGUARD_PEER, >> + NMP_OBJECT_TYPE_WIREGUARD_ALLOWEDIP, > > You ask whether peer/allowed-ip should b

Re: [RFC PATCH 2/2] platform: add support for WireGuard links

2018-03-14 Thread Thomas Haller
On Wed, 2018-03-14 at 00:03 +, Javier Arteaga wrote: > Add support for a new wireguard link type to the platform code. For > now > this only covers querying existing links via Generic Netlink and > parsing > them into platform objects. > --- > + > +static NMPObject * > +_parse_lnk_wireguard (co

Re: Problems with modems/Example config for QMI-based modem,

2018-03-14 Thread Dan Williams
On Tue, 2018-03-06 at 12:01 +0100, Jakob Hasse wrote: > Hello Dan, thanks for the answer. > > On 28.02.2018 22:38, Dan Williams wrote: > > On Wed, 2018-02-28 at 18:40 +0100, Jakob Hasse wrote: > > > Hello, > > > > > > We want to integrate different modems into our embedded system. > > > Recently,

Re: [RFC PATCH 2/2] platform: add support for WireGuard links

2018-03-14 Thread Thomas Haller
On Wed, 2018-03-14 at 00:03 +, Javier Arteaga wrote: > Add support for a new wireguard link type to the platform code. For > now > this only covers querying existing links via Generic Netlink and > parsing > them into platform objects. > --- > src/nm-types.h | 5 + > src/pl

Re: [RFC PATCH 1/2] platform: move genl_ctrl_resolve to nm-netlink.c

2018-03-14 Thread Javier Arteaga
On Wed, Mar 14, 2018 at 11:35 AM, Thomas Haller wrote: > Hi, > >> -out: >> - if (result >= 0) >> - _LOGD (LOGD_WIFI, "genl_ctrl_resolve: resolved >> \"%s\" as 0x%x", name, result); >> - else >> - _LOGE (LOGD_WIFI, "genl_ctrl_resolve: failed resolve >> \"%s\"", name)

Re: [RFC PATCH 1/2] platform: move genl_ctrl_resolve to nm-netlink.c

2018-03-14 Thread Thomas Haller
On Wed, 2018-03-14 at 00:03 +, Javier Arteaga wrote: > Move genl_ctrl_resolve out of the wifi code so it can be reused by > other > interfaces based on genetlink. Hi, > -out: > - if (result >= 0) > - _LOGD (LOGD_WIFI, "genl_ctrl_resolve: resolved > \"%s\" as 0x%x", name, resul

Re: [RFC PATCH 0/2] platform: add WireGuard support

2018-03-14 Thread Javier Arteaga
On Wed, Mar 14, 2018 at 2:21 AM, Jason A. Donenfeld wrote: > Hey Javier, > > Thanks for getting this rolling. Very exciting. Unfortunately, I'm in > traveling through Chile right now with somewhat limited connectivity, > so I won't be able to give this the review it deserves until the first > week

Re: [RFC PATCH 0/2] platform: add WireGuard support

2018-03-14 Thread Jason A. Donenfeld
Hey Javier, Thanks for getting this rolling. Very exciting. Unfortunately, I'm in traveling through Chile right now with somewhat limited connectivity, so I won't be able to give this the review it deserves until the first week of April. But I'll certainly get churning with whatever the latest pat