Re: [PATCH] libnm-glib/libnm/vpn: fix handling of ConnectInteractive() failure (rh #1298732)

2016-03-02 Thread Thomas Haller
On Fri, 2016-02-26 at 16:16 -0600, Dan Williams wrote: > If the plugin supports interactive mode, but the VPN binary (like > vpnc > or openvpn) doesn't support it, then the plugin should return > NM_VPN_PLUGIN_ERROR_INTERACTIVE_NOT_SUPPORTED from its > connect_interactive() > hook.  This lets

Re: [PATCH] libnm-glib/libnm/vpn: fix handling of ConnectInteractive() failure (rh #1298732)

2016-03-01 Thread Colin Walters
I backported this on top of NetworkManager-1.0.6-28, dropped the hunks for -service.c which appear to not exist, re-upgraded to NetworkManager-vpnc-1.0.8-1.el7.x86_64, and connected to my VPN successfully. Thanks! Tested-by: Colin Walters

[PATCH] libnm-glib/libnm/vpn: fix handling of ConnectInteractive() failure (rh #1298732)

2016-02-26 Thread Dan Williams
If the plugin supports interactive mode, but the VPN binary (like vpnc or openvpn) doesn't support it, then the plugin should return NM_VPN_PLUGIN_ERROR_INTERACTIVE_NOT_SUPPORTED from its connect_interactive() hook.  This lets NetworkManager know to fall back to plain Connect(). Since this