Re: ipw srcipts for hal

2007-07-01 Thread dragoran
Bastien Nocera wrote: On Sun, 2007-06-24 at 22:15 +0200, dragoran wrote: here is a C implementation of the ipwWirelessCtl the udi is hardcoded and I only implemented get for now (will add the rest tomorrow). It also uses all values from the README. yelo_3 you have a typo in your patch (you

Re: ipw srcipts for hal

2007-06-27 Thread Bastien Nocera
On Sun, 2007-06-24 at 22:15 +0200, dragoran wrote: here is a C implementation of the ipwWirelessCtl the udi is hardcoded and I only implemented get for now (will add the rest tomorrow). It also uses all values from the README. yelo_3 you have a typo in your patch (you used getrfkill instead of

Re: ipw srcipts for hal

2007-06-27 Thread Bastien Nocera
On Mon, 2007-06-25 at 14:01 +0200, dragoran wrote: Dan Williams wrote: On Mon, 2007-06-25 at 13:33 +0200, dragoran wrote: yelo_3 wrote: I've had a look at your implementation. I have a question: Think if someone has 2 ipw cards (I don't know if it is possible, but think it

Re: ipw srcipts for hal

2007-06-27 Thread Bastien Nocera
On Mon, 2007-06-25 at 12:28 +, yelo_3 wrote: I think the scripts will provide multiple killswitches, one for each ipw device found. And once ipwWirelessCtl uses the UDI that's passed to it, it should work fine with multiple killswitches. So the work with the UDI might be done in the

Re: ipw srcipts for hal

2007-06-27 Thread Bastien Nocera
On Mon, 2007-06-25 at 12:13 -0400, Dan Williams wrote: On Mon, 2007-06-25 at 16:09 +0200, dragoran wrote: On 6/25/07, yelo_3 [EMAIL PROTECTED] wrote: ok, but this does not solve the problem of multiple killswitches (will show up with multiple cards) because

Re: ipw srcipts for hal

2007-06-27 Thread dragoran
Bastien Nocera wrote: On Sun, 2007-06-24 at 22:15 +0200, dragoran wrote: here is a C implementation of the ipwWirelessCtl the udi is hardcoded and I only implemented get for now (will add the rest tomorrow). It also uses all values from the README. yelo_3 you have a typo in your patch

Re: ipw srcipts for hal

2007-06-27 Thread Bastien Nocera
On Wed, 2007-06-27 at 15:38 +0200, dragoran wrote: Bastien Nocera wrote: On Sun, 2007-06-24 at 22:15 +0200, dragoran wrote: here is a C implementation of the ipwWirelessCtl the udi is hardcoded and I only implemented get for now (will add the rest tomorrow). It also uses all values

Re: ipw srcipts for hal

2007-06-27 Thread dragoran
Bastien Nocera wrote: On Wed, 2007-06-27 at 15:38 +0200, dragoran wrote: Bastien Nocera wrote: On Sun, 2007-06-24 at 22:15 +0200, dragoran wrote: here is a C implementation of the ipwWirelessCtl the udi is hardcoded and I only implemented get for now (will add the rest

Re: ipw srcipts for hal

2007-06-27 Thread Dan Williams
On Wed, 2007-06-27 at 14:15 +0100, Bastien Nocera wrote: On Mon, 2007-06-25 at 12:13 -0400, Dan Williams wrote: On Mon, 2007-06-25 at 16:09 +0200, dragoran wrote: On 6/25/07, yelo_3 [EMAIL PROTECTED] wrote: ok, but this does not solve the problem of multiple

Re: ipw srcipts for hal

2007-06-27 Thread Bastien Nocera
On Wed, 2007-06-27 at 15:46 +0200, dragoran wrote: Bastien Nocera wrote: snip ok will fix the program to use the env var and open a thread on the hal list. is it subscribers only list or can I post directly to it? No idea, I believe it's subscribers only though. -- Bastien Nocera [EMAIL

Re: ipw srcipts for hal

2007-06-26 Thread yelo_3
I added a bug to hal, please add patches so they can evaluate them! http://bugs.freedesktop.org/show_bug.cgi?id=11362 ___ L'email della prossima generazione? Puoi averla con la nuova Yahoo! Mail:

Re: ipw srcipts for hal

2007-06-25 Thread Dan Williams
On Mon, 2007-06-25 at 13:33 +0200, dragoran wrote: yelo_3 wrote: I've had a look at your implementation. I have a question: Think if someone has 2 ipw cards (I don't know if it is possible, but think it is, since it is an example) will he have 2 killswitches in hal, or just one? If it

Re: ipw srcipts for hal

2007-06-25 Thread dragoran
yelo_3 wrote: I've had a look at your implementation. I have a question: Think if someone has 2 ipw cards (I don't know if it is possible, but think it is, since it is an example) will he have 2 killswitches in hal, or just one? If it has two, the script is executed two times, so it would be

Re: ipw srcipts for hal

2007-06-25 Thread yelo_3
I think the scripts will provide multiple killswitches, one for each ipw device found. And once ipwWirelessCtl uses the UDI that's passed to it, it should work fine with multiple killswitches. So the work with the UDI might be done in the shell script hal-system-killswitch-?et-power, so that

Re: ipw srcipts for hal

2007-06-25 Thread dragoran
Dan Williams wrote: On Mon, 2007-06-25 at 13:33 +0200, dragoran wrote: yelo_3 wrote: I've had a look at your implementation. I have a question: Think if someone has 2 ipw cards (I don't know if it is possible, but think it is, since it is an example) will he have 2 killswitches in

Re: ipw srcipts for hal

2007-06-25 Thread yelo_3
; [EMAIL PROTECTED]; Dan Williams [EMAIL PROTECTED] Inviato: Domenica 24 giugno 2007, 22:15:30 Oggetto: Re: ipw srcipts for hal here is a C implementation of the ipwWirelessCtl the udi is hardcoded and I only implemented get for now (will add the rest tomorrow). It also uses all values from the README

Re: ipw srcipts for hal

2007-06-25 Thread dragoran
yelo_3 wrote: This is how in bash we could find the interface by the udi ok, but this does not solve the problem of multiple killswitches (will show up with multiple cards) because both will have /org/freedesktop/Hal/devices/ipw_wlan_switch as uid.

Re: ipw srcipts for hal

2007-06-25 Thread yelo_3
This is how in bash we could find the interface by the udi ___ L'email della prossima generazione? Puoi averla con la nuova Yahoo! Mail: http://it.docs.yahoo.com/nowyoucan.html find-interface-by-udi.sh Description: application/shellscript

Re: ipw srcipts for hal

2007-06-25 Thread dragoran
yelo_3 wrote: instead of using sprintf you should use #include glib.h char* path = g_strconcat(/sys/class/net/, iface, /device/rf_kill, NULL); [...] g_free(path); didn't want to make hal depend on glib but it seems that it does this anyway so I will use this or g_strdup_printf()

Re: ipw srcipts for hal

2007-06-25 Thread dragoran
yelo_3 wrote: I think the scripts will provide multiple killswitches, one for each ipw device found. And once ipwWirelessCtl uses the UDI that's passed to it, it should work fine with multiple killswitches. So the work with the UDI might be done in the shell script

Re: ipw srcipts for hal

2007-06-25 Thread yelo_3
ok, but this does not solve the problem of multiple killswitches (will show up with multiple cards) because both will have /org/freedesktop/Hal/devices/ipw_wlan_switch as uid. Yes the previous shell script didn't solve the problem... sorry. This might mean that the UDI should contain the

Re: ipw srcipts for hal

2007-06-25 Thread dragoran
On 6/25/07, yelo_3 [EMAIL PROTECTED] wrote: ok, but this does not solve the problem of multiple killswitches (will show up with multiple cards) because both will have /org/freedesktop/Hal/devices/ipw_wlan_switch as uid. Yes the previous shell script didn't solve the problem... sorry. This

Re: ipw srcipts for hal

2007-06-25 Thread yelo_3
Thank you! I will have a look at it soon. - Messaggio originale - Da: dragoran [EMAIL PROTECTED] A: yelo_3 [EMAIL PROTECTED] Cc: Dan Williams [EMAIL PROTECTED]; network manager networkmanager-list@gnome.org Inviato: Lunedì 25 giugno 2007, 16:09:30 Oggetto: Re: ipw srcipts for hal On 6

Re: ipw srcipts for hal

2007-06-25 Thread Dan Williams
On Mon, 2007-06-25 at 16:09 +0200, dragoran wrote: On 6/25/07, yelo_3 [EMAIL PROTECTED] wrote: ok, but this does not solve the problem of multiple killswitches (will show up with multiple cards) because both will have

Re: ipw srcipts for hal

2007-06-25 Thread dragoran
On 6/25/07, Dan Williams [EMAIL PROTECTED] wrote: On Mon, 2007-06-25 at 16:09 +0200, dragoran wrote: On 6/25/07, yelo_3 [EMAIL PROTECTED] wrote: ok, but this does not solve the problem of multiple killswitches (will show up with multiple cards) because both will

Re: ipw srcipts for hal

2007-06-25 Thread Dan Williams
On Mon, 2007-06-25 at 18:20 +0200, dragoran wrote: On 6/25/07, Dan Williams [EMAIL PROTECTED] wrote: On Mon, 2007-06-25 at 16:09 +0200, dragoran wrote: On 6/25/07, yelo_3 [EMAIL PROTECTED] wrote: ok, but this does not solve the problem

Re: ipw srcipts for hal

2007-06-25 Thread dragoran
ok here are the new ipwWirelessCtl.c and the .fdi file 10-ipw-rfkill-switch.fdi Description: Binary data #include libhal.h #include stdio.h #include string.h #include glib.h static LibHalContext *hal_ctx; int main(int argc,char** argv) { DBusError error; char *iface; int i,j,k; int

Re: ipw srcipts for hal

2007-06-25 Thread dragoran
On 6/25/07, yelo_3 [EMAIL PROTECTED] wrote: I've removed some code duplication... And in my opinion the script should return On if it founds at least one card on, and not as dan said, off if it finds at least one card off.. It is just an opinion... Because one card on is enough to say that you

Re: ipw srcipts for hal

2007-06-25 Thread dragoran
here again with some cleanups. btw the new fdi file seems not to work: there is no ipw_killswitch under computer for me... any idea why? #include libhal.h #include stdio.h #include string.h #include glib.h static LibHalContext *hal_ctx; int main(int argc,char** argv) { DBusError error; char

Re: ipw srcipts for hal

2007-06-25 Thread dragoran
On 6/25/07, dragoran [EMAIL PROTECTED] wrote: here again with some cleanups. btw the new fdi file seems not to work: there is no ipw_killswitch under computer for me... any idea why? ok seems that the dell check does not work. Bastien/David any idea how this could be done?

Re: ipw srcipts for hal

2007-06-25 Thread yelo_3
: dragoran [EMAIL PROTECTED] A: yelo_3 [EMAIL PROTECTED] Cc: Dan Williams [EMAIL PROTECTED]; network manager networkmanager-list@gnome.org; David Zeuthen [EMAIL PROTECTED]; Bastien Nocera [EMAIL PROTECTED] Inviato: Lunedì 25 giugno 2007, 19:14:24 Oggetto: Re: ipw srcipts for hal On 6/25/07

Re: ipw srcipts for hal

2007-06-25 Thread dragoran
On 6/25/07, yelo_3 [EMAIL PROTECTED] wrote: ok but please add these: 1) an error message if the user didn't invoke the file correctly already added in the cleaned up version I sended in my second mail. 2) a check to see if the setrfkill have not failed if((fd=fopen(path,rw))==NULL) return

Re: ipw srcipts for hal

2007-06-25 Thread yelo_3
already added in the cleaned up version I sended in my second mail. sorry, I sent the email before receiving the new version this check wouldn't work. when you write a value to the file it can be 0,1,2 or 3 depending on the hwkillswitch and if it worked at all. this check is important

Re: ipw srcipts for hal

2007-06-25 Thread dragoran
On 6/25/07, yelo_3 [EMAIL PROTECTED] wrote: already added in the cleaned up version I sended in my second mail. sorry, I sent the email before receiving the new version ok, np this check wouldn't work. when you write a value to the file it can be 0,1,2 or 3 depending on the hwkillswitch

Re: ipw srcipts for hal

2007-06-25 Thread yelo_3
that not what I meant... this is not a real file the values that you write to it must not be the same when you read them again. try this: echo 1 to the file while the card is killed by the hw kill switch it will contain 3 not 1. we have to check for this cases too. In fact I've written

Re: ipw srcipts for hal

2007-06-25 Thread dragoran
On 6/25/07, yelo_3 [EMAIL PROTECTED] wrote: that not what I meant... this is not a real file the values that you write to it must not be the same when you read them again. try this: echo 1 to the file while the card is killed by the hw kill switch it will contain 3 not 1. we have to check

Re: ipw srcipts for hal

2007-06-25 Thread dragoran
On 6/25/07, Larry Finger [EMAIL PROTECTED] wrote: dragoran wrote: On 6/25/07, *yelo_3* [EMAIL PROTECTED] mailto:[EMAIL PROTECTED] wrote: ok anyway sorry but why did they implement a hardware kill that cannot be revoked using software? I don't find the use case of this dunno

Re: ipw srcipts for hal

2007-06-25 Thread yelo_3
thank you! - Messaggio originale - Da: Larry Finger [EMAIL PROTECTED] A: dragoran [EMAIL PROTECTED] Cc: yelo_3 [EMAIL PROTECTED]; network manager networkmanager-list@gnome.org; Bastien Nocera [EMAIL PROTECTED] Inviato: Lunedì 25 giugno 2007, 21:15:37 Oggetto: Re: ipw srcipts for hal

Re: ipw srcipts for hal

2007-06-25 Thread Larry Finger
dragoran wrote: On 6/25/07, *yelo_3* [EMAIL PROTECTED] mailto:[EMAIL PROTECTED] wrote: ok anyway sorry but why did they implement a hardware kill that cannot be revoked using software? I don't find the use case of this dunno but thats how the cards where designed... My

Re: ipw srcipts for hal

2007-06-25 Thread dragoran
On 6/25/07, dragoran [EMAIL PROTECTED] wrote: here again with some cleanups. btw the new fdi file seems not to work: there is no ipw_killswitch under computer for me... any idea why? new one the same but fixed 2 memory leaks. (should be leakfree now) #include libhal.h #include stdio.h #include

Re: ipw srcipts for hal

2007-06-25 Thread dragoran
On 6/25/07, dragoran [EMAIL PROTECTED] wrote: On 6/25/07, dragoran [EMAIL PROTECTED] wrote: here again with some cleanups. btw the new fdi file seems not to work: there is no ipw_killswitch under computer for me... any idea why? new one the same but fixed 2 memory leaks. (should be

Re: ipw srcipts for hal

2007-06-24 Thread Bastien Nocera
On Sun, 2007-06-24 at 13:00 +, yelo_3 wrote: Starting from the scripts Dan provided, I tried to add set to them. Here is what I've done Same problems as Dan's scripts, I'll reiterate: You need to disable your script for Dell laptops, in the fdi, otherwise you end up with 2 levels of

ipw srcipts for hal

2007-06-24 Thread yelo_3
Starting from the scripts Dan provided, I tried to add set to them. Here is what I've done ___ L'email della prossima generazione? Puoi averla con la nuova Yahoo! Mail: http://it.docs.yahoo.com/nowyoucan.html 10-ipw-rfkill-switch.fdi Description:

Re: ipw srcipts for hal

2007-06-24 Thread yelo_3
] || [ $value = 2 ] || [ $value = 3 ]; then [...] - Messaggio originale - Da: Bastien Nocera [EMAIL PROTECTED] A: yelo_3 [EMAIL PROTECTED] Cc: network manager networkmanager-list@gnome.org Inviato: Domenica 24 giugno 2007, 15:22:51 Oggetto: Re: ipw srcipts for hal On Sun, 2007-06-24 at 13:00 +

Re: ipw srcipts for hal

2007-06-24 Thread dragoran
here is a C implementation of the ipwWirelessCtl the udi is hardcoded and I only implemented get for now (will add the rest tomorrow). It also uses all values from the README. yelo_3 you have a typo in your patch (you used getrfkill instead of set ;) ) Bastien: the UDI that will get passed to

Re: ipw srcipts for hal

2007-06-24 Thread dragoran
On 6/24/07, Bastien Nocera [EMAIL PROTECTED] wrote: On Sun, 2007-06-24 at 13:00 +, yelo_3 wrote: Starting from the scripts Dan provided, I tried to add set to them. Here is what I've done Same problems as Dan's scripts, I'll reiterate: You need to disable your script for Dell laptops,