On Thu, 2018-02-08 at 21:28 +0100, Aleksander Morgado wrote:
> If the user is requesting an empty response ("") as expected string,
> let the connectivity check succeed if we actually get a 204 HTTP
> response code (reporting a successful request but without content).
>
> This allows using e.g. Android's default URLs for the connectivity
> check purpose:
>
> [connectivity]
> uri=http://google.com/generate_204
> interval=60
> response=
> ---
>
> Hey hey,
>
> What do you think of this patch? This should work for all cases,
> including when trying to detect a captive portal (as the portal
> shouldn't return a 204 in any case).Hi Aleksander, I think this makes sense. Merged to master: https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=88416394f8e0a51dae9f40a31ca0c8077f08808a and a minor follow up: https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=5f1c2e16c9cac48de7fa490df08de06080bd7a0c Thanks, Thomas
signature.asc
Description: This is a digitally signed message part
_______________________________________________ networkmanager-list mailing list networkmanager-list@gnome.org https://mail.gnome.org/mailman/listinfo/networkmanager-list
