[nfs-discuss] Code review request: Connectathon NFS tests improvements

2010-02-18 Thread Gordon Ross
> Hi Gordon, Hi Rob, Thanks for having a look at this stuff. > I am mostly happy with your changes; I think they're a > useful addition to a test suite that gets intermittent > love :-) > > One thing - the special tests used to copy themselves to > the target and run from there, and you have c

[nfs-discuss] Code review request: Connectathon NFS tests improvements

2010-02-18 Thread Robert Thurlow
Gordon Ross wrote: > What I'd prefer to do with this is to augment the "general" > tests (if necessary) to cover whatever we think may be no > longer adequately covered after the changes in "special". > > Would you be OK with that plan? In general, sure, though I can't point to something specifi

[nfs-discuss] Code review request: Connectathon NFS tests improvements

2010-02-18 Thread Robert Thurlow
Gordon Ross wrote: > Now the more interesting stuff: > > Some time ago, I observed that the Connectathon NFS tests > would often terminate early after any test error. Hi Gordon, I am mostly happy with your changes; I think they're a useful addition to a test suite that gets intermittent love :-

[nfs-discuss] Code review request: Connectathon NFS tests improvements

2010-02-12 Thread Gordon Ross
Thanks for having a look. Yes, I'll be happy to take your changes. (If I'm not careful, I may end up owning this "pile":) > Hi Gordon, > > I gave it a quick sanity test on Mac OS X 10.6. It looks good. > Although it looks like you left some debug stuff in one of the > scripts: Yes, I'll remov

[nfs-discuss] Code review request: Connectathon NFS tests improvements

2010-02-12 Thread Tom Haynes
Please make sure the diffs are applied against the gate: [thud at ultralord ~/src]> hg clone ssh://anon at hg.opensolaris.org//hg/nfsv41/cthon destination directory: cthon requesting all changes adding changesets adding manifests adding file changes added 4 changesets with 157 changes to 157 file

[nfs-discuss] Code review request: Connectathon NFS tests improvements

2010-02-12 Thread Mike Mackovitch
And here are the attachments. [doh!] On Fri, Feb 12, 2010 at 06:55:22PM -0800, Mike Mackovitch wrote: > On Fri, Feb 12, 2010 at 08:36:41PM -0500, Gordon Ross wrote: > > Thanks for having a look. Yes, I'll be happy to take your changes. > > (If I'm not careful, I may end up owning this "pile":)

[nfs-discuss] Code review request: Connectathon NFS tests improvements

2010-02-12 Thread Mike Mackovitch
On Fri, Feb 12, 2010 at 08:36:41PM -0500, Gordon Ross wrote: > Thanks for having a look. Yes, I'll be happy to take your changes. > (If I'm not careful, I may end up owning this "pile":) Cool, I've attached a small patch... it's mostly minor stuff. (Actually two small patches: one against the gat

[nfs-discuss] Code review request: Connectathon NFS tests improvements

2010-02-12 Thread Mike Mackovitch
On Thu, Feb 11, 2010 at 08:54:01AM -0800, Gordon Ross wrote: > Two change sets - first the "boring" part: Fix compiler warnings, etc. > > http://cr.opensolaris.org/~gwr/cthon-nfs-tests-fixwarn/webrev/ > [...] >http://cr.opensolaris.org/~gwr/cthon-nfs-tests-keepgoing/webrev/ > [...] > > So

[nfs-discuss] Code review request: Connectathon NFS tests improvements

2010-02-11 Thread Gordon Ross
Two change sets - first the "boring" part: Fix compiler warnings, etc. http://cr.opensolaris.org/~gwr/cthon-nfs-tests-fixwarn/webrev/ Now the more interesting stuff: Some time ago, I observed that the Connectathon NFS tests would often terminate early after any test error. That may be helpfu