[nfs-discuss] Code review for 6779275 , Was: 6777298 and friends (6502014 6512906 6777323)

[Pavel Filipensky]

Hi  Dan,

recently, I have asked you and zones-core to do a code review for 6779275.
The changes require a PSARC fast-track. Could you please sponsor the 
case for that?

I am attaching a draft for the onepager.

Thanks,
Pavel


On 12/04/08 04:43, Rich Brown wrote:
> On 12/03/08 05:19, Frank Batschulat (Home) wrote:
>   
>> On Tue, 02 Dec 2008 22:29:35 +0100, Pavel Filipensky > sun.com> wrote:
>>
>> 
>>> Rob and Mike,
>>>
>>> new webrev is here:  http://cr.opensolaris.org/~pavelf/6779275/
>>>
>>> Can you review that?
>>>   
>> looks reasonable sane to me. though this should get the elevation
>> of a selfreview PSARC case.
>>
>> 
>
> Hmm... Since this is a command line change, then it's going to need
> a PSARC fast-track.  I've already exchanged e-mail with Pavel and
> suggested that he ask Dan Price (zones guy) to sponsor this.  (I
> can do it if Dan can't/won't, but it's got to go through the zones
> team either way.)
>
> Also, this change means an update to the mountall(1M) man page (which
> includes umountall).  This CR needs to have the "Fix Affects Documentation"
> field set to "yes" and a man page CR needs to be submitted for the
> doc update.  (FWIW, before the RTI for this fix can be accepted, the
> corresponding man page RTI must be marked "Fix in progress".)
>
> I hope this helps,
>
>   Rich
> ___
> nfs-discuss mailing list
> nfs-discuss at opensolaris.org
>   

-- next part --
An embedded and charset-unspecified text was scrubbed...
Name: umountall_-Z.txt
URL: 

[nfs-discuss] Code review for 6779275 , Was: 6777298 and friends (6502014 6512906 6777323)

[Frank Batschulat (Home)]

Rich Brown wrote:
> On 12/03/08 05:19, Frank Batschulat (Home) wrote:
>> On Tue, 02 Dec 2008 22:29:35 +0100, Pavel Filipensky 
>>  wrote:
>>
>>> Rob and Mike,
>>>
>>> new webrev is here:  http://cr.opensolaris.org/~pavelf/6779275/
>>>
>>> Can you review that?
>>
>> looks reasonable sane to me. though this should get the elevation
>> of a selfreview PSARC case.
>>
> Hmm... Since this is a command line change, then it's going to need
> a PSARC fast-track.  I've already exchanged e-mail with Pavel and
> suggested that he ask Dan Price (zones guy) to sponsor this.  (I
> can do it if Dan can't/won't, but it's got to go through the zones
> team either way.)
> 
> Also, this change means an update to the mountall(1M) man page (which
> includes umountall). 

I think the question might be "Should this be documented a all ?"
in the terms of an interface ? maybe better suited for an undocumented,
internal ? the interface stability level of umountall(1M) is:

System Administration Commands   mountall(1M)
 
 

 |   ATTRIBUTE TYPE|   ATTRIBUTE VALUE   | 
 
|_|_|
 | Availability| SUNWcsu | 
 
|_|_|
 | Interface Stability | Committed   | 
 
|_|_|
 | Output Stability| Uncommitted | 
 
|_|_|

is committed, think about it - what outside observer should and
reasonably can use this new "-Z" option ?, its hard to get rid of it
later if for example this case would also seek patch binding in order to
allow a backport to previous releases (which I think is desired).

---
frankB

[nfs-discuss] Code review for 6779275 , Was: 6777298 and friends (6502014 6512906 6777323)

[Rich Brown]

On 12/03/08 05:19, Frank Batschulat (Home) wrote:
> On Tue, 02 Dec 2008 22:29:35 +0100, Pavel Filipensky  sun.com> wrote:
> 
>> Rob and Mike,
>>
>> new webrev is here:  http://cr.opensolaris.org/~pavelf/6779275/
>>
>> Can you review that?
> 
> looks reasonable sane to me. though this should get the elevation
> of a selfreview PSARC case.
> 

Hmm... Since this is a command line change, then it's going to need
a PSARC fast-track.  I've already exchanged e-mail with Pavel and
suggested that he ask Dan Price (zones guy) to sponsor this.  (I
can do it if Dan can't/won't, but it's got to go through the zones
team either way.)

Also, this change means an update to the mountall(1M) man page (which
includes umountall).  This CR needs to have the "Fix Affects Documentation"
field set to "yes" and a man page CR needs to be submitted for the
doc update.  (FWIW, before the RTI for this fix can be accepted, the
corresponding man page RTI must be marked "Fix in progress".)

I hope this helps,

Rich

[nfs-discuss] Code review for 6779275 , Was: 6777298 and friends (6502014 6512906 6777323)

[robert.thur...@sun.com]

On 12/02/08 14:29, Pavel Filipensky wrote:

> new webrev is here:  http://cr.opensolaris.org/~pavelf/6779275/

Works for me, Pavel.

Rob T

[nfs-discuss] Code review for 6779275 , Was: 6777298 and friends (6502014 6512906 6777323)

[Frank Batschulat (Home)]

On Tue, 02 Dec 2008 22:29:35 +0100, Pavel Filipensky  wrote:

> Rob and Mike,
>
> new webrev is here:  http://cr.opensolaris.org/~pavelf/6779275/
>
> Can you review that?

looks reasonable sane to me. though this should get the elevation
of a selfreview PSARC case.

---
frankB

[nfs-discuss] Code review for 6779275 , Was: 6777298 and friends (6502014 6512906 6777323)

[Pavel Filipensky]

Rob and Mike,

new webrev is here:  http://cr.opensolaris.org/~pavelf/6779275/

Can you review that?

Thanks,
Pavel


Robert Thurlow wrote:
> Pavel Filipensky wrote:
>
>> 5) default behavior:: limit action(s) to the current zone
>> available options: -Z ...apply action(s) to all *non-global* zones
>>
>>
>> So I propose to implement 5). Rob, Mike does it work for you?
>
> Yes, this works for me (with the later clarifications).
>
> Thanks Pavel,
> Rob T