[nfs-discuss] mixed use of nfs3fstyp and nfsfstyp in nfs3_vfsops.c
Oops..I meant to say "Now it makes sense". The differences in interpretation was big enough to send another mail. Apologies. -Piyush Piyush Shivam wrote: > Hi Robert, > > Thanks for clarifying. Not it makes sense. > > -Piyush > > > Robert Gordon wrote: > >> On Aug 14, 2008, at 4:56 PM, Piyush Shivam wrote: >> >> >> >>> Hi, >>> >>> In the following code snippet from nfs3_vfsops.c in nfs3rootvp >>> function, I notice that vfs_make_fsid uses nfs3fstyp, whereas vfsp- >>> >>> vfs_fstype uses nfsfstype. At first glance it appears a copy/paste >>> bug, but perhaps it is intentional. Can someone please explain? >>> >>> >>> >>> 1097 vfsp->vfs_dev = nfs_dev; >>> 1098 vfs_make_fsid(&vfsp->vfs_fsid, nfs_dev, nfs3fstyp); >>> 1099 vfsp->vfs_data = (caddr_t)mi; >>> 1100 vfsp->vfs_fstype = nfsfstyp; >>> >>> >>> >>> The complete code can be browsed at: >>> >>> http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/uts/common/fs/nfs/nfs3_vfsops.c#1098 >>> >>> >> The file system type is always NFS no matter which version of the >> protocol we're using.. >> >> A wee comment would be good to add there maybe ;-) >> >> Robert. >> ___ >> nfs-discuss mailing list >> nfs-discuss at opensolaris.org >> >> > > ___ > nfs-discuss mailing list > nfs-discuss at opensolaris.org >
[nfs-discuss] mixed use of nfs3fstyp and nfsfstyp in nfs3_vfsops.c
Hi Robert, Thanks for clarifying. Not it makes sense. -Piyush Robert Gordon wrote: > On Aug 14, 2008, at 4:56 PM, Piyush Shivam wrote: > > >> Hi, >> >> In the following code snippet from nfs3_vfsops.c in nfs3rootvp >> function, I notice that vfs_make_fsid uses nfs3fstyp, whereas vfsp- >> >>> vfs_fstype uses nfsfstype. At first glance it appears a copy/paste >>> >> bug, but perhaps it is intentional. Can someone please explain? >> >> >> >> 1097 vfsp->vfs_dev = nfs_dev; >> 1098 vfs_make_fsid(&vfsp->vfs_fsid, nfs_dev, nfs3fstyp); >> 1099 vfsp->vfs_data = (caddr_t)mi; >> 1100 vfsp->vfs_fstype = nfsfstyp; >> >> >> >> The complete code can be browsed at: >> >> http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/uts/common/fs/nfs/nfs3_vfsops.c#1098 >> > > The file system type is always NFS no matter which version of the > protocol we're using.. > > A wee comment would be good to add there maybe ;-) > > Robert. > ___ > nfs-discuss mailing list > nfs-discuss at opensolaris.org >
[nfs-discuss] mixed use of nfs3fstyp and nfsfstyp in nfs3_vfsops.c
On Aug 14, 2008, at 4:56 PM, Piyush Shivam wrote: > Hi, > > In the following code snippet from nfs3_vfsops.c in nfs3rootvp > function, I notice that vfs_make_fsid uses nfs3fstyp, whereas vfsp- > >vfs_fstype uses nfsfstype. At first glance it appears a copy/paste > bug, but perhaps it is intentional. Can someone please explain? > > > > 1097 vfsp->vfs_dev = nfs_dev; > 1098 vfs_make_fsid(&vfsp->vfs_fsid, nfs_dev, nfs3fstyp); > 1099 vfsp->vfs_data = (caddr_t)mi; > 1100 vfsp->vfs_fstype = nfsfstyp; > > > > The complete code can be browsed at: > > http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/uts/common/fs/nfs/nfs3_vfsops.c#1098 The file system type is always NFS no matter which version of the protocol we're using.. A wee comment would be good to add there maybe ;-) Robert.
