Re: [Nfs-ganesha-devel] Bind_addr in nfs-ganesha - Multiple addresses for...

2015-06-22 Thread Frank Filz
It's been a while since I worked on that part of the code. I'm not quite sure why the config parsing was changed from using inet_pton to getaddrinfo, probably to be more flexible with what form the option string can take. It really should just take the first result, or look for the

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: FSAL_HPSS: brings FSAL back from its ashes.

2015-06-22 Thread GerritHub
From Dominique Martinet dominique.marti...@cea.fr: Hello Philippe DENIEL, I'd like you to do a code review. Please visit https://review.gerrithub.io/237196 to review the following change. Change subject: FSAL_HPSS: brings FSAL back from its ashes.

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: CMake: fix SHOOK build with prefix/lustre v2.4+

2015-06-22 Thread GerritHub
From Dominique Martinet dominique.marti...@cea.fr: Dominique Martinet has uploaded a new change for review. https://review.gerrithub.io/237177 Change subject: CMake: fix SHOOK build with prefix/lustre v2.4+ .. CMake: fix

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: CMake: fix condition for proxy handle mapping

2015-06-22 Thread GerritHub
From Dominique Martinet dominique.marti...@cea.fr: Dominique Martinet has uploaded a new change for review. https://review.gerrithub.io/237176 Change subject: CMake: fix condition for proxy handle mapping .. CMake: fix

Re: [Nfs-ganesha-devel] clnt_vc_geterr() accessing freed memory

2015-06-22 Thread Matt W. Benjamin
Hi, So this is all happening in clnt_vc_call()? I'll have a look at it. Matt - Malahal Naineni mala...@us.ibm.com wrote: Hi All, valgrind reported that clnt_vc_geterr() is accessing freed memory. Code review shows that nlm_send_async() calls clnt_call() and then calls

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Teach valgrind about GPFS fsal ioctls.

2015-06-22 Thread GerritHub
From Malahal mala...@gmail.com: Malahal has uploaded a new change for review. https://review.gerrithub.io/237285 Change subject: Teach valgrind about GPFS fsal ioctls. .. Teach valgrind about GPFS fsal ioctls. Instead of

Re: [Nfs-ganesha-devel] Gerrithub and editing - Please don't use

2015-06-22 Thread Dominique Martinet
Malahal Naineni wrote on Fri, Jun 19, 2015 at 05:18:59PM -0500: William Allen Simpson [william.allen.simp...@gmail.com] wrote: # I'm sorry, but I do not want commits that do not build -- I don't use bisect often, but when I do I like it to work without relying on luck finding commits that

[Nfs-ganesha-devel] clnt_vc_geterr() accessing freed memory

2015-06-22 Thread Malahal Naineni
Hi All, valgrind reported that clnt_vc_geterr() is accessing freed memory. Code review shows that nlm_send_async() calls clnt_call() and then calls clnt_sperror() on some errors. This is clearly a bug to access rpc context memory that was freed in a prior call. I am not familiar with RPC

[Nfs-ganesha-devel] V2.3-dev-8 Coverity status

2015-06-22 Thread SAUNIER, FREDERIC
Hi, This week, coverity analysis reports 4 eliminated defects and 1 new (actually false positive) Analysis summary report: Files analyzed : 485 Total LoC input to cov-analyze : 189597 Functions analyzed : 4540 Paths analyzed