Re: [Nfs-ganesha-devel] V2.6 WRT14

2017-09-06 Thread William Allen Simpson
I think we're good here. I worked back to git checkout 81fbc56, and that's exactly the problem that I've fixed, where flags wasn't initialized in 1 of 3 code paths: if (xd->sx_fbtbc || (flags & UIO_FLAG_MORE)) { On 9/5/17 8:53 AM, Daniel Gryniewicz wrote: Can you pinpoint the line in your code

Re: [Nfs-ganesha-devel] V2.6 WRT14

2017-09-05 Thread Daniel Gryniewicz
Can you pinpoint the line in your code? In mine, it's a warnx, and the only jump should be using initialized data. Daniel On 09/01/2017 03:39 PM, Malahal Naineni wrote: Hopefully, it fixes this valgrind warning I just got: ==17120== Thread 13: ==17120== Conditional jump or move depends on un

Re: [Nfs-ganesha-devel] V2.6 WRT14

2017-09-01 Thread Malahal Naineni
Hopefully, it fixes this valgrind warning I just got: ==17120== Thread 13: ==17120== Conditional jump or move depends on uninitialised value(s) ==17120==at 0x6886A15: svc_vc_recv (svc_vc.c:745) ==17120==by 0x6883573: svc_rqst_xprt_task (svc_rqst.c:683) ==17120==by 0x68839F3: svc_rqst_e

Re: [Nfs-ganesha-devel] V2.6 WRT14

2017-09-01 Thread Daniel Gryniewicz
On 09/01/2017 07:09 AM, William Allen Simpson wrote: On 8/30/17 1:34 PM, William Allen Simpson wrote: On 8/28/17 1:23 AM, Frank Filz wrote: WRT14 is the test that failed that made me kick Bill’s patch out of dev.5, then I couldn’t get it to fail again, so I included the patch in dev.6. Sinc

[Nfs-ganesha-devel] V2.6 WRT14

2017-09-01 Thread William Allen Simpson
On 8/30/17 1:34 PM, William Allen Simpson wrote: On 8/28/17 1:23 AM, Frank Filz wrote: WRT14 is the test that failed that made me kick Bill’s patch out of dev.5, then I couldn’t get it to fail again, so I included the patch in dev.6. Since it turned out not to be a dev.5 issue.  Malahal is re