Re: [Nfs-ganesha-devel] ganesha config editor user interface thoughts

2017-03-06 Thread Malahal Naineni
ation by Tag, on the other hand, > with the new config to use Pseudo, I’d love to deprecate Tag. > > > > Frank > > > > *From:* Malahal Naineni [mailto:mala...@gmail.com] > *Sent:* Monday, March 6, 2017 5:08 AM > *To:* d...@redhat.com > *Cc:* nfs-ganesha-devel@lists.

Re: [Nfs-ganesha-devel] ganesha config editor user interface thoughts

2017-03-06 Thread Malahal Naineni
Yes, it makes sense while creating for sure. Someone needs to remember the exportid while changing an entry that was created before. So I added exportid and pseudo for now. We can add anything later. "export export_id 14" and "export pseudo /root/exp1" are valid specifications now On Mar 6,

Re: [Nfs-ganesha-devel] ganesha config editor user interface thoughts

2017-03-06 Thread Daniel Gryniewicz
Isn't export_id the only actual always-required unique key? Maybe just use that? Daniel On 03/05/2017 11:39 PM, Malahal Naineni wrote: > Posted a patch that works at gerritio. It just creats blocks and key > value pairs without checking if they constitute a valid ganesha config > block.

Re: [Nfs-ganesha-devel] ganesha config editor user interface thoughts

2017-02-27 Thread Dominique Martinet
Malahal Naineni wrote on Sat, Feb 25, 2017 at 03:33:17PM +0530: > - All config is in blocks > - Most blocks are unique with their tag names > - exceptions: "export" and "client" blocks. > - "export" is unique by "path" value More like unique by pseudo path; path can be identical for various

Re: [Nfs-ganesha-devel] ganesha config editor user interface thoughts

2017-02-27 Thread Malahal Naineni
Based on Sriram's options idea: "ganesha_config set blocknames [sub-blocknames] --parameter value" will created block/subblocks if doesn't exist and will add the given parameter values inside the block. For example, "ganesha_config set NFS_CORE_PARAM --MNT_port " will create nfs_core_param

Re: [Nfs-ganesha-devel] ganesha config editor user interface thoughts

2017-02-26 Thread sriram patil
Hi Malahal, Can we have the key value pairs as options to the commands? For example, ganesha_config add export path --pseudo --protocols 4 --access RW --exportid 30 This way the block can be setup in a single command. Also, one does not have to worry about the exact key and cases (like

Re: [Nfs-ganesha-devel] ganesha config editor user interface thoughts

2017-02-25 Thread Frank Filz
There are Sind empty blocks such as log components can be empty. Sent from my iPhone > On Feb 25, 2017, at 7:20 PM, Malahal Naineni wrote: > > Assuming that there is no point in creating empty blocks, then we can > just have "set" and "del" commands. The "set" command's