Re: [Nfs-ganesha-devel] MDC up call

2016-08-23 Thread Soumya Koduri
On 08/23/2016 08:19 PM, Daniel Gryniewicz wrote: > Hi, Soumya. > > I've updated the PR. Can you test again? It does work now. Thanks, Soumya > > On Tue, Aug 23, 2016 at 10:24 AM, Daniel Gryniewicz wrote: >> Thanks. I'll look at it. >> >> Daniel >> >> On Tue, Aug 23, 2016 at 8:51 AM, Soumya

Re: [Nfs-ganesha-devel] MDC up call

2016-08-23 Thread Daniel Gryniewicz
Hi, Soumya. I've updated the PR. Can you test again? On Tue, Aug 23, 2016 at 10:24 AM, Daniel Gryniewicz wrote: > Thanks. I'll look at it. > > Daniel > > On Tue, Aug 23, 2016 at 8:51 AM, Soumya Koduri wrote: >> Hi Dan, >> >> On 08/22/2016 05:40 PM, Daniel Gryniewicz wrote: >>> >>> Excellent M

Re: [Nfs-ganesha-devel] MDC up call

2016-08-23 Thread Daniel Gryniewicz
Thanks. I'll look at it. Daniel On Tue, Aug 23, 2016 at 8:51 AM, Soumya Koduri wrote: > Hi Dan, > > On 08/22/2016 05:40 PM, Daniel Gryniewicz wrote: >> >> Excellent Marc, thanks. >> >> Soumya, could you test this with the Gluster up-calls to make sure I >> didn't break them? > > > I hit below c

Re: [Nfs-ganesha-devel] MDC up call

2016-08-23 Thread Soumya Koduri
Hi Dan, On 08/22/2016 05:40 PM, Daniel Gryniewicz wrote: > Excellent Marc, thanks. > > Soumya, could you test this with the Gluster up-calls to make sure I > didn't break them? I hit below crash when tested with the latest patchset - Program received signal SIGSEGV, Segmentation fault. [Switchin

Re: [Nfs-ganesha-devel] MDC up call

2016-08-22 Thread Daniel Gryniewicz
Excellent Marc, thanks. Soumya, could you test this with the Gluster up-calls to make sure I didn't break them? Thanks, Daniel On Sun, Aug 21, 2016 at 8:07 PM, Marc Eshel wrote: > This time it did work. > Marc. > > > > From: Daniel Gryniewicz > To: Marc Eshel/Almaden/IBM@IBMUS > Cc:

Re: [Nfs-ganesha-devel] MDC up call

2016-08-21 Thread Marc Eshel
This time it did work. Marc. From: Daniel Gryniewicz To: Marc Eshel/Almaden/IBM@IBMUS Cc: Frank Filz , NFS Ganesha Developers Date: 08/21/2016 02:45 PM Subject:Re: MDC up call In general, MDCACHE assumes it has op_ctx set, and I'd prefer to not have that assumption viol

Re: [Nfs-ganesha-devel] MDC up call

2016-08-21 Thread Daniel Gryniewicz
In general, MDCACHE assumes it has op_ctx set, and I'd prefer to not have that assumption violated, as it will complicate the code a lot. It appears that the export passed into the upcalls is already the MDCACHE export, not the sub-export. I've uploaded a new version of the patch with that change

Re: [Nfs-ganesha-devel] MDC up call

2016-08-19 Thread Marc Eshel
I am not sure you need to set op_ctx I fixed it for this path by not calling mdc_check_mapping() from mdcache_find_keyed() if op_ctx is NULL I think the mapping should already exist for calls that are coming from up-call. Marc. From: Daniel Gryniewicz To: Marc Eshel/Almaden/IBM@IBMUS

Re: [Nfs-ganesha-devel] MDC up call

2016-08-19 Thread Marc Eshel
Did not work sub_export looks bad. [New Thread 0x7f44dbfff700 (LWP 14104)] Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 0x7f44dbfff700 (LWP 14104)] 0x0052a711 in mdc_up_lock_avail (sub_export=0x956ff0, file=0x7f4524000958, owner=0x7f45201829f0, lock_param=0x7

Re: [Nfs-ganesha-devel] MDC up call

2016-08-19 Thread Daniel Gryniewicz
Marc, could you try with this patch: https://review.gerrithub.io/287904 Daniel On 08/18/2016 06:55 PM, Marc Eshel wrote: > Was up-call with MDC tested? > It looks like it is trying to use op_ctx which is NULL. > Marc. > > > Program received signal SIGSEGV, Segmentation fault. > [Switching to Thre

Re: [Nfs-ganesha-devel] MDC up call

2016-08-19 Thread Daniel Gryniewicz
Yes, UP was tested with Gluster, and I'd thought we'd caught all the callpaths, but apparently Gluster doesn't use lock_avail. I'll make a fix. Daniel On 08/18/2016 06:55 PM, Marc Eshel wrote: > Was up-call with MDC tested? > It looks like it is trying to use op_ctx which is NULL. > Marc. > > >