[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Get rid of unused cookie field in struct mdcache_populate_cb...
>From Frank Filz: Frank Filz has uploaded a new change for review. ( https://review.gerrithub.io/350076 Change subject: Get rid of unused cookie field in struct mdcache_populate_cb_state .. Get rid of unused cookie field in struct mdcache_populate_cb_state Change-Id: I1fd3ad4679bc7990f6d73bde19f6d9d30ba6f488 Signed-off-by: Frank S. Filz --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c 1 file changed, 0 insertions(+), 3 deletions(-) git pull ssh://review.gerrithub.io:29419/ffilz/nfs-ganesha refs/changes/76/350076/1 -- To view, visit https://review.gerrithub.io/350076 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1fd3ad4679bc7990f6d73bde19f6d9d30ba6f488 Gerrit-Change-Number: 350076 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Frank Filz -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Fix FSAL_PSEUDO to return the cookie for the NEXT entry for ...
>From Frank Filz: Frank Filz has uploaded a new change for review. ( https://review.gerrithub.io/350080 Change subject: Fix FSAL_PSEUDO to return the cookie for the NEXT entry for each dirent .. Fix FSAL_PSEUDO to return the cookie for the NEXT entry for each dirent The cookie associated with a dirent is the "address" of the NEXT dirent not the current one. Provide the appropriate cookie now that MDCACHE will actually be using the FSAL's cookies (this is relevant for bypassing the dirent cache also). Change-Id: I215cfe929d67c941bd5dc80e607ebc2f44150c49 Signed-off-by: Frank S. Filz --- M src/FSAL/FSAL_PSEUDO/handle.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29419/ffilz/nfs-ganesha refs/changes/80/350080/1 -- To view, visit https://review.gerrithub.io/350080 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I215cfe929d67c941bd5dc80e607ebc2f44150c49 Gerrit-Change-Number: 350080 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Frank Filz -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Add glist_last_entry
>From Frank Filz: Frank Filz has uploaded a new change for review. ( https://review.gerrithub.io/350079 Change subject: Add glist_last_entry .. Add glist_last_entry Change-Id: Id206255b2bffd558438981e267f1849bfae69597 Signed-off-by: Frank S. Filz --- M src/include/gsh_list.h 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29419/ffilz/nfs-ganesha refs/changes/79/350079/1 -- To view, visit https://review.gerrithub.io/350079 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id206255b2bffd558438981e267f1849bfae69597 Gerrit-Change-Number: 350079 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Frank Filz -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: WIP Add directory chunking for readdir.
>From Frank Filz: Frank Filz has uploaded a new change for review. ( https://review.gerrithub.io/350081 Change subject: WIP Add directory chunking for readdir. .. WIP Add directory chunking for readdir. This still needs directory invalidation on rename and create. Change-Id: Id4aa058bb5e96c26717234c42a4aa761bd80db67 Signed-off-by: Frank S. Filz --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_avl.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_avl.h M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_handle.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_int.h 5 files changed, 906 insertions(+), 34 deletions(-) git pull ssh://review.gerrithub.io:29419/ffilz/nfs-ganesha refs/changes/81/350081/1 -- To view, visit https://review.gerrithub.io/350081 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id4aa058bb5e96c26717234c42a4aa761bd80db67 Gerrit-Change-Number: 350081 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Frank Filz -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Remove PSEUDO directories on unexport
>From Daniel Gryniewicz: Daniel Gryniewicz has uploaded a new change for review. ( https://review.gerrithub.io/347972 Change subject: Remove PSEUDO directories on unexport .. Remove PSEUDO directories on unexport The mechanism to remove directories from PSEUDO when an export is removed was broken when MDCACHE was stacked on PSEUDO. Fix the check, to that those directories were removed. The symptom was that an export could still be mounted after it was unexported, although it's contents were not accessible. Change-Id: Id92e6d8809ac9dd49cdc405a2c6576fcc0c4642c Signed-off-by: Daniel Gryniewicz --- M src/Protocols/NFS/nfs4_pseudo.c 1 file changed, 26 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29419/ffilz/nfs-ganesha refs/changes/72/347972/1 -- To view, visit https://review.gerrithub.io/347972 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id92e6d8809ac9dd49cdc405a2c6576fcc0c4642c Gerrit-Change-Number: 347972 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Daniel Gryniewicz -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Use pseudopath instead of fullpath in NFS v4 situations
>From Frank Filz: Frank Filz has uploaded a new change for review. ( https://review.gerrithub.io/348516 Change subject: Use pseudopath instead of fullpath in NFS v4 situations .. Use pseudopath instead of fullpath in NFS v4 situations Change-Id: Id48f733e0b49ad0f6ab6d7f9193c12799f25c24b Signed-off-by: Frank S. Filz --- M src/Protocols/NFS/nfs4_op_lookup.c M src/Protocols/NFS/nfs4_op_lookupp.c M src/Protocols/NFS/nfs4_op_readdir.c M src/Protocols/NFS/nfs4_op_secinfo.c M src/SAL/nfs4_state.c M src/support/exports.c M src/support/nfs_creds.c 7 files changed, 36 insertions(+), 36 deletions(-) git pull ssh://review.gerrithub.io:29419/ffilz/nfs-ganesha refs/changes/16/348516/1 -- To view, visit https://review.gerrithub.io/348516 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id48f733e0b49ad0f6ab6d7f9193c12799f25c24b Gerrit-Change-Number: 348516 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Frank Filz -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: When logging exports, use the appropriate fullpath or pseudo...
>From Frank Filz: Frank Filz has uploaded a new change for review. ( https://review.gerrithub.io/348517 Change subject: When logging exports, use the appropriate fullpath or pseudopath .. When logging exports, use the appropriate fullpath or pseudopath If the export is being logged for NFS V4, always use pseudopath, otherwise, use fullpath unless mount_path_pseudo config option is true. Change-Id: I81c20ad09a34d8c63994147f2a5341988ca14d31 Signed-off-by: Frank S. Filz --- M src/MainNFSD/nfs_worker_thread.c M src/SAL/state_lock.c M src/include/export_mgr.h M src/support/exports.c 4 files changed, 40 insertions(+), 25 deletions(-) git pull ssh://review.gerrithub.io:29419/ffilz/nfs-ganesha refs/changes/17/348517/1 -- To view, visit https://review.gerrithub.io/348517 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I81c20ad09a34d8c63994147f2a5341988ca14d31 Gerrit-Change-Number: 348517 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Frank Filz -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: [nlm_Test] Reference mioght be used un-initialized.
>From Swen Schillig: Swen Schillig has uploaded a new change for review. ( https://review.gerrithub.io/348794 Change subject: [nlm_Test] Reference mioght be used un-initialized. .. [nlm_Test] Reference mioght be used un-initialized. In function nlm4_Test, the state_owner_t variable "holder" might be dereferenced without being set. It must be initialized(NULL) first to detect that it isn't set. Change-Id: Ib76d8a2562f97c4cbf3ed4652b9c2e9a2449ec3d Signed-off-by: Swen Schillig --- M src/Protocols/NLM/nlm_Test.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29419/ffilz/nfs-ganesha refs/changes/94/348794/1 -- To view, visit https://review.gerrithub.io/348794 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib76d8a2562f97c4cbf3ed4652b9c2e9a2449ec3d Gerrit-Change-Number: 348794 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Swen Schillig -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: FSAL_PROXY (support_ex without state) : pxy_setattr2
>From Patrice LUCAS: Patrice LUCAS has uploaded a new change for review. ( https://review.gerrithub.io/348756 Change subject: FSAL_PROXY (support_ex without state) : pxy_setattr2 .. FSAL_PROXY (support_ex without state) : pxy_setattr2 Change-Id: I13b0a1799e42d605eeb5fe42404013c4449f93ae Signed-off-by: Patrice LUCAS --- M src/FSAL/FSAL_PROXY/handle.c 1 file changed, 55 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29419/ffilz/nfs-ganesha refs/changes/56/348756/1 -- To view, visit https://review.gerrithub.io/348756 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I13b0a1799e42d605eeb5fe42404013c4449f93ae Gerrit-Change-Number: 348756 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Patrice LUCAS -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Fixing a deadlock between reaper thread and setclientid
>From Sriram Patil: Sriram Patil has uploaded a new change for review. ( https://review.gerrithub.io/348712 Change subject: Fixing a deadlock between reaper thread and setclientid .. Fixing a deadlock between reaper thread and setclientid The setclientid op takes the lock on client_record->cr_mutex first, then it goes ahead and takes a read-write lock on the hash table partition as part of nfs_get_client_id or remove_unconfirmed_client_id. However, this order of taking locks is not maintained in reap_hash_table, called by reaper_run, which was causing the deadlock. Change-Id: Ibf66fac471cfea32c9af768a1ea6eb7f1c4847dc Signed-off-by: Sriram Patil --- M src/MainNFSD/nfs_reaper_thread.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29419/ffilz/nfs-ganesha refs/changes/12/348712/1 -- To view, visit https://review.gerrithub.io/348712 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibf66fac471cfea32c9af768a1ea6eb7f1c4847dc Gerrit-Change-Number: 348712 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Sriram Patil -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: FSAL_PROXY (support_ex without state) : pxy_close2
>From Patrice LUCAS: Patrice LUCAS has uploaded a new change for review. ( https://review.gerrithub.io/348446 Change subject: FSAL_PROXY (support_ex without state) : pxy_close2 .. FSAL_PROXY (support_ex without state) : pxy_close2 Change-Id: I9b6eef0a1c1f15f2a9471bb14bb75cee93a18673 Signed-off-by: Patrice LUCAS --- M src/FSAL/FSAL_PROXY/handle.c 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29419/ffilz/nfs-ganesha refs/changes/46/348446/1 -- To view, visit https://review.gerrithub.io/348446 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9b6eef0a1c1f15f2a9471bb14bb75cee93a18673 Gerrit-Change-Number: 348446 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Patrice LUCAS -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: FSAL_RGW: fix mount failure of nfs v3 on windows
>From Gui Hecheng: Gui Hecheng has uploaded a new change for review. ( https://review.gerrithub.io/347789 Change subject: FSAL_RGW: fix mount failure of nfs v3 on windows .. FSAL_RGW: fix mount failure of nfs v3 on windows When we tried to mount rgwfs on windows using nfsv3, it failed with a not found errcode 53: > mount \\\mybucket x:\ It is because win client pass a "/mybucket" for export dir, but ganesha is exporting the desired dir as "mybucket"(without slash) # showmount -e Export list for : mybucket (everyone) so ganesha could not serve. Here we export rgwfs with config "Path = mybucket". We shall fail to export if provided "Path = /mybucket", because FSAL_RGW directly pass "/mybucket" to librgw as parameter 'path', which will be digested as a bucket name by librgw. Actually librgw would like a relative path as a bucket name, then we could export with config "Path = /mybucket"(with slash) which will make nfs client succeed to mount on windows. Change-Id: I02c241b12d77a747e8b039c5ac3a0662351011c9 Signed-off-by: Gui Hecheng --- M src/FSAL/FSAL_RGW/export.c 1 file changed, 12 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29419/ffilz/nfs-ganesha refs/changes/89/347789/1 -- To view, visit https://review.gerrithub.io/347789 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I02c241b12d77a747e8b039c5ac3a0662351011c9 Gerrit-Change-Number: 347789 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Gui Hecheng -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: [commonlib.c] optimize blkid cache handling.
>From Swen Schillig: Swen Schillig has uploaded a new change for review. ( https://review.gerrithub.io/349027 Change subject: [commonlib.c] optimize blkid cache handling. .. [commonlib.c] optimize blkid cache handling. The blkdid cache was fetched and returned in different code locations making it difficult to track and handle its status. Change-Id: I14f05148d8578f2d1879f0997587ed41e3d42e90 Signed-off-by: Swen Schillig --- M src/FSAL/commonlib.c 1 file changed, 31 insertions(+), 45 deletions(-) git pull ssh://review.gerrithub.io:29419/ffilz/nfs-ganesha refs/changes/27/349027/1 -- To view, visit https://review.gerrithub.io/349027 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I14f05148d8578f2d1879f0997587ed41e3d42e90 Gerrit-Change-Number: 349027 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Swen Schillig -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: FSAL_PROXY (support_ex without state) : pxy_reopen2
>From Patrice LUCAS: Patrice LUCAS has uploaded a new change for review. ( https://review.gerrithub.io/349039 Change subject: FSAL_PROXY (support_ex without state) : pxy_reopen2 .. FSAL_PROXY (support_ex without state) : pxy_reopen2 Change-Id: I09861d444bdff6519dfe5e8efd33abc58a126f92 Signed-off-by: Patrice LUCAS --- M src/FSAL/FSAL_PROXY/handle.c 1 file changed, 65 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29419/ffilz/nfs-ganesha refs/changes/39/349039/1 -- To view, visit https://review.gerrithub.io/349039 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I09861d444bdff6519dfe5e8efd33abc58a126f92 Gerrit-Change-Number: 349039 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Patrice LUCAS -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Allow FSAL to determine if a user is superuser
>From Daniel Gryniewicz: Daniel Gryniewicz has uploaded a new change for review. ( https://review.gerrithub.io/349135 Change subject: Allow FSAL to determine if a user is superuser .. Allow FSAL to determine if a user is superuser Some systems have an alternative superuser, not just UID 0. Allow this by adding a is_superuser() method to the FSAL export that is passed credentials and determines if the user is superuser. By default, check the UID against 0. Change-Id: Id236ad29e044504bb277b7a114fbca3217093896 Signed-off-by: Daniel Gryniewicz --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_export.c M src/FSAL/Stackable_FSALs/FSAL_NULL/export.c M src/FSAL/access_check.c M src/FSAL/default_methods.c M src/FSAL/fsal_helper.c M src/include/fsal_api.h M src/support/nfs_creds.c 7 files changed, 86 insertions(+), 9 deletions(-) git pull ssh://review.gerrithub.io:29419/ffilz/nfs-ganesha refs/changes/35/349135/1 -- To view, visit https://review.gerrithub.io/349135 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id236ad29e044504bb277b7a114fbca3217093896 Gerrit-Change-Number: 349135 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Daniel Gryniewicz -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Remove unneeded NULL pointer check
>From Malahal: Malahal has uploaded a new change for review. ( https://review.gerrithub.io/349147 Change subject: Remove unneeded NULL pointer check .. Remove unneeded NULL pointer check Fixes coverity CID 156270 Change-Id: I44bd5c6b844a18190950eb45ed9fbb7df4d6e298 Signed-off-by: Malahal Naineni --- M src/FSAL/FSAL_GPFS/export.c 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29419/ffilz/nfs-ganesha refs/changes/47/349147/1 -- To view, visit https://review.gerrithub.io/349147 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I44bd5c6b844a18190950eb45ed9fbb7df4d6e298 Gerrit-Change-Number: 349147 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Malahal -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Pull up ntirpc #39
>From: william.allen.simp...@gmail.com has uploaded a new change for review. ( https://review.gerrithub.io/348814 Change subject: Pull up ntirpc #39 .. Pull up ntirpc #39 Change-Id: I41c54962e6dc2df803610b1aed70378433d57421 Signed-off-by: William Allen Simpson --- M src/libntirpc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29419/ffilz/nfs-ganesha refs/changes/14/348814/1 -- To view, visit https://review.gerrithub.io/348814 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I41c54962e6dc2df803610b1aed70378433d57421 Gerrit-Change-Number: 348814 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: william.allen.simp...@gmail.com -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: FSAL_PROXY (support_ex without state) : pxy_status2
>From Patrice LUCAS: Patrice LUCAS has uploaded a new change for review. ( https://review.gerrithub.io/348901 Change subject: FSAL_PROXY (support_ex without state) : pxy_status2 .. FSAL_PROXY (support_ex without state) : pxy_status2 Change-Id: I9411ae1a1939dad543b2fc9e4628d81f77a0b94a Signed-off-by: Patrice LUCAS --- M src/FSAL/FSAL_PROXY/handle.c 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29419/ffilz/nfs-ganesha refs/changes/01/348901/1 -- To view, visit https://review.gerrithub.io/348901 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9411ae1a1939dad543b2fc9e4628d81f77a0b94a Gerrit-Change-Number: 348901 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Patrice LUCAS -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Fix SSE4_2 compile path.
>From Dylan Reid: Dylan Reid has uploaded a new change for review. ( https://review.gerrithub.io/348971 Change subject: Fix SSE4_2 compile path. .. Fix SSE4_2 compile path. A semicolon has been missing from the "CHUNK" macro since it was reformatted. Change-Id: Ieb7d3b8166fda68bc8e15aec4a281c0af1019438 Signed-off-by: Dylan Reid --- M src/support/city.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29419/ffilz/nfs-ganesha refs/changes/71/348971/1 -- To view, visit https://review.gerrithub.io/348971 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ieb7d3b8166fda68bc8e15aec4a281c0af1019438 Gerrit-Change-Number: 348971 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Dylan Reid -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: WIP: Fix a race in nfs_dupreq_put_drc with nfs_dupreq_get_drc
>From Malahal: Malahal has uploaded a new change for review. ( https://review.gerrithub.io/343710 Change subject: WIP: Fix a race in nfs_dupreq_put_drc with nfs_dupreq_get_drc .. WIP: Fix a race in nfs_dupreq_put_drc with nfs_dupreq_get_drc When the drc refcount goes to zero, nfs_dupreq_put_drc() puts the drc into a recyle list. The list insertion and the flag bit DRC_FLAG_RECYCLE should be atomic. nfs_dupreq_put_drc() needs to recheck the flag after dropping the lock and re-acquiring it. Change-Id: I6081f4496e82f7b7c9ea79a0c58cbd3c91417e87 Signed-off-by: Malahal Naineni --- M src/RPCAL/nfs_dupreq.c 1 file changed, 31 insertions(+), 16 deletions(-) git pull ssh://review.gerrithub.io:29419/ffilz/nfs-ganesha refs/changes/10/343710/1 -- To view, visit https://review.gerrithub.io/343710 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6081f4496e82f7b7c9ea79a0c58cbd3c91417e87 Gerrit-Change-Number: 343710 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Malahal -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: [nfs_rpc_callback.c] Added missing mutex unlock, code improv...
>From Swen Schillig: Swen Schillig has uploaded a new change for review. ( https://review.gerrithub.io/343795 Change subject: [nfs_rpc_callback.c] Added missing mutex unlock, code improvements. .. [nfs_rpc_callback.c] Added missing mutex unlock, code improvements. Added missing unlock in function nfs_rpc_create_chan_v41. Removed unused code, removed magic numbers and added some more minor code cleanup. Change-Id: I70d461b99ffc26e0231457124942ca33db141676 Signed-off-by: Swen Schillig --- M src/MainNFSD/nfs_rpc_callback.c 1 file changed, 207 insertions(+), 252 deletions(-) git pull ssh://review.gerrithub.io:29419/ffilz/nfs-ganesha refs/changes/95/343795/1 -- To view, visit https://review.gerrithub.io/343795 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I70d461b99ffc26e0231457124942ca33db141676 Gerrit-Change-Number: 343795 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Swen Schillig -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Set max read/write size same as block size
>From: madhu.punj...@in.ibm.com has uploaded a new change for review. ( https://review.gerrithub.io/343476 Change subject: Set max read/write size same as block size .. Set max read/write size same as block size Different file systems can have different block sizes. Modified code to check if max read/write sizes are not configured for an export by the administrator, then get file system block size information and assign it to max read/write size parameters of the export. Change-Id: I7f956b21177ee6f1de69808feacaf12d79fe7042 Signed-off-by: Madhu Thorat --- M src/FSAL/FSAL_GPFS/export.c M src/config_parsing/config_parsing.c M src/include/config_parsing.h M src/include/fsal_types.h M src/include/nfs_exports.h M src/support/exports.c 6 files changed, 90 insertions(+), 9 deletions(-) git pull ssh://review.gerrithub.io:29419/ffilz/nfs-ganesha refs/changes/76/343476/1 -- To view, visit https://review.gerrithub.io/343476 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7f956b21177ee6f1de69808feacaf12d79fe7042 Gerrit-Change-Number: 343476 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: madhu.punj...@in.ibm.com -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: RPM - install RGW sample config
>From Daniel Gryniewicz: Daniel Gryniewicz has uploaded a new change for review. ( https://review.gerrithub.io/343470 Change subject: RPM - install RGW sample config .. RPM - install RGW sample config rpmbuild was failing creating RGW RPMs because the sample config was not being installed but was expected. Change-Id: I0b0b3b95811e9f6a8bf0fe86ccea1de5cc2e8c94 Signed-off-by: Daniel Gryniewicz --- M src/nfs-ganesha.spec-in.cmake 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29419/ffilz/nfs-ganesha refs/changes/70/343470/1 -- To view, visit https://review.gerrithub.io/343470 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0b0b3b95811e9f6a8bf0fe86ccea1de5cc2e8c94 Gerrit-Change-Number: 343470 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Daniel Gryniewicz -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: LTTng - Add tracepoints for v4 OPs
>From Daniel Gryniewicz: Daniel Gryniewicz has uploaded a new change for review. ( https://review.gerrithub.io/343468 Change subject: LTTng - Add tracepoints for v4 OPs .. LTTng - Add tracepoints for v4 OPs Add tracepoints for the start and end of v4 OPs. This allows op type tracing, and latency of ops. Change-Id: I18ca3f41f783b26e090fbe4a16a4984a16735929 Signed-off-by: Daniel Gryniewicz --- M src/Protocols/NFS/nfs4_Compound.c M src/include/gsh_lttng/nfs_rpc.h 2 files changed, 68 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29419/ffilz/nfs-ganesha refs/changes/68/343468/1 -- To view, visit https://review.gerrithub.io/343468 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I18ca3f41f783b26e090fbe4a16a4984a16735929 Gerrit-Change-Number: 343468 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Daniel Gryniewicz -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: [valgrind] Mem-leak: Free channel client memory.
>From Swen Schillig: Swen Schillig has uploaded a new change for review. ( https://review.gerrithub.io/343215 Change subject: [valgrind] Mem-leak: Free channel client memory. .. [valgrind] Mem-leak: Free channel client memory. Memory is not free'd due to calling the wrong CB (release vs destroy). ==11341== 2,364,219 (288 direct, 2,363,931 indirect) bytes in 3 blocks are definitely lost in loss record 347 of 355 ==11341==at 0x4C2BBAD: malloc (vg_replace_malloc.c:299) ==11341==by 0x44B611: gsh_malloc__ (abstract_mem.h:78) ==11341==by 0x6A8C2BB: clnt_vc_ncreate2 (clnt_vc.c:237) ==11341==by 0x6AA7129: clnt_vc_ncreate_svc (svc_vc.c:1292) ==11341==by 0x43C3DB: nfs_rpc_create_chan_v41 (nfs_rpc_callback.c:656) ==11341==by 0x461338: nfs4_op_create_session (nfs4_op_create_session.c:498) ==11341==by 0x45CC5A: nfs4_Compound (nfs4_Compound.c:734) ==11341==by 0x44A9D4: nfs_rpc_execute (nfs_worker_thread.c:1281) ==11341==by 0x44B296: worker_run (nfs_worker_thread.c:1548) ==11341==by 0x4FEE0E: fridgethr_start_routine (fridgethr.c:550) ==11341==by 0x665E5C9: start_thread (in /usr/lib64/libpthread-2.23.so) ==11341==by 0x6FE50EC: clone (in /usr/lib64/libc-2.23.so) Change-Id: I24fa3b5c31eb219304f6e723d6b30ede720dc2ef Signed-off-by: Swen Schillig --- M src/MainNFSD/nfs_rpc_callback.c 1 file changed, 7 insertions(+), 44 deletions(-) git pull ssh://review.gerrithub.io:29419/ffilz/nfs-ganesha refs/changes/15/343215/1 -- To view, visit https://review.gerrithub.io/343215 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I24fa3b5c31eb219304f6e723d6b30ede720dc2ef Gerrit-Change-Number: 343215 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Swen Schillig -- Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today. http://sdm.link/xeonphi___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: FSAL_GLUSTER: Avoid double free of handle in case of setattr...
>From Soumya: Soumya has uploaded a new change for review. ( https://review.gerrithub.io/343338 Change subject: FSAL_GLUSTER: Avoid double free of handle in case of setattr failures .. FSAL_GLUSTER: Avoid double free of handle in case of setattr failures Post any object creation, in case if setting attributes fail, we seem to be freeing glusterfs handle twice. Fixed the same. Change-Id: I917f1295a8f29612ccde8081c447135d6abb475c Signed-off-by: Soumya Koduri --- M src/FSAL/FSAL_GLUSTER/handle.c 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29419/ffilz/nfs-ganesha refs/changes/38/343338/1 -- To view, visit https://review.gerrithub.io/343338 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I917f1295a8f29612ccde8081c447135d6abb475c Gerrit-Change-Number: 343338 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Soumya -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Fix use-after-free in log message
>From Daniel Gryniewicz: Daniel Gryniewicz has uploaded a new change for review. ( https://review.gerrithub.io/343420 Change subject: Fix use-after-free in log message .. Fix use-after-free in log message dk, in this case, may be freed, if the request was already cached. dv should be the value used, as it's always valid. Fixes Coverity CID 155474 Change-Id: I180888a1c8d79be83128c123047e38152d7d2f22 Signed-off-by: Daniel Gryniewicz --- M src/RPCAL/nfs_dupreq.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29419/ffilz/nfs-ganesha refs/changes/20/343420/1 -- To view, visit https://review.gerrithub.io/343420 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I180888a1c8d79be83128c123047e38152d7d2f22 Gerrit-Change-Number: 343420 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Daniel Gryniewicz -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: packaging: python2 fixes
>From: ka...@redhat.com has uploaded a new change for review. ( https://review.gerrithub.io/343659 Change subject: packaging: python2 fixes .. packaging: python2 fixes Fedora, CentOS, RHEL support for python2 vs python3 Change-Id: I7877dc65adb7d860f3faeb7c65f9e60a27fe44d7 Signed-off-by: Kaleb S. KEITHLEY --- M src/nfs-ganesha.spec-in.cmake 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.gerrithub.io:29419/ffilz/nfs-ganesha refs/changes/59/343659/1 -- To view, visit https://review.gerrithub.io/343659 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7877dc65adb7d860f3faeb7c65f9e60a27fe44d7 Gerrit-Change-Number: 343659 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: ka...@redhat.com -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: nlm: avoid mutex initialization/destroy in assert
>From Soumya: Soumya has uploaded a new change for review. ( https://review.gerrithub.io/343613 Change subject: nlm: avoid mutex initialization/destroy in assert .. nlm: avoid mutex initialization/destroy in assert Since assert is processed only in debug builds, have updated with new macros for state_mutex initialization and destroy. (Note: Not sure if this mutex is used anywhere else in NLM code-path. But better to handle it.) Change-Id: Icf5481a1f74d9fce408beeb7b996ba118cf763d9 Signed-off-by: Soumya Koduri --- M src/SAL/nlm_state.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29419/ffilz/nfs-ganesha refs/changes/13/343613/1 -- To view, visit https://review.gerrithub.io/343613 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icf5481a1f74d9fce408beeb7b996ba118cf763d9 Gerrit-Change-Number: 343613 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Soumya -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Fix multiple threads handling the same drc with zero ref count
>From Malahal: Malahal has uploaded a new change for review. ( https://review.gerrithub.io/343980 Change subject: Fix multiple threads handling the same drc with zero ref count .. Fix multiple threads handling the same drc with zero ref count nfs_dupreq_put_drc() drops the locks after decrementing the ref count to zero. Imagine this thread not getting scheduled for a good amount of time. The nfs_dupreq_get_drc() may bump up the ref count and recycle the drc. The drc may eventually end up with zero ref count in another thread. At this point we have two threads that are handling the same drc with zero ref count. One thread may put it in the recycle list and the drc could be freed before the other thread tries to access the drc! This may lead to use after freed memory. The fix here is to wait in the nfs_dupreq_get_drc until the first thread puts the drc in the recycle queue. Change-Id: I4d88bd401a5f266b4f7d75bfbeda9b91a329629b Signed-off-by: Malahal Naineni --- M src/RPCAL/nfs_dupreq.c 1 file changed, 46 insertions(+), 9 deletions(-) git pull ssh://review.gerrithub.io:29419/ffilz/nfs-ganesha refs/changes/80/343980/1 -- To view, visit https://review.gerrithub.io/343980 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4d88bd401a5f266b4f7d75bfbeda9b91a329629b Gerrit-Change-Number: 343980 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Malahal -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Avoid both messages (hit and starting) when DRC cache is hit.
>From Malahal: Malahal has uploaded a new change for review. ( https://review.gerrithub.io/343978 Change subject: Avoid both messages (hit and starting) when DRC cache is hit. .. Avoid both messages (hit and starting) when DRC cache is hit. Moved the "starting" message to log only for new entries. Change-Id: Iac0d946bef078f532e62efa915fc2be086f3c3ef Signed-off-by: Malahal Naineni --- M src/RPCAL/nfs_dupreq.c 1 file changed, 9 insertions(+), 8 deletions(-) git pull ssh://review.gerrithub.io:29419/ffilz/nfs-ganesha refs/changes/78/343978/1 -- To view, visit https://review.gerrithub.io/343978 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iac0d946bef078f532e62efa915fc2be086f3c3ef Gerrit-Change-Number: 343978 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Malahal -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Set key len.
>From: es...@us.ibm.com has uploaded a new change for review. https://review.gerrithub.io/288016 Change subject: Set key len. .. Set key len. Change-Id: I5b932aaf90a97abf5306c1934b2ffb816378fec2 Signed-off-by: Marc Eshel --- M src/SAL/nlm_state.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/16/288016/1 -- To view, visit https://review.gerrithub.io/288016 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5b932aaf90a97abf5306c1934b2ffb816378fec2 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: es...@us.ibm.com -- ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Add auto expiration of netgroup cache entries
>From Malahal: Malahal has uploaded a new change for review. https://review.gerrithub.io/287829 Change subject: Add auto expiration of netgroup cache entries .. Add auto expiration of netgroup cache entries Netgroups cache entry auto expires after 30 minutes. This will make a cache entry in sync with the NIS server at least after 30 minutes. Change-Id: I16279b44dadd33ea6a7673d426a725b579186bbd Signed-off-by: Malahal Naineni --- M src/support/netgroup_cache.c 1 file changed, 47 insertions(+), 4 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/29/287829/1 -- To view, visit https://review.gerrithub.io/287829 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I16279b44dadd33ea6a7673d426a725b579186bbd Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Malahal -- ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Add cache for netgroup innetgr() calls
>From Malahal: Malahal has uploaded a new change for review. https://review.gerrithub.io/287828 Change subject: Add cache for netgroup innetgr() calls .. Add cache for netgroup innetgr() calls Under some complex deep nested netgroup configurations, the innetgr() call takes more than half a second. This makes ganesha not usable. Cache innetgr results (positive and negative). Change-Id: I0a688edbb592a9dbdaeeac9827b63ed5155cae9a Signed-off-by: Malahal Naineni --- M src/CMakeLists.txt M src/MainNFSD/nfs_init.c A src/include/netgroup_cache.h M src/support/CMakeLists.txt M src/support/exports.c A src/support/netgroup_cache.c 6 files changed, 310 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/28/287828/1 -- To view, visit https://review.gerrithub.io/287828 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0a688edbb592a9dbdaeeac9827b63ed5155cae9a Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Malahal -- ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: MDCACHE - wrap all UP ops to ensure op_ctx is set
>From Daniel Gryniewicz: Daniel Gryniewicz has uploaded a new change for review. https://review.gerrithub.io/287904 Change subject: MDCACHE - wrap all UP ops to ensure op_ctx is set .. MDCACHE - wrap all UP ops to ensure op_ctx is set Any UP op that can call into MDCACHE must have an op_ctx set, since MDCACHE needs op_ctx at all times. Wrap all UP calls, setting op_ctx. Any calls not consumed are passed along to the upper layer. Change-Id: Ibc6acd9384d4cf80171c7e76f6e794ece501a876 Signed-off-by: Daniel Gryniewicz --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_export.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_int.h M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_main.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_up.c 4 files changed, 147 insertions(+), 4 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/04/287904/1 -- To view, visit https://review.gerrithub.io/287904 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibc6acd9384d4cf80171c7e76f6e794ece501a876 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Daniel Gryniewicz -- ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: If the return from atomic_inc or atomic_dec unused (void) call
>From Frank Filz: Frank Filz has uploaded a new change for review. https://review.gerrithub.io/287713 Change subject: If the return from atomic_inc or atomic_dec unused (void) call .. If the return from atomic_inc or atomic_dec unused (void) call This provides consistency and fixes CID 144636 (Unchecked return value). Change-Id: I0f66017c123d114f7b6c61aa8638065453de3b75 Signed-off-by: Frank S. Filz --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_lru.c M src/FSAL/fsal_helper.c M src/MainNFSD/9p_dispatcher.c M src/MainNFSD/nfs_rpc_dispatcher_thread.c M src/MainNFSD/nfs_worker_thread.c M src/Protocols/9P/9p_proto_tools.c M src/Protocols/NLM/nlm_Lock.c M src/SAL/nlm_owner.c M src/SAL/state_share.c M src/include/export_mgr.h M src/include/fsal.h M src/include/fsal_api.h M src/include/gsh_rpc.h M src/include/pnfs_utils.h M src/include/sal_functions.h M src/support/exports.c 16 files changed, 28 insertions(+), 28 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/13/287713/1 -- To view, visit https://review.gerrithub.io/287713 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0f66017c123d114f7b6c61aa8638065453de3b75 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Frank Filz -- ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: multilock: Revamp to use correct buffer sizes
>From Frank Filz: Frank Filz has uploaded a new change for review. https://review.gerrithub.io/287715 Change subject: multilock: Revamp to use correct buffer sizes .. multilock: Revamp to use correct buffer sizes Fixes a host of Coverity issues. Change-Id: I905e68753116b891cb4a95a5e45a6dbd6a972090 Signed-off-by: Frank S. Filz --- M src/tools/multilock/README M src/tools/multilock/ml_cephfs_client.c M src/tools/multilock/ml_console.c M src/tools/multilock/ml_functions.c M src/tools/multilock/ml_posix_client.c M src/tools/multilock/multilock.h 6 files changed, 490 insertions(+), 403 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/15/287715/1 -- To view, visit https://review.gerrithub.io/287715 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I905e68753116b891cb4a95a5e45a6dbd6a972090 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Frank Filz -- ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Simplify nfs_admin_thread.c signalling
>From Frank Filz: Frank Filz has uploaded a new change for review. https://review.gerrithub.io/287712 Change subject: Simplify nfs_admin_thread.c signalling .. Simplify nfs_admin_thread.c signalling Fixes CID 132617 Change-Id: I708def3daa032abc25ea57d2520166455609539d Signed-off-by: Frank S. Filz --- M src/MainNFSD/nfs_admin_thread.c 1 file changed, 20 insertions(+), 57 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/12/287712/1 -- To view, visit https://review.gerrithub.io/287712 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I708def3daa032abc25ea57d2520166455609539d Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Frank Filz -- ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: nfs-ganesha.spec: need selinux tools for minimalist installs
>From: ka...@redhat.com has uploaded a new change for review. ( https://review.gerrithub.io/350953 Change subject: nfs-ganesha.spec: need selinux tools for minimalist installs .. nfs-ganesha.spec: need selinux tools for minimalist installs See https://bugzilla.redhat.com/show_bug.cgi?id=1425014 RHEL and Fedora usually come with selinux tools by default, however there are ways to install the OS such that the selinux tools aren't provided. For these situations an added Requires: will ensure that the selinux tools are installed as part of installing nfs-ganesha. Change-Id: Iacd339c684b0c09146f27899f34b2e2adb13f029 Signed-off-by: Kaleb S. KEITHLEY --- M src/nfs-ganesha.spec-in.cmake 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29419/ffilz/nfs-ganesha refs/changes/53/350953/1 -- To view, visit https://review.gerrithub.io/350953 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iacd339c684b0c09146f27899f34b2e2adb13f029 Gerrit-Change-Number: 350953 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: ka...@redhat.com -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Prevent endless recusion when GPFS device open fails.
>From Malahal: Malahal has uploaded a new change for review. ( https://review.gerrithub.io/351048 Change subject: Prevent endless recusion when GPFS device open fails. .. Prevent endless recusion when GPFS device open fails. LogFatal ends up calling gpfs_ganesha() if fsal_trace is enabled. Change-Id: I523a21c15c0967bf9a5b30d3ef5d3cf2a847f304 Signed-off-by: Malahal Naineni --- M src/FSAL/FSAL_GPFS/gpfsext.c 1 file changed, 16 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29419/ffilz/nfs-ganesha refs/changes/48/351048/1 -- To view, visit https://review.gerrithub.io/351048 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I523a21c15c0967bf9a5b30d3ef5d3cf2a847f304 Gerrit-Change-Number: 351048 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Malahal -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: gpfs: Add EINTR error check to upcall thread
>From Malahal: Malahal has uploaded a new change for review. ( https://review.gerrithub.io/351049 Change subject: gpfs: Add EINTR error check to upcall thread .. gpfs: Add EINTR error check to upcall thread EINTR is returned for an interrupted syscall and should not generate a Crit message. Change-Id: I7dcde0a0759a2e95b01383759db6ab4afb1d475b Signed-off-by: Malahal Naineni --- M src/FSAL/FSAL_GPFS/fsal_up.c 1 file changed, 13 insertions(+), 10 deletions(-) git pull ssh://review.gerrithub.io:29419/ffilz/nfs-ganesha refs/changes/49/351049/1 -- To view, visit https://review.gerrithub.io/351049 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7dcde0a0759a2e95b01383759db6ab4afb1d475b Gerrit-Change-Number: 351049 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Malahal -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Fix the log message
>From: supriti.si...@suse.com has uploaded a new change for review. ( https://review.gerrithub.io/350650 Change subject: Fix the log message .. Fix the log message Change-Id: Ibf0f62fea91deacb4d1f70d28963a34baf129ec2 Signed-off-by: Supriti Singh --- M src/MainNFSD/nfs_init.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29419/ffilz/nfs-ganesha refs/changes/50/350650/1 -- To view, visit https://review.gerrithub.io/350650 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibf0f62fea91deacb4d1f70d28963a34baf129ec2 Gerrit-Change-Number: 350650 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: supriti.si...@suse.com -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: 9p proto tools/clunk: check setextattr success
>From Dominique Martinet: Dominique Martinet has uploaded a new change for review. https://review.gerrithub.io/288593 Change subject: 9p proto tools/clunk: check setextattr success .. 9p proto tools/clunk: check setextattr success Fix coverity CID144646 Change-Id: Ic2199551d9533bfc971006d7291226a46f20501b Signed-off-by: Dominique Martinet --- M src/Protocols/9P/9p_proto_tools.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/93/288593/1 -- To view, visit https://review.gerrithub.io/288593 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic2199551d9533bfc971006d7291226a46f20501b Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Dominique Martinet -- ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: log: avoid truncation in display_buffer_len
>From Matt Benjamin: Matt Benjamin has uploaded a new change for review. https://review.gerrithub.io/288803 Change subject: log: avoid truncation in display_buffer_len .. log: avoid truncation in display_buffer_len I suspect that we were ambivalent about whether a display buffer should really use size_t for length, but since it does, use size_t to return its length. Change-Id: Ia2ba15229538f5541511a63fade31e7120b46031 Signed-off-by: Matt Benjamin --- M src/include/display.h 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/03/288803/1 -- To view, visit https://review.gerrithub.io/288803 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia2ba15229538f5541511a63fade31e7120b46031 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Matt Benjamin -- ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: testing: Fsalcore, nfs_libmain dup conf
>From Matt Benjamin: Matt Benjamin has uploaded a new change for review. https://review.gerrithub.io/288798 Change subject: testing: Fsalcore, nfs_libmain dup conf .. testing: Fsalcore, nfs_libmain dup conf Introduces a static FsalCore library, used to link external programs (e.g., gtest drivers) with the full server internals. Change-Id: I8dcd29d6d714eb4cd952e3cbc546f52ec61da731 Signed-off-by: Matt Benjamin --- M src/CMakeLists.txt M src/MainNFSD/CMakeLists.txt M src/MainNFSD/nfs_lib.c M src/gtest/CMakeLists.txt 4 files changed, 15 insertions(+), 9 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/98/288798/1 -- To view, visit https://review.gerrithub.io/288798 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8dcd29d6d714eb4cd952e3cbc546f52ec61da731 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Matt Benjamin -- ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: wait_queue.h: avoid narrowing cast
>From Matt Benjamin: Matt Benjamin has uploaded a new change for review. https://review.gerrithub.io/288807 Change subject: wait_queue.h: avoid narrowing cast .. wait_queue.h: avoid narrowing cast I don't really like putting time_t in the signature, but that's how struct timespec is defined. Change-Id: I75db16e8c84278fcfdd83902026185c6b3af0f35 Signed-off-by: Matt Benjamin --- M src/include/wait_queue.h 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/07/288807/1 -- To view, visit https://review.gerrithub.io/288807 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I75db16e8c84278fcfdd83902026185c6b3af0f35 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Matt Benjamin -- ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: testing: s/-std=c++14/-std=gnu++14/ to enable typeof
>From Matt Benjamin: Matt Benjamin has uploaded a new change for review. https://review.gerrithub.io/288802 Change subject: testing: s/-std=c++14/-std=gnu++14/ to enable typeof .. testing: s/-std=c++14/-std=gnu++14/ to enable typeof Change-Id: I914c4f25ab81b23ad9ef4b35117b384ad8b75833 Signed-off-by: Matt Benjamin --- M src/gtest/CMakeLists.txt 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/02/288802/1 -- To view, visit https://review.gerrithub.io/288802 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I914c4f25ab81b23ad9ef4b35117b384ad8b75833 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Matt Benjamin -- ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: ntirpc pullup: take c++ warning fixes
>From Matt Benjamin: Matt Benjamin has uploaded a new change for review. https://review.gerrithub.io/288789 Change subject: ntirpc pullup: take c++ warning fixes .. ntirpc pullup: take c++ warning fixes Change-Id: I7a5bc53603a1e96eb490d0995bbca50e75482411 Signed-off-by: Matt Benjamin --- M src/libntirpc 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/89/288789/1 -- To view, visit https://review.gerrithub.io/288789 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7a5bc53603a1e96eb490d0995bbca50e75482411 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Matt Benjamin -- ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: testing: add nfs_libmain, program_options
>From Matt Benjamin: Matt Benjamin has uploaded a new change for review. https://review.gerrithub.io/288797 Change subject: testing: add nfs_libmain, program_options .. testing: add nfs_libmain, program_options * Add to nfs_libmain() arguments. * Add support for boost::program_options Change-Id: I6735e8b12bcbab4c674454350e7fd5584311e741 Signed-off-by: Matt Benjamin --- M src/MainNFSD/nfs_lib.c M src/gtest/CMakeLists.txt A src/include/nfs_lib.h 3 files changed, 43 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/97/288797/1 -- To view, visit https://review.gerrithub.io/288797 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6735e8b12bcbab4c674454350e7fd5584311e741 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Matt Benjamin -- ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: nfs init: factor malloc check into nfs_check_malloc()
>From Matt Benjamin: Matt Benjamin has uploaded a new change for review. https://review.gerrithub.io/288791 Change subject: nfs init: factor malloc check into nfs_check_malloc() .. nfs init: factor malloc check into nfs_check_malloc() Change-Id: I05955ef2f2aae904f1110345dc7fa0040f711bd5 Signed-off-by: Matt Benjamin --- M src/MainNFSD/nfs_init.h M src/MainNFSD/nfs_lib.c M src/MainNFSD/nfs_main.c 3 files changed, 27 insertions(+), 16 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/91/288791/1 -- To view, visit https://review.gerrithub.io/288791 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I05955ef2f2aae904f1110345dc7fa0040f711bd5 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Matt Benjamin -- ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Log: Constness
>From Matt Benjamin: Matt Benjamin has uploaded a new change for review. https://review.gerrithub.io/288805 Change subject: Log: Constness .. Log: Constness Update the signatures of the various logging functions to take const char*. Remove writable strings warning in ISO C++. Change-Id: Idf8e57cdc14ffbf92a29945d910243d83f74c5af Signed-off-by: Matt Benjamin --- M src/Protocols/NLM/sm_notify.c M src/include/log.h M src/log/log_functions.c 3 files changed, 55 insertions(+), 54 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/05/288805/1 -- To view, visit https://review.gerrithub.io/288805 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Idf8e57cdc14ffbf92a29945d910243d83f74c5af Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Matt Benjamin -- ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: testing: add nfs_lib.c
>From Matt Benjamin: Matt Benjamin has uploaded a new change for review. https://review.gerrithub.io/288790 Change subject: testing: add nfs_lib.c .. testing: add nfs_lib.c Provides nfs_libmain(void), a stripped down version of the current Ganesha main(). The idea is to call this routine (which as it calls nfs_start() will not soon return) from one thread of a threaded program, other threads could be used to interact with the in-process Ganesha. Change-Id: Ib8a8df6485bcc6c938b76582c30a65ee924fda5e Signed-off-by: Matt Benjamin --- M src/MainNFSD/CMakeLists.txt A src/MainNFSD/nfs_lib.c 2 files changed, 236 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/90/288790/1 -- To view, visit https://review.gerrithub.io/288790 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib8a8df6485bcc6c938b76582c30a65ee924fda5e Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Matt Benjamin -- ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: testing: add missing src/gtest/CMakeLists.txt
>From Matt Benjamin: Matt Benjamin has uploaded a new change for review. https://review.gerrithub.io/288794 Change subject: testing: add missing src/gtest/CMakeLists.txt .. testing: add missing src/gtest/CMakeLists.txt Change-Id: Idc3424cf048b9e535936dc5b9148409e3bdfd966 Signed-off-by: Matt Benjamin --- A src/gtest/CMakeLists.txt 1 file changed, 40 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/94/288794/1 -- To view, visit https://review.gerrithub.io/288794 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Idc3424cf048b9e535936dc5b9148409e3bdfd966 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Matt Benjamin -- ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: fsal.h: fix binding in *createmode_to_fsal
>From Matt Benjamin: Matt Benjamin has uploaded a new change for review. https://review.gerrithub.io/288813 Change subject: fsal.h: fix binding in *createmode_to_fsal .. fsal.h: fix binding in *createmode_to_fsal Change-Id: I3a39a580f2e120d13fa89aca38dc82a465818472 Signed-off-by: Matt Benjamin --- M src/include/fsal.h 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/13/288813/1 -- To view, visit https://review.gerrithub.io/288813 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3a39a580f2e120d13fa89aca38dc82a465818472 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Matt Benjamin -- ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: fsal_up: s/export/up_export/;
>From Matt Benjamin: Matt Benjamin has uploaded a new change for review. https://review.gerrithub.io/288811 Change subject: fsal_up: s/export/up_export/; .. fsal_up: s/export/up_export/; Change-Id: I52ca4b11b780d675dc54a0ad08ce4b50ea9df404 Signed-off-by: Matt Benjamin --- M src/FSAL/FSAL_GPFS/fsal_up.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_export.c M src/FSAL_UP/fsal_up_top.c M src/include/fsal_up.h 4 files changed, 27 insertions(+), 27 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/11/288811/1 -- To view, visit https://review.gerrithub.io/288811 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I52ca4b11b780d675dc54a0ad08ce4b50ea9df404 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Matt Benjamin -- ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: c++ header compilation: remove export token, others
>From Matt Benjamin: Matt Benjamin has uploaded a new change for review. https://review.gerrithub.io/288796 Change subject: c++ header compilation: remove export token, others .. c++ header compilation: remove export token, others Adjust the structure of headers currently included from cache_inode.h and export_mgr.h to permit compilation by a modern c++ compiler. The main conflicts resolved: * s/new//; * s/private/private_data/ in fsal_filesystem * s/export as a token/a qualified token/; * adjust some operations on void pointers and disallowed int conversions Change-Id: Id6feb98dae6b294d6dea20b44db82e679c37 Signed-off-by: Matt Benjamin --- M src/FSAL/FSAL_GPFS/export.c M src/FSAL/FSAL_GPFS/fsal_attrs.c M src/FSAL/FSAL_GPFS/fsal_create.c M src/FSAL/FSAL_GPFS/fsal_ds.c M src/FSAL/FSAL_GPFS/fsal_fileop.c M src/FSAL/FSAL_GPFS/fsal_internal.c M src/FSAL/FSAL_GPFS/fsal_lock.c M src/FSAL/FSAL_GPFS/fsal_lookup.c M src/FSAL/FSAL_GPFS/fsal_mds.c M src/FSAL/FSAL_GPFS/fsal_rename.c M src/FSAL/FSAL_GPFS/fsal_symlinks.c M src/FSAL/FSAL_GPFS/fsal_unlink.c M src/FSAL/FSAL_GPFS/handle.c M src/FSAL/FSAL_PSEUDO/export.c M src/FSAL/FSAL_RGW/main.c M src/FSAL/FSAL_VFS/export.c M src/FSAL/FSAL_VFS/file.c M src/FSAL/FSAL_VFS/handle.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_lru.c M src/FSAL/Stackable_FSALs/FSAL_NULL/export.c M src/FSAL/fsal_helper.c M src/FSAL_UP/fsal_up_top.c M src/MainNFSD/nfs_worker_thread.c M src/Protocols/9P/9p_attach.c M src/Protocols/9P/9p_proto_tools.c M src/Protocols/NFS/mnt_Export.c M src/Protocols/NFS/mnt_Mnt.c M src/Protocols/NFS/nfs3_create.c M src/Protocols/NFS/nfs3_fsinfo.c M src/Protocols/NFS/nfs3_lookup.c M src/Protocols/NFS/nfs3_mkdir.c M src/Protocols/NFS/nfs3_mknod.c M src/Protocols/NFS/nfs3_read.c M src/Protocols/NFS/nfs3_readdirplus.c M src/Protocols/NFS/nfs3_symlink.c M src/Protocols/NFS/nfs3_write.c M src/Protocols/NFS/nfs4_Compound.c M src/Protocols/NFS/nfs4_op_create.c M src/Protocols/NFS/nfs4_op_getdevicelist.c M src/Protocols/NFS/nfs4_op_layoutget.c M src/Protocols/NFS/nfs4_op_layoutreturn.c M src/Protocols/NFS/nfs4_op_lock.c M src/Protocols/NFS/nfs4_op_lookup.c M src/Protocols/NFS/nfs4_op_lookupp.c M src/Protocols/NFS/nfs4_op_open.c M src/Protocols/NFS/nfs4_op_putfh.c M src/Protocols/NFS/nfs4_op_putrootfh.c M src/Protocols/NFS/nfs4_op_read.c M src/Protocols/NFS/nfs4_op_readdir.c M src/Protocols/NFS/nfs4_op_restorefh.c M src/Protocols/NFS/nfs4_op_savefh.c M src/Protocols/NFS/nfs4_op_secinfo.c M src/Protocols/NFS/nfs4_op_secinfo_no_name.c M src/Protocols/NFS/nfs4_op_write.c M src/Protocols/NFS/nfs4_pseudo.c M src/Protocols/NFS/nfs_proto_tools.c M src/Protocols/NLM/nlm_Cancel.c M src/Protocols/NLM/nlm_Granted_Res.c M src/Protocols/NLM/nlm_Lock.c M src/Protocols/NLM/nlm_Share.c M src/Protocols/NLM/nlm_Test.c M src/Protocols/NLM/nlm_Unlock.c M src/Protocols/NLM/nlm_Unshare.c M src/SAL/nfs4_state.c M src/SAL/nlm_state.c M src/SAL/state_deleg.c M src/SAL/state_lock.c M src/SAL/state_share.c M src/config_parsing/config_parsing.c M src/include/avltree.h M src/include/config_parsing.h M src/include/export_mgr.h M src/include/fsal.h M src/include/fsal_api.h M src/include/fsal_types.h M src/include/gsh_list.h M src/include/gsh_rpc.h M src/include/log.h M src/include/sal_functions.h M src/support/export_mgr.c M src/support/exports.c M src/support/nfs_creds.c M src/support/nfs_filehandle_mgmt.c M src/support/server_stats.c 85 files changed, 510 insertions(+), 486 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/96/288796/1 -- To view, visit https://review.gerrithub.io/288796 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id6feb98dae6b294d6dea20b44db82e679c37 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Matt Benjamin -- ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: testing: introduce gmock and gtest framework
>From Matt Benjamin: Matt Benjamin has uploaded a new change for review. https://review.gerrithub.io/288793 Change subject: testing: introduce gmock and gtest framework .. testing: introduce gmock and gtest framework Google's implementations of these frameworks have specific features we require, in particular, thread safety. In addition, the ability to use c++ facilities (data structures, random distributions, etc) for prototyping test code looked likely to be a large time saver. Change-Id: Ibcfb956f1074428ef57cda0a1c82c2819f95d4c4 Signed-off-by: Matt Benjamin --- M src/CMakeLists.txt A src/gtest/README A src/gtest/test_ci_hash_dist1.cc A src/gtest/test_example.cc M src/test/CMakeLists.txt 5 files changed, 95 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/93/288793/1 -- To view, visit https://review.gerrithub.io/288793 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibcfb956f1074428ef57cda0a1c82c2819f95d4c4 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Matt Benjamin -- ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: gsh_rpc: narrowing (maybe)
>From Matt Benjamin: Matt Benjamin has uploaded a new change for review. https://review.gerrithub.io/288808 Change subject: gsh_rpc: narrowing (maybe) .. gsh_rpc: narrowing (maybe) Avoid maybe-spurious narrowing conversion warning w/C++. Change-Id: I6a92613f3d90d1c1d8398b3922b2492a9082448e Signed-off-by: Matt Benjamin --- M src/include/gsh_rpc.h 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/08/288808/1 -- To view, visit https://review.gerrithub.io/288808 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6a92613f3d90d1c1d8398b3922b2492a9082448e Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Matt Benjamin -- ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: RGW: call new rgw_commit routine in rgw_fsal_commit2
>From Matt Benjamin: Matt Benjamin has uploaded a new change for review. https://review.gerrithub.io/288788 Change subject: RGW: call new rgw_commit routine in rgw_fsal_commit2 .. RGW: call new rgw_commit routine in rgw_fsal_commit2 Change-Id: I0a9b4e0e21c78f62c2d8f9f03bc0ffb02af5c060 Signed-off-by: Matt Benjamin --- M src/FSAL/FSAL_RGW/handle.c 1 file changed, 4 insertions(+), 3 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/88/288788/1 -- To view, visit https://review.gerrithub.io/288788 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0a9b4e0e21c78f62c2d8f9f03bc0ffb02af5c060 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Matt Benjamin -- ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: gtest: add initial libganesha fsal test driver
>From Matt Benjamin: Matt Benjamin has uploaded a new change for review. https://review.gerrithub.io/288814 Change subject: gtest: add initial libganesha fsal test driver .. gtest: add initial libganesha fsal test driver Introduce a c++ test target intended to automate exports and obj_handle/fsal interface to prove runtime assertions and run benchmarks. Change-Id: Ie8721f61252472ff31b9e2f3d987164401960df8 Signed-off-by: Matt Benjamin --- M src/gtest/test_ci_hash_dist1.cc 1 file changed, 189 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/14/288814/1 -- To view, visit https://review.gerrithub.io/288814 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie8721f61252472ff31b9e2f3d987164401960df8 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Matt Benjamin -- ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: testing: support debug level and log path
>From Matt Benjamin: Matt Benjamin has uploaded a new change for review. https://review.gerrithub.io/288800 Change subject: testing: support debug level and log path .. testing: support debug level and log path Exposed as "logfile" and "debug." Change-Id: Ia6df21abb22ec37fc8fe655ed2b35da6462bc522 Signed-off-by: Matt Benjamin --- M src/MainNFSD/nfs_lib.c M src/include/nfs_lib.h 2 files changed, 12 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/00/288800/1 -- To view, visit https://review.gerrithub.io/288800 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia6df21abb22ec37fc8fe655ed2b35da6462bc522 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Matt Benjamin -- ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: testing: c++, prune src/test/CMakeLists.txt
>From Matt Benjamin: Matt Benjamin has uploaded a new change for review. https://review.gerrithub.io/288792 Change subject: testing: c++, prune src/test/CMakeLists.txt .. testing: c++, prune src/test/CMakeLists.txt * Minimally enable building c++ targets (e.g., for tests) * Prune noise from src/test/CMakeLists.txt Change-Id: Id13d42d5472b67d8ace9cc80e3c1e195a0f1e0f5 Signed-off-by: Matt Benjamin --- M src/CMakeLists.txt M src/test/CMakeLists.txt 2 files changed, 1 insertion(+), 16 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/92/288792/1 -- To view, visit https://review.gerrithub.io/288792 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id13d42d5472b67d8ace9cc80e3c1e195a0f1e0f5 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Matt Benjamin -- ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Make sure that netgroup cache entry exists before removing.
>From Malahal: Malahal has uploaded a new change for review. https://review.gerrithub.io/290033 Change subject: Make sure that netgroup cache entry exists before removing. .. Make sure that netgroup cache entry exists before removing. Also removed an unnecessary hash key computation. Change-Id: I8026fa238f4c04b01cefa0b15b0a450fb82c4b7f Signed-off-by: Malahal Naineni --- M src/support/netgroup_cache.c 1 file changed, 15 insertions(+), 6 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/33/290033/1 -- To view, visit https://review.gerrithub.io/290033 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8026fa238f4c04b01cefa0b15b0a450fb82c4b7f Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Malahal -- ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: open2 is always passed at least empty attributes, assure tha...
>From Frank Filz: Frank Filz has uploaded a new change for review. https://review.gerrithub.io/290035 Change subject: open2 is always passed at least empty attributes, assure that mode is set .. open2 is always passed at least empty attributes, assure that mode is set If we are doing a create, since we always pass at least empty attributes, we MUST set mode. Also, the implementations were testing for a NULL pointer to determine if any attributes were provided. Since the pointer is always non-NULL, the logic needs to change to check if any attributes OTHER than mode are set. Change-Id: Id5e5fdaae804c2cdc07ca13e212e9cfede4426e3 Signed-off-by: Frank S. Filz --- M src/FSAL/FSAL_CEPH/handle.c M src/FSAL/FSAL_GLUSTER/handle.c M src/FSAL/FSAL_VFS/file.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_file.c M src/FSAL/fsal_helper.c M src/Protocols/NFS/nfs4_op_open.c M src/include/fsal_api.h 7 files changed, 94 insertions(+), 87 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/35/290035/1 -- To view, visit https://review.gerrithub.io/290035 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id5e5fdaae804c2cdc07ca13e212e9cfede4426e3 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Frank Filz -- ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: GPFS: remove unused code
>From Malahal: Malahal has uploaded a new change for review. https://review.gerrithub.io/290036 Change subject: GPFS: remove unused code .. GPFS: remove unused code Change-Id: Id7958ca4dac02ae79a4189ca7af1f94460d17bb0 Signed-off-by: Malahal Naineni --- M src/FSAL/FSAL_GPFS/fsal_internal.c M src/FSAL/FSAL_GPFS/fsal_internal.h M src/FSAL/FSAL_GPFS/gpfs_methods.h M src/FSAL/FSAL_GPFS/handle.c 4 files changed, 0 insertions(+), 74 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/36/290036/1 -- To view, visit https://review.gerrithub.io/290036 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id7958ca4dac02ae79a4189ca7af1f94460d17bb0 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Malahal -- ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Fix coverity issue #152525 - unchecked return
>From Daniel Gryniewicz: Daniel Gryniewicz has uploaded a new change for review. https://review.gerrithub.io/290340 Change subject: Fix coverity issue #152525 - unchecked return .. Fix coverity issue #152525 - unchecked return Change-Id: I09dcffd3a69f0a76ff338bff538441ec24e57e91 Signed-off-by: Daniel Gryniewicz --- M src/include/sal_functions.h 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/40/290340/1 -- To view, visit https://review.gerrithub.io/290340 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I09dcffd3a69f0a76ff338bff538441ec24e57e91 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Daniel Gryniewicz -- ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Enable purging netgroups cache
>From Malahal: Malahal has uploaded a new change for review. https://review.gerrithub.io/290351 Change subject: Enable purging netgroups cache .. Enable purging netgroups cache The cache entries of innetgr() calls auto expire after 30 minutes. If an admin wants to make a netgroups config change effective sooner, he could now use "ganesha_mgr purge netgroups" Change-Id: Icb95438b423d36447fb7db08adebb39ffe6cafb5 Signed-off-by: Malahal Naineni --- M src/MainNFSD/nfs_admin_thread.c M src/scripts/ganeshactl/Ganesha/ganesha_mgr_utils.py M src/scripts/ganeshactl/ganesha_mgr.py 3 files changed, 63 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/51/290351/1 -- To view, visit https://review.gerrithub.io/290351 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icb95438b423d36447fb7db08adebb39ffe6cafb5 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Malahal -- ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Exit upon an error in option parsing in ganesha_mgr script.
>From Malahal: Malahal has uploaded a new change for review. https://review.gerrithub.io/290352 Change subject: Exit upon an error in option parsing in ganesha_mgr script. .. Exit upon an error in option parsing in ganesha_mgr script. Change-Id: I61f3bd6d35320b495473e5e54c0c646bc239fe86 Signed-off-by: Malahal Naineni --- M src/scripts/ganeshactl/ganesha_mgr.py 1 file changed, 9 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/52/290352/1 -- To view, visit https://review.gerrithub.io/290352 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I61f3bd6d35320b495473e5e54c0c646bc239fe86 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Malahal -- ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Fix file handle bytes switching in xdr_nfs_fh4 XDR_ENCODE
>From Patrice LUCAS: Patrice LUCAS has uploaded a new change for review. https://review.gerrithub.io/290557 Change subject: Fix file handle bytes switching in xdr_nfs_fh4 XDR_ENCODE .. Fix file handle bytes switching in xdr_nfs_fh4 XDR_ENCODE FSAL_PROXY tests reveals a "Stale file handle" error at first ls on root directory. This was due to call to htons in the encode way that was switching bytes and corrupting the file handle in FSAL_PROXY. Only for XDR_ENCODE case in xdr_nfs_fh4 function, this patch adds the use of a buffer to copy and safely switch bytes of nfs_fh4_val without changing original FSAL_PROXY handle value. Change-Id: Ia682d0ce83d19ee873c1c7a993e6c86499c48bd7 Signed-off-by: Patrice LUCAS --- M src/include/nfsv41.h 1 file changed, 28 insertions(+), 14 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/57/290557/1 -- To view, visit https://review.gerrithub.io/290557 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia682d0ce83d19ee873c1c7a993e6c86499c48bd7 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Patrice LUCAS -- ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Remove multiple addresses config parsing error
>From Patrice LUCAS: Patrice LUCAS has uploaded a new change for review. https://review.gerrithub.io/290556 Change subject: Remove multiple addresses config parsing error .. Remove multiple addresses config parsing error When we need to resolve a server address as in FSAL_PROXY example, this useless error makes impossible to start ganesha and must be removed. Change-Id: I414fa90ace3db6065b6a90af5c83e84987375d0c Signed-off-by: Patrice LUCAS --- M src/config_parsing/config_parsing.c 1 file changed, 0 insertions(+), 7 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/56/290556/1 -- To view, visit https://review.gerrithub.io/290556 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I414fa90ace3db6065b6a90af5c83e84987375d0c Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Patrice LUCAS -- ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: FSAL_GPFS: more fixes and cleanup for multi-fd
>From: es...@us.ibm.com has uploaded a new change for review. https://review.gerrithub.io/289448 Change subject: FSAL_GPFS: more fixes and cleanup for multi-fd .. FSAL_GPFS: more fixes and cleanup for multi-fd Change-Id: Idf6a1eb2a003fd8f45544665648d49aba77d637e Signed-off-by: Marc Eshel --- M src/FSAL/FSAL_GPFS/file.c M src/FSAL/FSAL_GPFS/fsal_fileop.c M src/FSAL/FSAL_GPFS/fsal_mds.c M src/FSAL/FSAL_GPFS/handle.c M src/SAL/nfs4_state.c 5 files changed, 31 insertions(+), 11 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/48/289448/1 -- To view, visit https://review.gerrithub.io/289448 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Idf6a1eb2a003fd8f45544665648d49aba77d637e Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: es...@us.ibm.com -- ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Prepend root path to pathname for RQUOTA
>From: madhu.punj...@in.ibm.com has uploaded a new change for review. https://review.gerrithub.io/290509 Change subject: Prepend root path to pathname for RQUOTA .. Prepend root path to pathname for RQUOTA Currently on NFS client the rpc.quotad sends pathnames of NFSv4 mountpoints without leading slash in path. But rquota_getquota() and do_rquota_setquota() are not able to identify the export for a pathname with missing leading slash. Modified rquota_getquota() and do_rquota_setquota() functions to check if leading slash is missing, and then prepend the root path to the pathname. Change-Id: I13bf3752fa076cf20718f6c3cd846ca6f9717fc5 Signed-off-by: Madhu Thorat --- M src/Protocols/RQUOTA/rquota_getquota.c M src/Protocols/RQUOTA/rquota_setquota.c 2 files changed, 28 insertions(+), 12 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/09/290509/1 -- To view, visit https://review.gerrithub.io/290509 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I13bf3752fa076cf20718f6c3cd846ca6f9717fc5 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: madhu.punj...@in.ibm.com -- ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: cmake: find libhandle.so on Debian Stretch and Ubuntu Xenial
>From: ka...@redhat.com has uploaded a new change for review. https://review.gerrithub.io/289800 Change subject: cmake: find libhandle.so on Debian Stretch and Ubuntu Xenial .. cmake: find libhandle.so on Debian Stretch and Ubuntu Xenial xfslibs and xfslibs-dev on Stretch and Xenial install libhandle.so.1* and libhandle.so in /lib instead of the more usual places, e.g. /usr/lib/libhandle.so or /usr/lib64/libhandle.so. (Perhaps this is a bug in Stretch's and Xenial's xfslibs packages?) To make matters worse, libhandle.a on these distributions is installed in /usr/lib/, with the result that cmake's check_library_exists() will find them, but later on build will try to link with libhandle.a and fail due to the mismatch between PIC code in the FSAL and the non-PIC code in libhandle.a. Thus we check first (order is important here) for the odd location, and if found, set things up to link with it. Otherwise check the normal location(s) and let the link find it the way it usually does. Change-Id: I2deb24176d94bc68c9c4cca27b94cedc8bce68da Signed-off-by: Kaleb S. KEITHLEY --- M src/CMakeLists.txt M src/FSAL/FSAL_VFS/xfs/CMakeLists.txt 2 files changed, 10 insertions(+), 6 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/00/289800/1 -- To view, visit https://review.gerrithub.io/289800 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2deb24176d94bc68c9c4cca27b94cedc8bce68da Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: ka...@redhat.com -- ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Fix mtime handling in FSAL_CEPH layoutcommit
>From: jlay...@redhat.com has uploaded a new change for review. https://review.gerrithub.io/294565 Change subject: Fix mtime handling in FSAL_CEPH layoutcommit .. Fix mtime handling in FSAL_CEPH layoutcommit This code only seems to care about the seconds field, but any difference may only be visible in the nsec field. This means we need to switch to clock_gettime() instead of time() as well. Change-Id: Ib8df7085cc5b50463a1674cdf6e8ab8c9d64f97b Signed-off-by: Jeff Layton --- M src/FSAL/FSAL_CEPH/mds.c 1 file changed, 10 insertions(+), 4 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/65/294565/1 -- To view, visit https://review.gerrithub.io/294565 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib8df7085cc5b50463a1674cdf6e8ab8c9d64f97b Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: jlay...@redhat.com -- ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Check for NULL fullpath pointer in clean_export_paths
>From: jlay...@redhat.com has uploaded a new change for review. https://review.gerrithub.io/294564 Change subject: Check for NULL fullpath pointer in clean_export_paths .. Check for NULL fullpath pointer in clean_export_paths fullpath can be NULL here, in which case we'll end up with a null pointer dereference. Check for that and treat it the same as an empty path. Change-Id: I5313728efde03cf6e090ad3462a6a2194ac6814f Signed-off-by: Jeff Layton --- M src/support/exports.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/64/294564/1 -- To view, visit https://review.gerrithub.io/294564 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5313728efde03cf6e090ad3462a6a2194ac6814f Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: jlay...@redhat.com -- ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Fix clock_gettime error handling in ceph_setattr2
>From: jlay...@redhat.com has uploaded a new change for review. https://review.gerrithub.io/294566 Change subject: Fix clock_gettime error handling in ceph_setattr2 .. Fix clock_gettime error handling in ceph_setattr2 Any error there will be in errno, and it is a POSIX call so we want to use posix2fsal_error. Change-Id: I1024a775680df63e5598dc17278b42f1a440acdb Signed-off-by: Jeff Layton --- M src/FSAL/FSAL_CEPH/handle.c 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/66/294566/1 -- To view, visit https://review.gerrithub.io/294566 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1024a775680df63e5598dc17278b42f1a440acdb Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: jlay...@redhat.com -- ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Add a thread to poll blocked locks
>From Frank Filz: Frank Filz has uploaded a new change for review. https://review.gerrithub.io/294609 Change subject: Add a thread to poll blocked locks .. Add a thread to poll blocked locks If the FSAL doesn't support async blocked locks, we must poll the blocked locks on some interval. To implement this, we need the following: 1. A thread to poll 2. A config variable to define the polling interval 3. do_lock_op must track if a LOCKB request was made to an FSAL that doesn't support async blocking locks, and in that case, it will return STATE_LOCK_BLOCKED instead of STATE_LOCK_CONFLICT. We still translate the LOCKB request to a LOCK request to the FSAL. 4. The polling thread will try_to_grant_lock with a new grant type, STATE_GRANT_POLL (though in fact, the action for this is identical to STATE_GRANT_FSAL_AVAILABLE). Incidental changes: We track the type of blocked lock: INTERNAL (is blocked on another lock managed by this Ganesha instance) ASYNC (is managed by FSAL async blocking) POLL (will be polled by the new thread) This allows the polling thread to easily skip the blocked locks that will not be relevant. It also allows us to indicate the type of block when displaying lock entries. Change-Id: I502cc8757ef1132301b73393d5fbefa19ab485df Signed-off-by: Frank S. Filz --- M src/MainNFSD/nfs_init.c M src/SAL/state_async.c M src/SAL/state_lock.c M src/config_samples/config.txt M src/include/gsh_config.h M src/include/sal_data.h M src/include/sal_functions.h M src/support/nfs_read_conf.c 8 files changed, 205 insertions(+), 29 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/09/294609/1 -- To view, visit https://review.gerrithub.io/294609 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I502cc8757ef1132301b73393d5fbefa19ab485df Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Frank Filz -- ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Rename config_samples/logging..txt -> config_samples/logging...
>From Frank Filz: Frank Filz has uploaded a new change for review. https://review.gerrithub.io/294610 Change subject: Rename config_samples/logging..txt -> config_samples/logging.txt .. Rename config_samples/logging..txt -> config_samples/logging.txt Change-Id: Ib42954cc797d7b72ef92c28dce23d3b920019745 Signed-off-by: Frank S. Filz --- R src/config_samples/logging.txt 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/10/294610/1 -- To view, visit https://review.gerrithub.io/294610 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib42954cc797d7b72ef92c28dce23d3b920019745 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Frank Filz -- ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Fix STATE_GRANT_FSAL_AVAILABLE upcall
>From Frank Filz: Frank Filz has uploaded a new change for review. https://review.gerrithub.io/294605 Change subject: Fix STATE_GRANT_FSAL_AVAILABLE upcall .. Fix STATE_GRANT_FSAL_AVAILABLE upcall Don't remove locks from the blocked lock list until a grant has successfully been sent or has failed. Change-Id: I1eec2059e951f45a644770a07fd38fee4b8fd099 Signed-off-by: Frank S. Filz --- M src/SAL/state_lock.c 1 file changed, 18 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/05/294605/1 -- To view, visit https://review.gerrithub.io/294605 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1eec2059e951f45a644770a07fd38fee4b8fd099 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Frank Filz -- ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: FSAL_PROXY does not support locks
>From Frank Filz: Frank Filz has uploaded a new change for review. https://review.gerrithub.io/294607 Change subject: FSAL_PROXY does not support locks .. FSAL_PROXY does not support locks Change-Id: Ife4a60d27799b18a96e616c62bb1c7c6d06805e1 Signed-off-by: Frank S. Filz --- M src/FSAL/FSAL_PROXY/main.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/07/294607/1 -- To view, visit https://review.gerrithub.io/294607 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ife4a60d27799b18a96e616c62bb1c7c6d06805e1 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Frank Filz -- ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: FSAL_VFS: Don't lose rc from lock call when doing getlock fo...
>From Frank Filz: Frank Filz has uploaded a new change for review. https://review.gerrithub.io/294608 Change subject: FSAL_VFS: Don't lose rc from lock call when doing getlock for conflict .. FSAL_VFS: Don't lose rc from lock call when doing getlock for conflict Change-Id: I1e7fddf8cd26b433b49510eb55c914816f3e8ff8 Signed-off-by: Frank S. Filz --- M src/FSAL/FSAL_VFS/file.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/08/294608/1 -- To view, visit https://review.gerrithub.io/294608 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1e7fddf8cd26b433b49510eb55c914816f3e8ff8 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Frank Filz -- ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: multilock: Actually send OFD/POSIX parameter to ml client
>From Frank Filz: Frank Filz has uploaded a new change for review. https://review.gerrithub.io/294606 Change subject: multilock: Actually send OFD/POSIX parameter to ml client .. multilock: Actually send OFD/POSIX parameter to ml client Change-Id: Ib60c0b4a5fd396dc17654dc338f5c6f6fca62249 Signed-off-by: Frank S. Filz --- M src/tools/multilock/ml_functions.c 1 file changed, 14 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/06/294606/1 -- To view, visit https://review.gerrithub.io/294606 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib60c0b4a5fd396dc17654dc338f5c6f6fca62249 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Frank Filz -- ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: NFSv4 Use correct fileid for readdir
>From Frank Filz: Frank Filz has uploaded a new change for review. https://review.gerrithub.io/294597 Change subject: NFSv4 Use correct fileid for readdir .. NFSv4 Use correct fileid for readdir Change-Id: I2aa8a53a5007002dc180841134a3b29d983420a4 Signed-off-by: Frank S. Filz --- M src/Protocols/NFS/nfs4_op_readdir.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/97/294597/1 -- To view, visit https://review.gerrithub.io/294597 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2aa8a53a5007002dc180841134a3b29d983420a4 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Frank Filz -- ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: MDCACHE - Call the default test_access() directly
>From Daniel Gryniewicz: Daniel Gryniewicz has uploaded a new change for review. https://review.gerrithub.io/290975 Change subject: MDCACHE - Call the default test_access() directly .. MDCACHE - Call the default test_access() directly All FSALs currently use the default test_access() implementation. However, MDCACHE was calling into the sub-FSAL anyway. This means that, when the default test_access() called getattr(), it was uncached, causing high latency. Since test_access() is a very common operation, this was slowing things down a lot. As a work-around, call the default test_access() directly. If, at some future point, some FSAL wants to override test_access(), this will have to be revisited. Change-Id: Iba4ab7ece5818a7c752a5fe42e54b78ec6f06467 Signed-off-by: Daniel Gryniewicz --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_handle.c 1 file changed, 10 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/75/290975/1 -- To view, visit https://review.gerrithub.io/290975 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iba4ab7ece5818a7c752a5fe42e54b78ec6f06467 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Daniel Gryniewicz -- What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic patterns at an interface-level. Reveals which users, apps, and protocols are consuming the most bandwidth. Provides multi-vendor support for NetFlow, J-Flow, sFlow and other flows. Make informed decisions using capacity planning reports. http://sdm.link/zohodev2dev ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: FSAL_GLUSTER : spec file changes for FSAL_GLUSTER
>From Jiffin Tony Thottan: Jiffin Tony Thottan has uploaded a new change for review. https://review.gerrithub.io/294627 Change subject: FSAL_GLUSTER : spec file changes for FSAL_GLUSTER .. FSAL_GLUSTER : spec file changes for FSAL_GLUSTER NFS-Ganesha 2.4 has dependency over GlusterFS 3.8. Add changes to spec to reflect that change Change-Id: Ibf2a60975e97204f31c7c27c154f1ab382e3b3f0 Signed-off-by: Jiffin Tony Thottan --- M src/nfs-ganesha.spec-in.cmake 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/27/294627/1 -- To view, visit https://review.gerrithub.io/294627 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibf2a60975e97204f31c7c27c154f1ab382e3b3f0 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Jiffin Tony Thottan -- ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: FSAL_GLUSTER: Use chk_verifier_stat to verifier comparision ...
>From Soumya: Soumya has uploaded a new change for review. https://review.gerrithub.io/294679 Change subject: FSAL_GLUSTER: Use chk_verifier_stat to verifier comparision in open2() .. FSAL_GLUSTER: Use chk_verifier_stat to verifier comparision in open2() In case of exclusive create, for verifier comparision, use chk_verifier_stat instead as the attributes are already available. Change-Id: Id495ae1a978b4e2b84f8c7c6201a4b0f3ab8316f Signed-off-by: Soumya Koduri --- M src/FSAL/FSAL_GLUSTER/handle.c 1 file changed, 14 insertions(+), 12 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/79/294679/1 -- To view, visit https://review.gerrithub.io/294679 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id495ae1a978b4e2b84f8c7c6201a4b0f3ab8316f Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Soumya -- ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: FSAL_GLUSTER: Avoid redundant fsync operation
>From Soumya: Soumya has uploaded a new change for review. https://review.gerrithub.io/294676 Change subject: FSAL_GLUSTER: Avoid redundant fsync operation .. FSAL_GLUSTER: Avoid redundant fsync operation Currently we do fsync operation post write if the fsal_stable is set to FSAL_O_SYNC flag. But this is not needed as glusterfs write operation can accept O_SYNC flag which guarantees synchronous writes. Change-Id: I6a1eb4e9ca97043e969ec63c7e784005fc2bfda2 Signed-off-by: Soumya Koduri --- M src/FSAL/FSAL_GLUSTER/handle.c 1 file changed, 0 insertions(+), 9 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/76/294676/1 -- To view, visit https://review.gerrithub.io/294676 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6a1eb4e9ca97043e969ec63c7e784005fc2bfda2 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Soumya -- ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: FSAL_GLUSTER: avoid fetching attributes in setattr2
>From Soumya: Soumya has uploaded a new change for review. https://review.gerrithub.io/294677 Change subject: FSAL_GLUSTER: avoid fetching attributes in setattr2 .. FSAL_GLUSTER: avoid fetching attributes in setattr2 The attrributes read post successful setattr are currently not consumed by md-cache which again does getattrs to refresh the object's attributes. Hence avoid that call in FSAL setattr. Change-Id: If984a8ed4d8437b4e3d0dd0425d4588b8d59a309 Signed-off-by: Soumya Koduri --- M src/FSAL/FSAL_GLUSTER/handle.c 1 file changed, 0 insertions(+), 7 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/77/294677/1 -- To view, visit https://review.gerrithub.io/294677 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If984a8ed4d8437b4e3d0dd0425d4588b8d59a309 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Soumya -- ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: FSAL_GLUSTER: Clear ATTR_RDATTR_ERR mask bit in case of succ...
>From Soumya: Soumya has uploaded a new change for review. https://review.gerrithub.io/294678 Change subject: FSAL_GLUSTER: Clear ATTR_RDATTR_ERR mask bit in case of successful read .. FSAL_GLUSTER: Clear ATTR_RDATTR_ERR mask bit in case of successful read In case if the attributes of an entry are fetched successfully we need to clear 'ATTR_RDATTR_ERR' mask bit from them. This was missing at few places resulting in md-cache trying to re-invoke getattrs. This patch fixes the same. Change-Id: Ib0459d21c9d19dbac34f70d235f7461d7dcd7a34 Signed-off-by: Soumya Koduri --- M src/FSAL/FSAL_GLUSTER/handle.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/78/294678/1 -- To view, visit https://review.gerrithub.io/294678 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib0459d21c9d19dbac34f70d235f7461d7dcd7a34 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Soumya -- ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Fix readdir FSID/FILEID all the same
>From Daniel Gryniewicz: Daniel Gryniewicz has uploaded a new change for review. https://review.gerrithub.io/294680 Change subject: Fix readdir FSID/FILEID all the same .. Fix readdir FSID/FILEID all the same Set the FSID/FILEID to the found object, not the current object. Fix found by pl...@blackmilk.fr Change-Id: I3d6bc48bb0d80b12d0b7de86f2f84bdbf7428c60 Signed-off-by: Daniel Gryniewicz --- M src/Protocols/NFS/nfs4_op_readdir.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/80/294680/1 -- To view, visit https://review.gerrithub.io/294680 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3d6bc48bb0d80b12d0b7de86f2f84bdbf7428c60 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Daniel Gryniewicz -- ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Fix fileid, fsid and type decoding in NFS protocol
>From Patrice LUCAS: Patrice LUCAS has uploaded a new change for review. https://review.gerrithub.io/294698 Change subject: Fix fileid, fsid and type decoding in NFS protocol .. Fix fileid, fsid and type decoding in NFS protocol FSAL_PROXY tests showed null inode numbers. It came from xdr decoding into Fattr4_To_FSAL_attr function. The xdr_attrs_args structure contains both fileid directly and into attrs. Fattr4_To_FSAL_attr was waiting for an update of attrs whereas xdr decoding was updating xdr_attrs_args direct fields. Change-Id: I4d21d7f584c3346efdf09a0c9498346b62b48ef0 Signed-off-by: Patrice LUCAS --- M src/Protocols/NFS/nfs_proto_tools.c 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/98/294698/1 -- To view, visit https://review.gerrithub.io/294698 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4d21d7f584c3346efdf09a0c9498346b62b48ef0 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Patrice LUCAS -- ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: FSAL_RGW - Add back a close() op
>From Daniel Gryniewicz: Daniel Gryniewicz has uploaded a new change for review. https://review.gerrithub.io/294713 Change subject: FSAL_RGW - Add back a close() op .. FSAL_RGW - Add back a close() op Even support_ex() FSALs need the base close() op at this point. Add it back in for FSAL_RGW. Change-Id: If2229de97e7ad850461f953c21e10ac355342bd0 Signed-off-by: Daniel Gryniewicz --- M src/FSAL/FSAL_RGW/handle.c 1 file changed, 17 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/13/294713/1 -- To view, visit https://review.gerrithub.io/294713 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If2229de97e7ad850461f953c21e10ac355342bd0 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Daniel Gryniewicz -- ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: config: logrotate should not complain about missing logfiles
>From Niels de Vos: Niels de Vos has uploaded a new change for review. https://review.gerrithub.io/296656 Change subject: config: logrotate should not complain about missing logfiles .. config: logrotate should not complain about missing logfiles The NFS-Ganesha packages install logrorate configurations under /etc/logrotate.d/. In case the service is not enabled and Ganesha has never been started, there are no logfiles. This causes logrotate to complain and by default cron will send emails to the root user. These useless emails can be prevented by marking the logs with the `missingok` config option. Change-Id: Idef190964bdd026b70e21ffcd76064ff6148a482 Signed-off-by: Niels de Vos --- M src/config_samples/logrotate_fsal_gluster M src/config_samples/logrotate_ganesha 2 files changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/56/296656/1 -- To view, visit https://review.gerrithub.io/296656 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Idef190964bdd026b70e21ffcd76064ff6148a482 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Niels de Vos -- ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Fix create operations with GID for non-root users
>From Sachin Punadikar: Sachin Punadikar has uploaded a new change for review. https://review.gerrithub.io/297288 Change subject: Fix create operations with GID for non-root users .. Fix create operations with GID for non-root users AIX and Irix NFS clients send create with gid if the parent directory has setgid bit. This is unnecessary, but ganesha server ends up failing the request as non-root users can't set uid or gid. Added a workaround to remove attributes uid and gid for a create request for non-root users. Change-Id: Ie6c4599c0bfc476fccf36318ce1733ab4cf5f1a2 Signed-off-by: Sachin Punadikar --- M src/FSAL/fsal_helper.c M src/Protocols/9P/9p_setattr.c M src/Protocols/NFS/nfs3_setattr.c M src/Protocols/NFS/nfs4_op_setattr.c M src/include/fsal.h 5 files changed, 20 insertions(+), 5 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/88/297288/1 -- To view, visit https://review.gerrithub.io/297288 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie6c4599c0bfc476fccf36318ce1733ab4cf5f1a2 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Sachin Punadikar -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Ensure that GSS context stored in client record doesn't get ...
>From Malahal: Malahal has uploaded a new change for review. https://review.gerrithub.io/297065 Change subject: Ensure that GSS context stored in client record doesn't get destroyed .. Ensure that GSS context stored in client record doesn't get destroyed We currently store GSS context (gd->ctx) in nfs_client_id_t structure, but don't ensure that it doesn't get destroyed. Commit 3a34bedef9dc3796ee7a55e3ba7d1966f2adb2a9 started using this possibly freed context memory leading to crashes! Store svc_rpc_gss_data pointer and appropriately adjust its refcnt to ensure that it doesn't get freed prematurely. Change-Id: I6f2dcd1ac14e31bd8216096fdb3ae9415affee8b Signed-off-by: Malahal Naineni --- M src/SAL/nfs4_clientid.c M src/include/nfs_proto_data.h M src/support/nfs_creds.c 3 files changed, 25 insertions(+), 4 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/65/297065/1 -- To view, visit https://review.gerrithub.io/297065 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6f2dcd1ac14e31bd8216096fdb3ae9415affee8b Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Malahal -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Add RootIdSquash option for only squashing root id.
>From Matthew Wong: Matthew Wong has uploaded a new change for review. https://review.gerrithub.io/297575 Change subject: Add RootIdSquash option for only squashing root id. .. Add RootIdSquash option for only squashing root id. RootSquash squashes uid, gid and discards all groups if uid is 0. RootSquashId still squashes uid if it is 0, but it only squashes gid if it is 0 and it removes 0 from the groups instead of discarding them all. Change-Id: I2f6b5af4efc6735ce3e758a794f47418c724d937 Signed-off-by: Matthew Wong --- M src/include/nfs_exports.h M src/support/exports.c M src/support/nfs_creds.c 3 files changed, 102 insertions(+), 65 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/75/297575/1 -- To view, visit https://review.gerrithub.io/297575 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2f6b5af4efc6735ce3e758a794f47418c724d937 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Matthew Wong -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: FIX FSAL_PROXY : clear CTIME in setattrs
>From Patrice LUCAS: Patrice LUCAS has uploaded a new change for review. https://review.gerrithub.io/297475 Change subject: FIX FSAL_PROXY : clear CTIME in setattrs .. FIX FSAL_PROXY : clear CTIME in setattrs No way to update CTIME using a NFSv4 SETATTR. Server will return NFS4ERR_INVAL (22). Nevermind : this update is useless, we prevent it in FSAL_PROXY by clearing CTIME bitmask. Change-Id: I5051992035d0c42d77d67468c0d8f223198bc097 Signed-off-by: Patrice LUCAS --- M src/FSAL/FSAL_PROXY/handle.c 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/75/297475/1 -- To view, visit https://review.gerrithub.io/297475 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5051992035d0c42d77d67468c0d8f223198bc097 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Patrice LUCAS -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Move put_ref() up to fsal_readdir
>From Daniel Gryniewicz: Daniel Gryniewicz has uploaded a new change for review. https://review.gerrithub.io/297243 Change subject: Move put_ref() up to fsal_readdir .. Move put_ref() up to fsal_readdir The object passed to the readdir callback is refcounted by MDCACHE. Previously, this ref was put by MDCACHE as well. However, an uncached FSAL doing it's own refcounting needs to have this ref put as well, so move that put_ref() up into fsal_readdir(). Change-Id: I506cb30df7c7864ca58f16acda200581781f7f6e Signed-off-by: Daniel Gryniewicz --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_handle.c M src/FSAL/fsal_helper.c 2 files changed, 18 insertions(+), 7 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/43/297243/1 -- To view, visit https://review.gerrithub.io/297243 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I506cb30df7c7864ca58f16acda200581781f7f6e Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Daniel Gryniewicz -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Pass the dev arguments for mknod
>From Daniel Gryniewicz: Daniel Gryniewicz has uploaded a new change for review. https://review.gerrithub.io/297394 Change subject: Pass the dev arguments for mknod .. Pass the dev arguments for mknod During the MDCACHE transition, mknod dev args moved into the attributes, but the copy out of the arguments got lost. Re-add it, so that mknode uses the correct device attributes. Change-Id: Idf56cfb7f8f0dfa67dd63b2286f1d6443f9f445f Signed-off-by: Daniel Gryniewicz --- M src/Protocols/NFS/nfs4_op_create.c 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/94/297394/1 -- To view, visit https://review.gerrithub.io/297394 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Idf56cfb7f8f0dfa67dd63b2286f1d6443f9f445f Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Daniel Gryniewicz -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: FSAL_GLUSTER : Avoid double free for glfsal_module
>From Jiffin Tony Thottan: Jiffin Tony Thottan has uploaded a new change for review. https://review.gerrithub.io/294623 Change subject: FSAL_GLUSTER : Avoid double free for glfsal_module .. FSAL_GLUSTER : Avoid double free for glfsal_module If FSAL_GLUSTER fails to load it will free glfsal_module in glusterfs_init. Since load_fsal() got failed, a clean up should be performed and as a part of that glusterfs_unload() got executed. Finally it will end up in a double free for glfsal_module Change-Id: I593dbb43b45d61d5a78333b330c7e57c9d3219ef Signed-off-by: Jiffin Tony Thottan --- M src/FSAL/FSAL_GLUSTER/main.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/23/294623/1 -- To view, visit https://review.gerrithub.io/294623 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I593dbb43b45d61d5a78333b330c7e57c9d3219ef Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Jiffin Tony Thottan -- ___ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel