>From Frank Filz <ffilz...@mindspring.com>: Frank Filz has uploaded a new change for review.
https://review.gerrithub.io/290035 Change subject: open2 is always passed at least empty attributes, assure that mode is set ...................................................................... open2 is always passed at least empty attributes, assure that mode is set If we are doing a create, since we always pass at least empty attributes, we MUST set mode. Also, the implementations were testing for a NULL pointer to determine if any attributes were provided. Since the pointer is always non-NULL, the logic needs to change to check if any attributes OTHER than mode are set. Change-Id: Id5e5fdaae804c2cdc07ca13e212e9cfede4426e3 Signed-off-by: Frank S. Filz <ffilz...@mindspring.com> --- M src/FSAL/FSAL_CEPH/handle.c M src/FSAL/FSAL_GLUSTER/handle.c M src/FSAL/FSAL_VFS/file.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_file.c M src/FSAL/fsal_helper.c M src/Protocols/NFS/nfs4_op_open.c M src/include/fsal_api.h 7 files changed, 94 insertions(+), 87 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/35/290035/1 -- To view, visit https://review.gerrithub.io/290035 To unsubscribe, visit https://review.gerrithub.io/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id5e5fdaae804c2cdc07ca13e212e9cfede4426e3 Gerrit-PatchSet: 1 Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Owner: Frank Filz <ffilz...@mindspring.com> ------------------------------------------------------------------------------ _______________________________________________ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
