Re: listen proxy_protocol and rewrite redirect scheme

I'm sorry for the babble above but the source of errors are too many. The previous post the problem was php (e.g. phpMyAdmin). The final working setup: src/http/ngx_http_header_filter_module.c: #if (NGX_HTTP_SSL) if (c->ssl || port == 443) { *b->last++ ='s'; } #endif

Re: listen proxy_protocol and rewrite redirect scheme

Hi, I'm sorry for the babble above but there are so many point of failure and the setup is so complex. Last problem was php (e.g. phpMyAdmin). Anyway now really works this way: src/http/ngx_http_header_filter_module.c: #if (NGX_HTTP_SSL) if (c->ssl || port == 443) { *b->last++ ='s'; }

Re: listen proxy_protocol and rewrite redirect scheme

Hi, I'm sorry but I mistakenly claimed to work the patch: #if (NGX_HTTP_SSL) if (c->ssl || port == 443) { *b->last++ ='s'; } #endif In order to work nginx needs this config: server { listen 127.0.0.1:443proxy_protocol; port_in_redirect

Re: listen proxy_protocol and rewrite redirect scheme

Hi, thank you for the hints. Starting from you suggestion I modified src/http/ngx_http_header_filter_module.c like this: #if (NGX_HTTP_SSL) if (c->ssl || port == 443) { *b->last++ ='s'; } #endif and it works! But works hand in hand with this nginx configuration (in

Re: listen proxy_protocol and rewrite redirect scheme

On Sat, Sep 17, 2016 at 03:11:20AM -0400, adrhc wrote: Hi there, > Oh, and I only want this change to apply to servers with "listen ... > proxy_protocol" but not otherwise ... That makes the initial code-change suggestion (where *all* adjusted Location: headers would be https) insufficient. If

Re: listen proxy_protocol and rewrite redirect scheme

On Sat, Sep 17, 2016 at 02:36:31AM -0400, adrhc wrote: Hi there, > yep, that's exactly my problem: > "... but that will not help internally-generated things like the > trailing-slash redirect for directories." > > I'll check your solution though I'm very open for other too :D If you care only

Re: listen proxy_protocol and rewrite redirect scheme

Oh, and I only want this change to apply to servers with "listen ... proxy_protocol" but not otherwise ... Posted at Nginx Forum: https://forum.nginx.org/read.php?2,269623,269640#msg-269640 ___ nginx mailing list nginx@nginx.org

Re: nginx timer in log module

Hello! On Sat, Sep 17, 2016 at 02:42:25PM +0800, 洪志道 wrote: > Thank you for your reply, I get it now. > > In other case such as I showed above, it seems we needn't do like the > following ? > > if (ev->timer_set) { > ngx_del_timer(ev); > } Yes, as long as the code is in the timer

Re: [PATCH 2 of 2] Core: add ngx_atomic_store() and ngx_atomic_load()

Hello! On Fri, Sep 16, 2016 at 02:43:49PM -0700, Piotr Sikora wrote: > Hey Maxim, > > > The "*(lock) == 0" check here is just an optimization, it only > > ensures that the lock is likely to succed. > > Yes, and use of the ngx_atomic_load() doesn't affect that. > > Namely, in the

Re: nginx timer in log module

Thank you for your reply, I get it now. In other case such as I showed above, it seems we needn't do like the following ? if (ev->timer_set) { ngx_del_timer(ev); } 2016-09-17 10:48 GMT+08:00 Maxim Dounin : > Hello! > > On Sat, Sep 17, 2016 at 08:25:54AM +0800, 洪志道

Re: listen proxy_protocol and rewrite redirect scheme

yep, that's exactly my problem: "... but that will not help internally-generated things like the trailing-slash redirect for directories." I'll check your solution though I'm very open for other too :D PS: I do compile my own custom nginx Posted at Nginx Forum: