Re: [PATCH] Add strict Host validation

2015-01-12 Thread Maxim Dounin
Hello! On Mon, Jan 05, 2015 at 02:12:04PM -0800, Piotr Sikora wrote: Hey Maxim, While I agree that there is no real reason for forbidding some of those characters, I think that Host still should be restricted to at least printable ASCII characters (minus space and path separators).

Re: [PATCH] Add strict Host validation

2015-01-12 Thread Piotr Sikora
Hey Maxim, I still think it's a no. If needed, allowed characters can be easily restricted by a configuration. Just to make a point: $ curl -I nginx.org HTTP/1.1 200 OK Server: nginx/1.7.7 Date: Mon, 12 Jan 2015 23:42:27 GMT Content-Type: text/html; charset=utf-8 Content-Length: 8981