Re: Supporting the Forwarded header (RFC 7239)

2017-08-07 Thread Maxim Dounin
Hello! On Sun, Aug 06, 2017 at 09:11:03PM +0300, Vasiliy Faronov wrote: > Hi nginx developers, > > As you know, RFC 7239 defines a Forwarded header to replace the zoo of > X-Forwarded-* with a single extensible syntax. > > There seems to be growing interest in deploying Forwarded. For >

Re: [PATCH] Allows hyphens in variable names so can access hyphenated query vars

2017-08-07 Thread Maxim Dounin
Hello! On Mon, Aug 07, 2017 at 04:15:33PM +0100, Mark Ellis via nginx-devel wrote: > Ok. How would you suggest accessing query parameters with hyphens? > > e.g. `?foo-bar=123` > > how would you get the value of foo-bar? It is more or less trivial to extract anything from $args using a

Re: [PATCH] Allows hyphens in variable names so can access hyphenated query vars

2017-08-07 Thread Mark Ellis via nginx-devel
Ok. How would you suggest accessing query parameters with hyphens? e.g. `?foo-bar=123` how would you get the value of foo-bar? Thanks On Mon, 7 Aug 2017, at 02:20 PM, Maxim Dounin wrote: > Hello! > > On Wed, Aug 02, 2017 at 11:30:11AM +, Mark Ellis via nginx-devel > wrote: > > > # HG

Re: [PATCH] Add proxy_protocol option to mail listener

2017-08-07 Thread Kees Bos
On ma, 2017-08-07 at 07:49 -0400, Wayde Nie wrote: > > > proxy_protocol > > > on the listen directive I see the correct ip and port picked up > > > and > > > logged in the error.log, however, then nginx stops sending the > > > smtp > > > greeting... My mail client connects to my loadbalancer, the

[PATCH] Add proxy_protocol option to mail listener

2017-08-07 Thread Kees Bos
# HG changeset patch # User Kees Bos # Date 1500565189 0 #  Thu Jul 20 15:39:49 2017 + # Node ID 327f18e079b175b14277a23e75715f5feee34d69 # Parent  863b862534d7ac0dbf8babf68b824de6fb0d6ef4 Add proxy_protocol option to mail listener Add support for the mail

Re: [PATCH] Allows hyphens in variable names so can access hyphenated query vars

2017-08-07 Thread Maxim Dounin
Hello! On Wed, Aug 02, 2017 at 11:30:11AM +, Mark Ellis via nginx-devel wrote: > # HG changeset patch > # User Mark Ellis > # Date 1501670303 -3600 > # Wed Aug 02 11:38:23 2017 +0100 > # Node ID 08008b0d1f4ffbd017d9f50142bdd46d7c4a41d2 > # Parent

Re: [PATCH] Add proxy_protocol option to mail listener

2017-08-07 Thread Wayde Nie
On 08/07/2017 03:44 AM, Kees Bos wrote:, and when I do set >> proxy_protocol >> on the listen directive I see the correct ip and port picked up and >> logged in the error.log, however, then nginx stops sending the smtp >> greeting... My mail client connects to my loadbalancer, the lb >> connects

RE: Add support for buffering in scripted logs

2017-08-07 Thread Eran Kornblau
Sorry for spamming... forgot to write - something that I know is missing in this patch is support for 'reopen files' (USR1) In order to handle that, I probably need to add an rbtree on cycle->open_files (the O(n) search that is currently performed in ngx_conf_open_file doesn't seem appropriate

Add support for buffering is scripted logs

2017-08-07 Thread Eran Kornblau
Hi all, The attached patch adds support for log buffering when using variables in the access log file name. The use case is this - we use nginx to receive analytics beacons and write them to the access log. We'd like to have a log file per hour that contains the logs of the specific hour. If

[nginx] Upstream: copy peer data in shared memory.

2017-08-07 Thread Ruslan Ermilov
details: http://hg.nginx.org/nginx/rev/ac120e797d28 branches: changeset: 7080:ac120e797d28 user: Ruslan Ermilov date: Fri Aug 04 17:03:10 2017 +0300 description: Upstream: copy peer data in shared memory. This, in addition to 1eb753aa8e5e, fixes "upstream zone" on

Re: [PATCH] Add proxy_protocol option to mail listener

2017-08-07 Thread Kees Bos
On za, 2017-08-05 at 20:44 -0400, Wayde Nie wrote: > Hi Kees, Maxim, > > I'm very interested in proxy_protocol enabled nginx mail proxy as > well. > Wondering if the feature might be more straightforward (initially?) > if, > when enabled on the listen line, it simply set the appropriate >