[njs] Modules: sorting external object property descriptors alphabetically.

2022-08-24 Thread Dmitry Volyntsev
details: https://hg.nginx.org/njs/rev/e023db05004f branches: changeset: 1934:e023db05004f user: Dmitry Volyntsev date: Wed Aug 24 17:04:58 2022 -0700 description: Modules: sorting external object property descriptors alphabetically. diffstat: nginx/ngx_http_js_module.c | 357 ++

Re: [WIP/RFC v4 0/5] Support abstract Unix sockets

2022-08-24 Thread Alejandro Colomar
Hi Maxim, On 8/25/22 00:14, Maxim Dounin wrote: [...] in most production setups it makes no difference, yet used to introduce various issues. The only one I can think of is security, since you don't have file permissions, but one could also argue that the security can't be lower than that of

Re: [WIP/RFC v4 0/5] Support abstract Unix sockets

2022-08-24 Thread Maxim Dounin
Hello! On Wed, Aug 24, 2022 at 08:15:40PM +0200, Alejandro Colomar wrote: > Hello Maxim! > > On 8/24/22 18:00, Maxim Dounin wrote: > [...] > >> For having nginx as a reverse proxy in front of a server, such as unit, > >> it's faster to communicate through Unix sockets (UDS), rather than TCP > >>

Re: Precedence return directive and nested locations

2022-08-24 Thread Maxim Dounin
Hello! On Wed, Aug 24, 2022 at 07:38:02PM +0200, Dipl. Ing. Sergey Brester via nginx-devel wrote: > it seems that the question of precedence of non-conditional _return_ > directive vs nested _location_s is not really clear, > or rather some constellations (like fallback) are impossible or else t

Re: [WIP/RFC v4 0/5] Support abstract Unix sockets

2022-08-24 Thread Alejandro Colomar
Hello Maxim! On 8/24/22 18:00, Maxim Dounin wrote: [...] For having nginx as a reverse proxy in front of a server, such as unit, it's faster to communicate through Unix sockets (UDS), rather than TCP (localhost). I would rather say "it's a common misconception that it's faster to communicate t

Re: Precedence return directive and nested locations

2022-08-24 Thread Dipl. Ing. Sergey Brester via nginx-devel
OK, regarding the "fallback" location, this one can be used (empty - shortest match): location "" { return 444; } Regards, Serg. 24.08.2022 19:38, Sergey Brester via nginx-devel wrote: > Hi, > > it seems that the question of precedence of non-conditional _return_ > directive vs nest

Precedence return directive and nested locations

2022-08-24 Thread Dipl. Ing. Sergey Brester via nginx-devel
Hi, it seems that the question of precedence of non-conditional _return_ directive vs nested _location_s is not really clear, or rather some constellations (like fallback) are impossible or else the configuration may look weird. For instance: server { server_name ...; location ~ ^/(some-

Re: [WIP/RFC v4 0/5] Support abstract Unix sockets

2022-08-24 Thread Maxim Dounin
Hello! On Wed, Aug 24, 2022 at 05:21:48PM +0200, Alejandro Colomar wrote: > Hi Maxim, > > On 8/24/22 16:58, Maxim Dounin wrote: > > Hello! > > > > On Wed, Aug 24, 2022 at 01:00:26AM +0200, Alejandro Colomar wrote: > > > >> I'll resend v4 in a moment, since it didn't arrive to the list. > >> >

Re: [WIP/RFC v4 0/5] Support abstract Unix sockets

2022-08-24 Thread Alejandro Colomar
Hi Maxim, On 8/24/22 16:58, Maxim Dounin wrote: Hello! On Wed, Aug 24, 2022 at 01:00:26AM +0200, Alejandro Colomar wrote: I'll resend v4 in a moment, since it didn't arrive to the list. On 8/23/22 23:18, Alejandro Colomar wrote: Hi, Patch set ready for review. Both 'listen' and 'proxy_pass

Re: [WIP/RFC v4 0/5] Support abstract Unix sockets

2022-08-24 Thread Maxim Dounin
Hello! On Wed, Aug 24, 2022 at 01:00:26AM +0200, Alejandro Colomar wrote: > I'll resend v4 in a moment, since it didn't arrive to the list. > > On 8/23/22 23:18, Alejandro Colomar wrote: > > Hi, > > > > Patch set ready for review. > > Both 'listen' and 'proxy_pass' work fine, with the only cave

Re: [WIP/RFC v4 0/5] Support abstract Unix sockets

2022-08-24 Thread Alejandro Colomar
On 8/24/22 11:57, Alejandro Colomar wrote: And of course this one didn't make it to the list either.  See this mail for knowing how it works. Cheers, Alex On 8/23/22 23:56, Alejandro Colomar wrote: > Hi, > > On 8/23/22 23:18, Alejandro Colomar wrote: >> Alejandro Colomar (5): >>    Opt

Re: [WIP/RFC v4 0/5] Support abstract Unix sockets

2022-08-24 Thread Alejandro Colomar
And of course this one didn't make it to the list either. See this mail for knowing how it works. Cheers, Alex On 8/23/22 23:56, Alejandro Colomar wrote: > Hi, > > On 8/23/22 23:18, Alejandro Colomar wrote: >> Alejandro Colomar (5): >>Optimize string copy in Unix sockets. >>Use a mini