Re: [PATCH] Added asm ISB as asm pause for ngx_cpu_pause() for aarch64

2023-12-13 Thread Maxim Dounin
Hello! On Wed, Dec 13, 2023 at 04:16:15PM -0600, Julio Suarez wrote: > 1. > > Yes, double checked configuration (what I'm running isn't exactly what's > in that link). No shared memory zones or thread pools enabled. Sounds > like a change in configuration is needed to test this. > > Would

Re: [PATCH] Added asm ISB as asm pause for ngx_cpu_pause() for aarch64

2023-12-13 Thread Julio Suarez
Hi, This is very discussion helpful. 1. Yes, double checked configuration (what I'm running isn't exactly what's in that link). No shared memory zones or thread pools enabled. Sounds like a change in configuration is needed to test this. Would enabling proxy_cache_path be sufficient for

Re: processing a request without body

2023-12-13 Thread Vasiliy Soshnikov
Sorry I'm bad. I understood that header filters won't help you. Use the ACCESS PHASE handler, it should work fine for you. On Wed, Dec 13, 2023 at 10:57 PM Vasiliy Soshnikov < vasiliy.soshni...@gmail.com> wrote: > Hello, > > > Is there something similar done before? > I'm thinking that you would

Re: processing a request without body

2023-12-13 Thread Vasiliy Soshnikov
Hello, > Is there something similar done before? I'm thinking that you would like to test the incoming path and execute some logic. You could use a header filter for that and also you could keep a body filter for handling the request body. Also pls take a look into PHASEs, I'm thinking you could

Re: processing a request without body

2023-12-13 Thread Maxim Dounin
Hello! On Wed, Dec 13, 2023 at 03:55:56PM +0800, Muhammad Nuzaihan wrote: > I need to process requests with only URI path (without body) for a module. > > It seems ngx_http_request_body_filter_pt is *not* executed whenever > there is a request without a body (it looked like it bypassed without

Core: Avoid memcpy from NULL

2023-12-13 Thread Ben Kallus
Nginx executes numerous `memcpy`s from NULL during normal execution. `memcpy`ing to or from NULL is undefined behavior. Accordingly, some compilers (gcc -O2) make optimizations that assume `memcpy` arguments are not NULL. Nginx with UBSan crashes during startup due to this issue. Consider the

Re: [PATCH 1 of 3] Stream: socket peek in preread phase

2023-12-13 Thread Sergey Kandaurov
On Wed, Dec 13, 2023 at 06:06:59PM +0400, Roman Arutyunyan wrote: > Hi, > # HG changeset patch > # User Roman Arutyunyan > # Date 1702476295 -14400 > # Wed Dec 13 18:04:55 2023 +0400 > # Node ID 844486cdd43a32d10b78493d7e7b80e9e2239d7e > # Parent 6c8595b77e667bd58fd28186939ed820f2e55e0e >

Re: [PATCH 3 of 3] Stream: ngx_stream_pass_module

2023-12-13 Thread Sergey Kandaurov
> On 10 Nov 2023, at 14:07, Roman Arutyunyan wrote: > > # HG changeset patch > # User Roman Arutyunyan > # Date 1699543504 -14400 > # Thu Nov 09 19:25:04 2023 +0400 > # Node ID 3cab85fe55272835674b7f1c296796955256d019 > # Parent 1d3464283405a4d8ac54caae9bf1815c723f04c5 > Stream:

Re: [PATCH 1 of 3] Stream: socket peek in preread phase

2023-12-13 Thread Roman Arutyunyan
Hi, On Tue, Dec 12, 2023 at 05:17:31PM +0400, Sergey Kandaurov wrote: > > > On 10 Nov 2023, at 14:07, Roman Arutyunyan wrote: > > > > # HG changeset patch > > # User Roman Arutyunyan > > # Date 1699456644 -14400 > > # Wed Nov 08 19:17:24 2023 +0400 > > # Node ID

Re: [PATCH 2 of 3] Stream: virtual servers

2023-12-13 Thread Sergey Kandaurov
> On 10 Nov 2023, at 14:07, Roman Arutyunyan wrote: > > # HG changeset patch > # User Roman Arutyunyan > # Date 1699035295 -14400 > # Fri Nov 03 22:14:55 2023 +0400 > # Node ID 1d3464283405a4d8ac54caae9bf1815c723f04c5 > # Parent 966331bb4936888ef2f034aa2700c130514d0b57 > Stream: virtual

Re: processing a request without body

2023-12-13 Thread Muhammad Nuzaihan
Hi, Sorry about the previous email. I meant ngx_http_top_request_body_filter is not executed whenever there is no body. Thank you, Muhammad Nuzaihan On Wed, Dec 13, 2023 at 3:55 PM Muhammad Nuzaihan wrote: > > Hi, > > I need to process requests with only URI path (without body) for a module. >