Re: Core: Avoid memcpy from NULL

Hi, Here's a similar ticket in another OSS. https://github.com/bellard/quickjs/issues/225#issuecomment-1908279228 > QuickJS may pass NULL pointers to memcpy with zero size. The C spec tells it is an undefined behavior but most C code do it, so the spec should be fixed instead. On Wed, Jan 24, 202

[PATCH] Enforce that CR precede LF in chunk lines

The HTTP/1.1 standards allow the recognition of bare LF as a line terminator in some contexts. From RFC 9112 Section 2.2: > Although the line terminator for the start-line and fields is the sequence > CRLF, a recipient MAY recognize a single LF as a line terminator and ignore > any preceding CR.

Re: Nginx-tests stream_ssl_conf_command.t test hanging indefinitely

> On 25 Jan 2024, at 01:15, Mayerhofer, Austin via nginx-devel > wrote: > > Hi all, > Apologies if I sent this twice, I don’t think the first one went through > because I wasn’t subscribed to the list. > nginx-tests’ stream_ssl_conf_command.t is hanging for me and not running to > completio

Nginx-tests stream_ssl_conf_command.t test hanging indefinitely

Hi all, Apologies if I sent this twice, I don’t think the first one went through because I wasn’t subscribed to the list. nginx-tests’ stream_ssl_conf_command.t is hanging for me and not running to completion, I’m using the following configuration: OS: MacOS 12.6.3 Chip: Apple M1 Max NGINX: 1.

[PATCH 2 of 2] Fixed dirindex and varindex to output top level module name

# HG changeset patch # User Sergey Kandaurov # Date 1706112783 -14400 # Wed Jan 24 20:13:03 2024 +0400 # Node ID cf7c914743d1d549af23a9f39e0a70377432fcf4 # Parent e798f596b284259985e35f1486b31004fae00d4d Fixed dirindex and varindex to output top level module name. diff --git a/xsls/link.xsl

[PATCH 1 of 2] Fixed build warnings "failed to load external entity"

# HG changeset patch # User Sergey Kandaurov # Date 1706112528 -14400 # Wed Jan 24 20:08:48 2024 +0400 # Node ID e798f596b284259985e35f1486b31004fae00d4d # Parent e3116677300fa455200da63002c746aece689029 Fixed build warnings "failed to load external entity". diff --git a/xml/ru/docs/njs/ind

Re: [PATCH] SSL: Added SSLKEYLOGFILE key material to debug logging

Hello, Thanks for the feedback. On Wed, 24 Jan 2024 12:20:59 +0300 Maxim Dounin wrote: > Hello! > > On Sun, Jan 21, 2024 at 10:37:24AM +, J Carter wrote: > > > # HG changeset patch > > # User J Carter > > # Date 1705832811 0 > > # Sun Jan 21 10:26:51 2024 + > > # Node ID b00332a

Re: [PATCH] SSL: Added SSLKEYLOGFILE key material to debug logging

Chiming in from the sidelines... On 24/01/2024 09:20, Maxim Dounin wrote: Logging session keying material is known to be problematic from ethical point of view. As such, I would rather avoid introducing relevant functionality in nginx. I agree the above (not adding this) would be the better

Re: [PATCH] SSL: Added SSLKEYLOGFILE key material to debug logging

Hello! On Sun, Jan 21, 2024 at 10:37:24AM +, J Carter wrote: > # HG changeset patch > # User J Carter > # Date 1705832811 0 > # Sun Jan 21 10:26:51 2024 + > # Node ID b00332a5253eefb53bacc024c72f55876c2eac6e > # Parent ee40e2b1d0833b46128a357fbc84c6e23be9be07 > SSL: Added SSLKEYLOG

Re: Core: Avoid memcpy from NULL

Hello! On Wed, Jan 24, 2024 at 12:09:02AM +, Ben Kallus wrote: > > As already pointed out previously, there are no known cases > > when memcpy(p, NULL, 0) can result in miscompilation of nginx > > code, ... If you think there are cases when the code can be > > miscompiled in practice, and no