Re: [PATCH] Documented accept_filter, deferred, setfib in stream listen

[...] >> @@ -154,6 +157,15 @@ >> >> >> >> +setfib=number >> + >> + >> +this parameter (1.25.4) sets the associated routing table, FIB > > Wrong version here and throughout the patch, > otherwise looks good (together with the "fastopen bind" patch). [...] Thank you for the review, the

[PATCH] Documented accept_filter, deferred, setfib in stream listen

xml/en/docs/stream/ngx_stream_core_module.xml | 44 -- xml/ru/docs/stream/ngx_stream_core_module.xml | 44 -- 2 files changed, 80 insertions(+), 8 deletions(-) # HG changeset patch # User Yaroslav Zhuravlev # Date 1706699963 0 # Wed Jan 31

[PATCH] Mentioned fastopen in stream listen bind

xml/en/docs/stream/ngx_stream_core_module.xml | 6 -- xml/ru/docs/stream/ngx_stream_core_module.xml | 6 -- 2 files changed, 8 insertions(+), 4 deletions(-) # HG changeset patch # User Yaroslav Zhuravlev # Date 1711378668 0 # Mon Mar 25 14:57:48 2024 + # Node ID

Re: [PATCH] Documented opensourcing of the OTel module

Hi, Thank you for the review, committed: http://hg.nginx.org/nginx.org/rev/48c688d80004 > On 6 Feb 2024, at 11:44, Yaroslav Zhuravlev wrote: > > Hi Maxim, > > Thank you for your comments, fixed, new version ready. > >>> >>> -The ngx_

Re: [PATCH] Documented opensourcing of the OTel module

> I don't see reasons to provide additional links here. Rather, the > note probably can be removed altogether, or changed to something > like "In previuos versions, this module is available...". Removed, thanks [...] New version: # HG changeset patch # User Yaroslav Zhuravlev #

[PATCH] Documented opensourcing of the OTel module

xml/en/docs/index.xml | 8 +++- xml/en/docs/ngx_otel_module.xml | 20 +++- xml/ru/docs/index.xml | 10 -- 3 files changed, 30 insertions(+), 8 deletions(-) # HG changeset patch # User Yaroslav Zhuravlev # Date 1704815768 0 # Tue Jan 09

[PATCH] Year 2024

GNUmakefile | 2 +- text/LICENSE | 2 +- xml/menu.xml | 1 + 3 files changed, 3 insertions(+), 2 deletions(-) # HG changeset patch # User Yaroslav Zhuravlev # Date 1706014530 0 # Tue Jan 23 12:55:30 2024 + # Node ID 9fa58eaa9b8fd4dcd9677d37a86140f945eaf7c6 # Parent

Re: [PATCH] Linux packages: documented nginx-module-otel package

> On 24 Oct 2023, at 23:16, Konstantin Pavlov wrote: > > # HG changeset patch > # User Konstantin Pavlov > # Date 1698185777 25200 > # Tue Oct 24 15:16:17 2023 -0700 > # Node ID aa09c0e4358bfbc98b051e536c25b74f5568f393 > # Parent 00c220310f537af2654cd3a04780f36ef5518014 > Linux

Re: [PATCH] Added info about the Unit 1.31.1 release

Hi Artem, > On 19 Oct 2023, at 16:52, Artem Konev wrote: > > xml/index.xml | 7 +++ > 1 files changed, 7 insertions(+), 0 deletions(-) > > > # HG changeset patch > # User Artem Konev > # Date 1697730616 -3600 > # Thu Oct 19 16:50:16 2023 +0100 > # Node ID

Re: [PATCH] Updated OpenSSL and zlib versions

[...] >> ---with-zlib=../zlib-1.2.11 >> +--with-zlib=../zlib-1.2.13 >> >> >> > > zlib 1.3 was recently released and works just fine, so this > probably should be bumped to 1.3 instead. > >> diff --git a/xml/en/docs/howto_build_on_win32.xml >> b/xml/en/docs/howto_build_on_win32.xml

[PATCH] Updated OpenSSL and zlib versions

xml/en/docs/configure.xml| 6 +++--- xml/en/docs/howto_build_on_win32.xml | 10 +- xml/ru/docs/configure.xml| 6 +++--- 3 files changed, 11 insertions(+), 11 deletions(-) # HG changeset patch # User Yaroslav Zhuravlev # Date 1695733917 -3600 # Tue Sep

Re: [PATCH] Minor docs fixes

> On 1 Sep 2023, at 14:00, Ryan Davis via nginx-devel > wrote: > > Thanks for the feedback Yaroslav! Updated patch is attached with the > suggested commit log, whitespace, and `rev` changes. No problem at all, thank you for the patch, committed:

Re: [PATCH] Minor docs fixes

Hi, > On 31 Aug 2023, at 21:43, Sergey A. Osokin wrote: > > Hi, > > here's the patch from Ryan. > > On Thu, Aug 31, 2023 at 08:31:34PM +, Ryan Davis via nginx-devel wrote: >> Apologies, the corporate SMTP server is doing something unexpected. > > # HG changeset patch > # User Ryan Davis

Re: [PATCH] Added info about the Unit 1.31.0 release

> On 31 Aug 2023, at 20:08, Artem Konev wrote: > > xml/index.xml | 8 > 1 files changed, 8 insertions(+), 0 deletions(-) > > > # HG changeset patch > # User Artem Konev > # Date 1693508808 -3600 > # Thu Aug 31 20:06:48 2023 +0100 > # Node ID

Re: [PATCH] Documented the http2 directive

as well. > > Do not insist on adding it right now though, a separate patch > clarifying the details should be good enough. > > [...] > Thank you, the patch was updated with Sergey comments, and I'll create a separate patch explaining these details. # HG changeset patch #

Re: [PATCH] Updated link to HTTP/2 RFC

.ietf.org/doc/html/rfc9113#section-8.4;>push) >> +запрос к заданному uri > > unnecessary line re-wrap Thank you, patch updated: # HG changeset patch # User Yaroslav Zhuravlev # Date 1686668773 -3600 # Tue Jun 13 16:06:13 2023 +0100 # Node ID 412c0e5eabcc4e1b988e3166b2b9404

[PATCH] Updated link to HTTP/2 RFC

xml/en/docs/http/ngx_http_v2_module.xml | 8 xml/ru/docs/http/ngx_http_v2_module.xml | 10 +- 2 files changed, 9 insertions(+), 9 deletions(-) # HG changeset patch # User Yaroslav Zhuravlev # Date 1686664851 -3600 # Tue Jun 13 15:00:51 2023 +0100 # Node ID

[PATCH] Documented removal of the ssl directive

Yaroslav Zhuravlev # Date 1686664761 -3600 # Tue Jun 13 14:59:21 2023 +0100 # Node ID d3d92847093849fe5aabc0f691409eae116390bc # Parent 4bb6a5759758dab2351f70cdd5942a7d1ed03e99 Documented removal of the ssl directive. diff --git a/xml/en/docs/http/ngx_http_ssl_module.xml b/xml/en/docs/http

[PATCH] Deprecated HTTP/2 Server Push directives

xml/en/docs/http/ngx_http_v2_module.xml | 20 +++- xml/ru/docs/http/ngx_http_v2_module.xml | 20 +++- 2 files changed, 38 insertions(+), 2 deletions(-) # HG changeset patch # User Yaroslav Zhuravlev # Date 1686664669 -3600 # Tue Jun 13 14:57:49 2023 +0100

[PATCH] Documented the http2 directive

-- xml/ru/docs/http/ngx_http_v2_module.xml | 22 -- 6 files changed, 63 insertions(+), 14 deletions(-) # HG changeset patch # User Yaroslav Zhuravlev # Date 1686664161 -3600 # Tue Jun 13 14:49:21 2023 +0100 # Node ID d0b3b7889bfa45ce03845acdc51919463f455874

[PATCH] Updated QUIC documentation after QUIC code merge

++ 10 files changed, 310 insertions(+), 402 deletions(-) # HG changeset patch # User Yaroslav Zhuravlev # Date 1684852637 -3600 # Tue May 23 15:37:17 2023 +0100 # Node ID 9015546a429e45497c7d189e0f3a77423254e019 # Parent c7bf5c9a1174695b7505b8d1b7a94fe6abff318f Updated QUIC

Re: [PATCH] Added direct link to release announcement for Unit 1.30.0

Looks good > On 11 May 2023, at 12:16, Artem Konev wrote: > > xml/index.xml | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > > # HG changeset patch > # User Artem Konev > # Date 1683803670 -3600 > # Thu May 11 12:14:30 2023 +0100 > # Node ID

Re: [PATCH] Added TLSv1.3 to the default value of ssl_protocols and friends

> On 24 Mar 2023, at 15:30, Maxim Konovalov wrote: > > Hi Yar, > > On 21.03.2023 00:19, Yaroslav Zhuravlev wrote: >> diff --git a/xml/en/docs/http/ngx_http_grpc_module.xml >> b/xml/en/docs/http/ngx_http_grpc_module.xml >> --- a/xml/en/docs/http/ngx_http_grp

[PATCH] Added TLSv1.3 to the default value of ssl_protocols and friends

/ngx_stream_proxy_module.xml | 4 ++-- xml/ru/docs/stream/ngx_stream_ssl_module.xml | 6 +++--- 16 files changed, 52 insertions(+), 42 deletions(-) # HG changeset patch # User Yaroslav Zhuravlev # Date 1678486627 0 # Fri Mar 10 22:17:07 2023 + # Node ID 477d0fe1e6cb95533ffb80de0b8851d8ec7c0fba # Parent

Re: [PATCH 2 of 2] Fixed article in "if_modified_since before"

> On 3 Jan 2023, at 22:11, Maxim Dounin wrote: > > # HG changeset patch > # User Maxim Dounin > # Date 1672783715 -10800 > # Wed Jan 04 01:08:35 2023 +0300 > # Node ID 547303412ab9bf1b22820b459143bd48d051f92f > # Parent 52ea1f45b324b404941a9b31b2861612cf090fcd > Fixed article in

Re: [PATCH 1 of 2] Clarified "if_modified_since off" behaviour (ticket #2176)

> On 3 Jan 2023, at 22:11, Maxim Dounin wrote: > > # HG changeset patch > # User Maxim Dounin > # Date 1672783626 -10800 > # Wed Jan 04 01:07:06 2023 +0300 > # Node ID 52ea1f45b324b404941a9b31b2861612cf090fcd > # Parent 8033ffaedeb9f029897d464d85454b9cffa35fd9 > Clarified

Re: [PATCH] Updated advisory links

> On 1 Jan 2023, at 19:18, Maxim Dounin wrote: > > # HG changeset patch > # User Maxim Dounin > # Date 1672600531 -10800 > # Sun Jan 01 22:15:31 2023 +0300 > # Node ID 165e9f39cfc8815cfc18b7cf6cbf712059585608 > # Parent 8033ffaedeb9f029897d464d85454b9cffa35fd9 > Updated advisory links. >

Re: [PATCH] Documented automatic rotation of TLS ticket keys for stream/mail

> On 22 Dec 2022, at 10:45, Sergey Kandaurov wrote: > >> >> On 22 Dec 2022, at 14:38, Yaroslav Zhuravlev wrote: >> >> xml/en/docs/mail/ngx_mail_ssl_module.xml | 6 +- >> xml/en/docs/stream/ngx_stream_ssl_module.xml | 6 +- >> xml/ru/

[PATCH] Documented automatic rotation of TLS ticket keys for stream/mail

changeset patch # User Yaroslav Zhuravlev # Date 1671705355 0 # Thu Dec 22 10:35:55 2022 + # Node ID 8033ffaedeb9f029897d464d85454b9cffa35fd9 # Parent b2249a72e3deb9f2c3d213667cc5176db5ec2738 Documented automatic rotation of TLS ticket keys for stream/mail. diff --git a/xml/en/docs/mail

Re: [PATCH] Fixed typo in the sticky directive

[...] > # HG changeset patch > # User Sergey A. Osokin > # Date 1671031009 -10800 > # Wed Dec 14 18:16:49 2022 +0300 > # Node ID 72b76e78e2845278b7a93bffe953a17077cd5f70 > # Parent 178f55cf631aa1c87281667b63e6cc3139459d8b > Fixed typo in the sticky directive > > diff -r 178f55cf631a -r

Re: [PATCH] fix "the the" typo

Hi Sergey, Thank you for the diff, it also requires a commit log message, smth like "Fixed typo in the sticky directive", otherwise the diff looks good. > On 14 Dec 2022, at 01:29, Sergey A. Osokin wrote: > > Hi, > > here's the patch to fix "the the" typo. > > Thank you. > > -- > Sergey

Re: nginx 1.23.3 changes draft

> On 13 Dec 2022, at 15:00, Maxim Dounin wrote: > > Hello! > > > Changes with nginx 1.23.313 Dec 2022 > >*) Bugfix: an error might occur when reading PROXY protocol version 2 > header with large number of TLVs. > >*) Bugfix: a

[PATCH] Documented the $proxy_protocol_tlv_ variable

+- 4 files changed, 420 insertions(+), 4 deletions(-) # HG changeset patch # User Yaroslav Zhuravlev # Date 1666118553 -3600 # Tue Oct 18 19:42:33 2022 +0100 # Node ID 881627fb56bfff009297b6cc15cd1f5d58ebc030 # Parent 3f5e91af4a52c5b8bbc75c0ea31e3ceac0bebea8

Re: [PATCH] Documented automatic rotation of TLS session ticket keys

> On 4 Oct 2022, at 15:22, Sergey Kandaurov wrote: > >> >> On 4 Oct 2022, at 00:17, Yaroslav Zhuravlev wrote: >> >> xml/en/docs/http/ngx_http_ssl_module.xml | 5 - >> xml/ru/docs/http/ngx_http_ssl_module.xml | 5 - >> 2 files changed, 8 ins

Re: [PATCH] Documented behaviour of a single server in upstream with keepalive

> On 10 Oct 2022, at 00:55, Maxim Dounin wrote: > > Hello! > > On Mon, Oct 03, 2022 at 09:21:52PM +0100, Yaroslav Zhuravlev wrote: > >> # HG changeset patch >> # User Yaroslav Zhuravlev >> # Date 1663861151 -3600 >> # T

[PATCH] Documented behaviour of a single server in upstream with keepalive

changeset patch # User Yaroslav Zhuravlev # Date 1663861151 -3600 # Thu Sep 22 16:39:11 2022 +0100 # Node ID aa3505dc76f13086703543cb079a13e48c57386e # Parent 9708787aafc70744296baceb2aa0092401a4ef34 Documented behaviour of a single server in upstream with keepalive. diff --git a/xml/en/docs

[PATCH] Documented automatic rotation of TLS session ticket keys

xml/en/docs/http/ngx_http_ssl_module.xml | 5 - xml/ru/docs/http/ngx_http_ssl_module.xml | 5 - 2 files changed, 8 insertions(+), 2 deletions(-) # HG changeset patch # User Yaroslav Zhuravlev # Date 1664828002 -3600 # Mon Oct 03 21:13:22 2022 +0100 # Node ID

Re: [PATCH] Documented the "ipv4=off" parameter of the "resolver" directive

ve variant: ""By default, nginx will look up both IPv4 and IPv6 addresses while resolving. If looking up of of either address family is not desired, the ipv4=off (1.23.1) or the ipv6=off parameter can be specified." # HG changeset patch # User Yaroslav Zhuravlev # Date 1658236202 -

Re: [PATCH] Documented the "ipv4=off" parameter of the "resolver" directive

uot;ipv6=off"? > > It might be also a good idea to describe "ipv6=off" and > "ipv4=off" in one sentence instead of repeating the same phrase > twice. > Hi Maxim, Thank you for your feedback, the patch reworked, in the new version the changes are minimal

[PATCH] Documented the "ipv4=off" parameter of the "resolver" directive

+++- xml/ru/docs/stream/ngx_stream_core_module.xml | 8 +++- 6 files changed, 42 insertions(+), 6 deletions(-) # HG changeset patch # User Yaroslav Zhuravlev # Date 1657820606 -3600 # Thu Jul 14 18:43:26 2022 +0100 # Node ID ef51bb5722334aea46d2846d7a30d671b0f624db # Parent

Re: limit_req_zone Documentation Wrong

Hello Aidan, > On 24 Jan 2020, at 22:17, Aidan Carson wrote: > > Hello, > > I believe the documentation for the limit_req_zone directive on this page is > wrong: > > http://nginx.org/en/docs/http/ngx_http_limit_req_module.html > > It says that a rate parameter is not optional, but it is.

Re: [PATCH] Grammar fixes

Hello Ville, > On 25 Dec 2019, at 10:29, Ville Skyttä wrote: > > # HG changeset patch > # User Ville Skyttä > # Date 1577258677 -7200 > # Wed Dec 25 09:24:37 2019 +0200 > # Node ID f4b83914e4009fb9c528f0318287a76aa0c7326f > # Parent e99e9b0a8c51d59c7ee665489949d8556565adff > Grammar

Re: nginx documentation

[...] > > One more question: > > Directive limit_zone still exists in nginx documentation, but this > directive was removed from nginx in version 1.7.6, long time ago. > > This is the only one directive, which is removed from nginx, > but still exists in nginx documentation on site nginx.org. >

Re: nginx undocumented directives

Hello! […] >> But directive subrequest_output_buffer_size is still undocumented. >> >> It is added by http://hg.nginx.org/nginx/rev/20f139e9ffa8#l4.7 >> >> It is undocumented by mistake (and will be documented in near future) >> or it is undocumented by purpose and it will be never documented

Re: [PATCH] Fix minor flaws in gzip_proxied documentation

7020b8262dc0339c56b2d80c911b112b6f5b1a7a Fix minor flaws in gzip_proxied documentation [...] Hi Gunnlaugur, Thank you, the patch was committed with few minor changes (version bump, commit log): http://nginx.org/en/docs/http/ngx_http_gzip_module.html#gzip_proxied Best regards, Yaroslav Zhuravlev