Re: [PATCH] Core: slight optimization in ngx_chain_update_chains()

2016-11-11 Thread Maxim Dounin
Hello! On Fri, Nov 11, 2016 at 10:38:55AM +0800, 胡聪 (hucc) wrote: > Hello! > > > On Fri, Nov 11, 2016 at 0:55 AM, Maxim Dounin wrote: > > >Looking into this again I tend to think that better solution would > >be to test *out in additional if around all operations with *out, > >like this (dif

Re: [PATCH] Core: slight optimization in ngx_chain_update_chains()

2016-11-10 Thread 胡聪 (hucc)
Hello! On Fri, Nov 11, 2016 at 0:55 AM, Maxim Dounin wrote: >Looking into this again I tend to think that better solution would >be to test *out in additional if around all operations with *out, >like this (diff -w for clarity): > >@@ -186,6 +186,7 @@ ngx_chain_update_chains(ngx_pool_t *p, n >

Re: [PATCH] Core: slight optimization in ngx_chain_update_chains()

2016-11-10 Thread Maxim Dounin
Hello! On Thu, Nov 10, 2016 at 10:30:34AM +0800, 胡聪 (hucc) wrote: > Hi, > > I found that sometimes the *out is NULL when i was reading the code > of ngx_event_pipe.c . So it is not necessary to traverse *busy when > *out == NULL in ngx_chain_update_chains(). > > # HG changeset patch > # User h

[PATCH] Core: slight optimization in ngx_chain_update_chains()

2016-11-09 Thread 胡聪 (hucc)
Hi, I found that sometimes the *out is NULL when i was reading the code of ngx_event_pipe.c . So it is not necessary to traverse *busy when *out == NULL in ngx_chain_update_chains(). # HG changeset patch # User hucongcong # Date 1478744273 -28800 # Thu Nov 10 10:17:53 2016 +0800 # Node ID