Re: [PATCH] Core: use NGX_FILE_ERROR when appropriate

2013-03-25 Thread Valentin V. Bartenev
On Monday 25 March 2013 18:41:28 Maxim Dounin wrote: > Hello! > > On Mon, Mar 25, 2013 at 06:15:56PM +0400, Valentin V. Bartenev wrote: > > On Thursday 21 March 2013 08:04:24 Piotr Sikora wrote: > > > Hey guys, > > > attached patch changes "if" tests to use "== NGX_FILE_ERROR" instead of > > > "==

Re: [PATCH] Core: use NGX_FILE_ERROR when appropriate

2013-03-25 Thread Maxim Dounin
Hello! On Mon, Mar 25, 2013 at 06:15:56PM +0400, Valentin V. Bartenev wrote: > On Thursday 21 March 2013 08:04:24 Piotr Sikora wrote: > > Hey guys, > > attached patch changes "if" tests to use "== NGX_FILE_ERROR" instead of > > "== -1" or "!= NGX_OK", because NGX_FILE_ERROR is defined as -1 on UN

Re: [PATCH] Core: use NGX_FILE_ERROR when appropriate

2013-03-25 Thread Valentin V. Bartenev
On Thursday 21 March 2013 08:04:24 Piotr Sikora wrote: > Hey guys, > attached patch changes "if" tests to use "== NGX_FILE_ERROR" instead of > "== -1" or "!= NGX_OK", because NGX_FILE_ERROR is defined as -1 on UNIX, > but as 0 on Win32. The patch looks good. I'll commit it as soon as Maxim acknowl

[PATCH] Core: use NGX_FILE_ERROR when appropriate

2013-03-20 Thread Piotr Sikora
Hey guys, attached patch changes "if" tests to use "== NGX_FILE_ERROR" instead of "== -1" or "!= NGX_OK", because NGX_FILE_ERROR is defined as -1 on UNIX, but as 0 on Win32. This isn't much of an issue in patched code (only "ngx_fd_info()" test is actually reachable on Win32 and in worst case it m